From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35A39C43460 for ; Fri, 30 Apr 2021 16:32:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0FB606146D for ; Fri, 30 Apr 2021 16:32:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230331AbhD3Qcu (ORCPT ); Fri, 30 Apr 2021 12:32:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229720AbhD3Qct (ORCPT ); Fri, 30 Apr 2021 12:32:49 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C855FC06174A for ; Fri, 30 Apr 2021 09:31:59 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id o16so81519106ljp.3 for ; Fri, 30 Apr 2021 09:31:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=F8v+HHXbjl0aRx+srFPe53CclqNI7DAhH0N8QQsA8Lw=; b=B7bKcjbrRTZhgdTtCvlTiUk1WdGQherh0Mmc11ZSTTyN6h/ihUK+x7gawKbOvc05+0 UHA+KICT8A3M7D1COJUntw+wVyCiR+SfNXfOMnIoqnfAjje5li82NU2RjExsufGjxuRG FPSphBrQCXtSZaAg0mwSvj9E0f7SrgUf5bDlk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F8v+HHXbjl0aRx+srFPe53CclqNI7DAhH0N8QQsA8Lw=; b=NtBqd2dOs1qCJmBCNl6t+OhpYaKyyVb/4jhfaS4hDWLyExIncFqM7fnB+6IE3eXiQR TwshGcr/+Tfx+25q/bhg25tPZf6FrgbUgElqgnA9Pgj6Rwg33gzVTrQHoCsFbISUThBU Fhl/lOsKONvXR5+wdORs6LSyc7hA+46iaOplwoSRy3xdflHthKNlUMTfJQxxlEKCCM8M 5DPw7Tn8YDSp+E1xuZMdphnNpmPkc5irJOfiSwrg9QiJj6d6J7V0g2Km7Em4+yHB5Xhe B/l17tD245wypbPpu2LxCBYeHRcYlmHB5NzvWmIn4H4OXZZ4azFAJTWkMj7a3zP+uk0q jB6w== X-Gm-Message-State: AOAM5331UL52M/Yfj9vDgwVvf3Cg9G6Guvko6IlJvOKst+hWkAbk4rPK dhZ5EzAmCcE4zuKd/5nzGpccp40u8/8PCHON X-Google-Smtp-Source: ABdhPJxV1UQw0XEyKytSWfKYy/3r4JOas3Lx8LaHhrAj8nlszbKevzLwu56afjvRQiXARJjId76iLg== X-Received: by 2002:a2e:b4b4:: with SMTP id q20mr4354704ljm.327.1619800317679; Fri, 30 Apr 2021 09:31:57 -0700 (PDT) Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com. [209.85.167.42]) by smtp.gmail.com with ESMTPSA id d30sm328027lfv.198.2021.04.30.09.31.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Apr 2021 09:31:56 -0700 (PDT) Received: by mail-lf1-f42.google.com with SMTP id x20so80722019lfu.6 for ; Fri, 30 Apr 2021 09:31:56 -0700 (PDT) X-Received: by 2002:a05:6512:1095:: with SMTP id j21mr3707653lfg.40.1619800316007; Fri, 30 Apr 2021 09:31:56 -0700 (PDT) MIME-Version: 1.0 References: <20210430055445.hpofzhr9G%akpm@linux-foundation.org> In-Reply-To: From: Linus Torvalds Date: Fri, 30 Apr 2021 09:31:39 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch 030/178] kunit: add a KUnit test for SLUB debugging functionality To: Vlastimil Babka Cc: Andrew Morton , Christoph Lameter , glittao@gmail.com, Joonsoo Kim , Linux-MM , mm-commits@vger.kernel.org, Pekka Enberg , David Rientjes Content-Type: text/plain; charset="UTF-8" Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org On Fri, Apr 30, 2021 at 1:50 AM Vlastimil Babka wrote: > > Hi, but this is v3 [1]. Then there was v4 [2] (with a prerequisity [3]) with > many changes after feedback with kunit folks, which would be better. We could > apply v4 as improvement later but there would be extra churn (even the test .c > file is named differently). Merging v4 directly would make more sense. > > Anyway "[patch 031/178] slub: remove resiliency_test() function" (which the > kunit test replaces) can go either way as that code is dead and broken. I've removed patches 30 and 31 from the queue. Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E38CC433B4 for ; Fri, 30 Apr 2021 16:32:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 28DA260233 for ; Fri, 30 Apr 2021 16:32:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28DA260233 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3315E6B006C; Fri, 30 Apr 2021 12:32:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 308856B006E; Fri, 30 Apr 2021 12:32:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 182EA6B0070; Fri, 30 Apr 2021 12:32:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0226.hostedemail.com [216.40.44.226]) by kanga.kvack.org (Postfix) with ESMTP id EEB5A6B006C for ; Fri, 30 Apr 2021 12:32:00 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id A0854180AD807 for ; Fri, 30 Apr 2021 16:32:00 +0000 (UTC) X-FDA: 78089575200.19.810EA30 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) by imf03.hostedemail.com (Postfix) with ESMTP id EB981C0007C6 for ; Fri, 30 Apr 2021 16:31:53 +0000 (UTC) Received: by mail-lj1-f172.google.com with SMTP id o16so81519112ljp.3 for ; Fri, 30 Apr 2021 09:31:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=F8v+HHXbjl0aRx+srFPe53CclqNI7DAhH0N8QQsA8Lw=; b=B7bKcjbrRTZhgdTtCvlTiUk1WdGQherh0Mmc11ZSTTyN6h/ihUK+x7gawKbOvc05+0 UHA+KICT8A3M7D1COJUntw+wVyCiR+SfNXfOMnIoqnfAjje5li82NU2RjExsufGjxuRG FPSphBrQCXtSZaAg0mwSvj9E0f7SrgUf5bDlk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F8v+HHXbjl0aRx+srFPe53CclqNI7DAhH0N8QQsA8Lw=; b=tUEphr89gWGiO6ZafPyoTFgOE+YmpSfcNYC2jjGwcfWLfnwxGd64A0b/KMVCMgwW8i JGOGPxkgYJm7uvqRA+JF90K5GwieNzllHjUw3bkpZtHFvxdZo7hPyjvs50Fb7lK0duHH QqC1Yp+hu/WLfHa9PGVA5yWmRxSN5AnHsPjpIXmwxTyBkYjXR/M5BujjrQFYUAcjm+kG uAiKXIXoytkBcF8N9QZHQk9JM5Prkv41mg4KSeWaBCZrf5cmOYxCEEK83VCX4BT1E13j DSD/7qjRQ07AfjvE0Xv9QLWmqA3i9snzOE1TdOryZ1DvEwA4sCyj3eSd6BNY1lEzkAB+ GjGg== X-Gm-Message-State: AOAM533d75IXwRV6ndVSA6qYpeI7dyTFt3WBElch9RVBX7Vie1paqZjU vBUxj8Xd2NF1pZsH1NWZEYmk/Lgy8H31xmpV X-Google-Smtp-Source: ABdhPJyzQx5VJWvemET01wH+YSvHH4nuiq4F+7qRAY2rqStyIb3ZFPfS3RqDRoRo2F3gUQBsERX7Gg== X-Received: by 2002:a2e:5315:: with SMTP id h21mr4504682ljb.267.1619800317846; Fri, 30 Apr 2021 09:31:57 -0700 (PDT) Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com. [209.85.167.43]) by smtp.gmail.com with ESMTPSA id r10sm331116lfc.4.2021.04.30.09.31.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Apr 2021 09:31:56 -0700 (PDT) Received: by mail-lf1-f43.google.com with SMTP id x19so80663349lfa.2 for ; Fri, 30 Apr 2021 09:31:56 -0700 (PDT) X-Received: by 2002:a05:6512:1095:: with SMTP id j21mr3707653lfg.40.1619800316007; Fri, 30 Apr 2021 09:31:56 -0700 (PDT) MIME-Version: 1.0 References: <20210430055445.hpofzhr9G%akpm@linux-foundation.org> In-Reply-To: From: Linus Torvalds Date: Fri, 30 Apr 2021 09:31:39 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch 030/178] kunit: add a KUnit test for SLUB debugging functionality To: Vlastimil Babka Cc: Andrew Morton , Christoph Lameter , glittao@gmail.com, Joonsoo Kim , Linux-MM , mm-commits@vger.kernel.org, Pekka Enberg , David Rientjes Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=B7bKcjbr; dmarc=none; spf=pass (imf03.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.172 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org X-Stat-Signature: f67g7xkbni63nzhe13r5zmqqmnehzc61 X-Rspamd-Queue-Id: EB981C0007C6 X-Rspamd-Server: rspam05 Received-SPF: none (linuxfoundation.org>: No applicable sender policy available) receiver=imf03; identity=mailfrom; envelope-from=""; helo=mail-lj1-f172.google.com; client-ip=209.85.208.172 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619800313-999893 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 30, 2021 at 1:50 AM Vlastimil Babka wrote: > > Hi, but this is v3 [1]. Then there was v4 [2] (with a prerequisity [3]) with > many changes after feedback with kunit folks, which would be better. We could > apply v4 as improvement later but there would be extra churn (even the test .c > file is named differently). Merging v4 directly would make more sense. > > Anyway "[patch 031/178] slub: remove resiliency_test() function" (which the > kunit test replaces) can go either way as that code is dead and broken. I've removed patches 30 and 31 from the queue. Linus