From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7715C4346E for ; Thu, 24 Sep 2020 15:58:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 643CA238E3 for ; Thu, 24 Sep 2020 15:58:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600963119; bh=zGqUmQrVnv20+izFiV3UC6AOzauCZiTn6ikedLPqERk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=fF064yL++t/2EhMw6CtnfSNiJoHNY1HVjP4UCEKSMVLEiPI+Cj7IHL7INPAEKHqE0 6mFdh8Xoawc4s9fZFXeRvQYA+7bpSIYO9IRbM7TczFem/ALvim16Nj4xqjOcbACgFC S3ap9qh7aJrjC9Bngd7vI21Tag8uAPrAGMT7ngTQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728602AbgIXP6i (ORCPT ); Thu, 24 Sep 2020 11:58:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728381AbgIXP6h (ORCPT ); Thu, 24 Sep 2020 11:58:37 -0400 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7117CC0613D3 for ; Thu, 24 Sep 2020 08:58:37 -0700 (PDT) Received: by mail-lj1-x236.google.com with SMTP id k25so3235825ljk.0 for ; Thu, 24 Sep 2020 08:58:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CDlImHQG+WyGWW1Zw8OrcVApf/zvofomVSpORgyBHR8=; b=gU9H8quw0ODZD5j2ATVueoHOBIrQbytcaQkpJ4BOa0yac1xXfdXp3nabz+lI1bwWGC dGGlkRyJzpHFaqqmFSeoFPcO0NA7OALEi8rZ6V8mcAPas1TR0JLDs82By7cToOhXI/vl 5NkyAJespvEzlUiX6038sU2DCsPIsey/ykeCc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CDlImHQG+WyGWW1Zw8OrcVApf/zvofomVSpORgyBHR8=; b=MT44turq0xHT7bk0M3LxMUJF5MHL8GT2H0bd6NLGlnlIRHe9koScvNkWr4hmRTPvmR XbIQ2DytPOs7qcwomURQs+DB58nBDdKKhmYRTnm97LZsJ+lNreTPSd64VqLsNkZ2lZEc hBcPPw78NojCzQt/Nxdnf5FzMjoft8e2QxcEO+sc4Njxgpoe+C7yOL4UeEs/UMsnC83l yh3bPkcWI/8LaI+Wr8/b8BEw7Veay6IIP+y3bVFhVmCSVZ0NWDPvYKPD4bB0gwg+KCNW 7UUJSjWM1qkSoda2S6oQ2i7iUoHH9jODawLDNTOPGmk9NtzYv2YNyU2XAIrN4TZ48vli KnZw== X-Gm-Message-State: AOAM532Gm82VCeHLd+gwutApTn6Dt6vMTfIXZZWMbVF+wxhZfM9BFT/3 lEkxJyHqn0PYrro8wP2pg661Xu9qObsGaQ== X-Google-Smtp-Source: ABdhPJwCztssYuIbseGcBhTx55UEUTo86IEQ3E6ppZzRmXBAGoFpnlGJohhwfwA0Xl0yi5U8RMCwJw== X-Received: by 2002:a2e:b8c8:: with SMTP id s8mr155005ljp.127.1600963115513; Thu, 24 Sep 2020 08:58:35 -0700 (PDT) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com. [209.85.167.53]) by smtp.gmail.com with ESMTPSA id v196sm2386945lfa.96.2020.09.24.08.58.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Sep 2020 08:58:33 -0700 (PDT) Received: by mail-lf1-f53.google.com with SMTP id d15so4463705lfq.11 for ; Thu, 24 Sep 2020 08:58:33 -0700 (PDT) X-Received: by 2002:ac2:5594:: with SMTP id v20mr47607lfg.344.1600963112812; Thu, 24 Sep 2020 08:58:32 -0700 (PDT) MIME-Version: 1.0 References: <20200916142806.GD7076@osiris> <20200922190350.7a0e0ca5@thinkpad> <20200923153938.5be5dd2c@thinkpad> <20200923233306.7c5666de@thinkpad> <20200924000226.06298978@thinkpad> <20200924140638.7bcb7765@thinkpad> In-Reply-To: <20200924140638.7bcb7765@thinkpad> From: Linus Torvalds Date: Thu, 24 Sep 2020 08:58:15 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: BUG: Bad page state in process dirtyc0w_child To: Gerald Schaefer , Alex Shi Cc: Peter Xu , Heiko Carstens , Qian Cai , Alexander Gordeev , Vasily Gorbik , Christian Borntraeger , linux-s390 , Linux-MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 24, 2020 at 5:06 AM Gerald Schaefer wrote: > > It's all good now, no more occurrences with unlock_page() before > wp_page_reuse(). Thanks for the confirmation. When you pointed at that unlock_page() change, I was pretty sure that was it ("D'oh!"), but it's always good to have that verification. Committed, Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3351FC2D0E2 for ; Thu, 24 Sep 2020 15:58:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 73299238E3 for ; Thu, 24 Sep 2020 15:58:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="gU9H8quw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 73299238E3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CCA908E0007; Thu, 24 Sep 2020 11:58:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C7BB88E0001; Thu, 24 Sep 2020 11:58:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6AC48E0007; Thu, 24 Sep 2020 11:58:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0100.hostedemail.com [216.40.44.100]) by kanga.kvack.org (Postfix) with ESMTP id 9F75E8E0001 for ; Thu, 24 Sep 2020 11:58:39 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 56823363D for ; Thu, 24 Sep 2020 15:58:39 +0000 (UTC) X-FDA: 77298412758.10.can21_2816fb127160 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id 1D58416A0AE for ; Thu, 24 Sep 2020 15:58:39 +0000 (UTC) X-HE-Tag: can21_2816fb127160 X-Filterd-Recvd-Size: 4158 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Thu, 24 Sep 2020 15:58:37 +0000 (UTC) Received: by mail-lf1-f42.google.com with SMTP id y11so4510326lfl.5 for ; Thu, 24 Sep 2020 08:58:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CDlImHQG+WyGWW1Zw8OrcVApf/zvofomVSpORgyBHR8=; b=gU9H8quw0ODZD5j2ATVueoHOBIrQbytcaQkpJ4BOa0yac1xXfdXp3nabz+lI1bwWGC dGGlkRyJzpHFaqqmFSeoFPcO0NA7OALEi8rZ6V8mcAPas1TR0JLDs82By7cToOhXI/vl 5NkyAJespvEzlUiX6038sU2DCsPIsey/ykeCc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CDlImHQG+WyGWW1Zw8OrcVApf/zvofomVSpORgyBHR8=; b=NVJE/08oYuxfBbFfxt95C72734aDsfIcij8fcubfXky+N39o5G5xhff+Z0r2/Z5ZWd lmawc99Tun5HzWiS3Thn0r8Rgf7yfziJJ8wcjIBGx4B3Z7Fi0rDmL56tp6bhaf8l6SOJ WV+uJURhFOqG+wcDLXVWYFXOTZ+3jCcEE3pa7pBpGaz9B8iDE2+wQBoK7O6jJFHBs6oh wnN25bBnPxHWcpdFoJ+mleGGAexVCqsknvF3FavGBeKDWj6c51aGRD7ONp7mG++BYM8N 4K5kPKbcltPW9K3Vgt+NgG0Ul78utcExqeMk0tpvOgU5aLqhWTxJFvYhfJRztUjNwBRQ g0Lw== X-Gm-Message-State: AOAM5310AbOplAd5+t5B/bobwJ/8gBGQJRNYF5w0UxNWK1iAuueQq520 Z1l2NGHmOkB0fHCnXgCqnWkj0eR77JFgFg== X-Google-Smtp-Source: ABdhPJxVaWJaaC2oc5zXu1dMFTvbL3wBRqrF7+GWD6MzqodgiNJr1Oe5EPiOs9BbwEQj2H1Yn7cwyQ== X-Received: by 2002:a19:4c87:: with SMTP id z129mr34106lfa.189.1600963115404; Thu, 24 Sep 2020 08:58:35 -0700 (PDT) Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com. [209.85.167.44]) by smtp.gmail.com with ESMTPSA id m2sm2383402lfl.249.2020.09.24.08.58.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Sep 2020 08:58:33 -0700 (PDT) Received: by mail-lf1-f44.google.com with SMTP id 77so4542272lfj.0 for ; Thu, 24 Sep 2020 08:58:33 -0700 (PDT) X-Received: by 2002:ac2:5594:: with SMTP id v20mr47607lfg.344.1600963112812; Thu, 24 Sep 2020 08:58:32 -0700 (PDT) MIME-Version: 1.0 References: <20200916142806.GD7076@osiris> <20200922190350.7a0e0ca5@thinkpad> <20200923153938.5be5dd2c@thinkpad> <20200923233306.7c5666de@thinkpad> <20200924000226.06298978@thinkpad> <20200924140638.7bcb7765@thinkpad> In-Reply-To: <20200924140638.7bcb7765@thinkpad> From: Linus Torvalds Date: Thu, 24 Sep 2020 08:58:15 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: BUG: Bad page state in process dirtyc0w_child To: Gerald Schaefer , Alex Shi Cc: Peter Xu , Heiko Carstens , Qian Cai , Alexander Gordeev , Vasily Gorbik , Christian Borntraeger , linux-s390 , Linux-MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000026, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 24, 2020 at 5:06 AM Gerald Schaefer wrote: > > It's all good now, no more occurrences with unlock_page() before > wp_page_reuse(). Thanks for the confirmation. When you pointed at that unlock_page() change, I was pretty sure that was it ("D'oh!"), but it's always good to have that verification. Committed, Linus