From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B91CC2D0A8 for ; Sat, 26 Sep 2020 17:32:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 201CE21D82 for ; Sat, 26 Sep 2020 17:32:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601141557; bh=cygTXKkCsvZWqXI2SNNKP3tYNFmnXOeb3IGlkBfrBCk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=qt/217vWiCElGVMzQLewh8Wjjlr5zfykqaanIx924+CEuJweb93SkUlWvdkIrobkQ K+pJQ4tA6K51wvA1sUNhfsJX2SXHyEhg/KkyK8iQuxSh5gBbuaedxC6EoFxCGSIlWq S7mPumC+IIWCecR72cOjon5djGBP98L6X0paYaXI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729870AbgIZRcg (ORCPT ); Sat, 26 Sep 2020 13:32:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728017AbgIZRcg (ORCPT ); Sat, 26 Sep 2020 13:32:36 -0400 Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3342FC0613D3 for ; Sat, 26 Sep 2020 10:32:36 -0700 (PDT) Received: by mail-lf1-x144.google.com with SMTP id y17so6348339lfa.8 for ; Sat, 26 Sep 2020 10:32:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tWe98Z0+yeW9gkegitz9dCMR70Oh5RZVF1XD+EtjfBI=; b=YANRG3v8mFUdar8MnApQc7eZ0xpcy9rLqBogJxvFlVToZ9asxctFyxRLw7T7EgwW68 UWQDCWRz5Z0W51uhmXYLF32IgPz5NXZm9C8KyHb+TJeU/rVKewxu3RMuFrmOpx/2+cDV //gJ3pIIZv81LlPeoNW7dyyHoJGugzfK194yA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tWe98Z0+yeW9gkegitz9dCMR70Oh5RZVF1XD+EtjfBI=; b=j9GtCsFMOG5ZizEXBYsq3TV6f7PYOSCPDAS47CbqlffWo8uBIZq81gArXoJZtWNfvI 35lH1RYwaHPyrpsKBDAk60Qqq9zwOJoAZ1ffgc0+8ZKXBsRpZqf+4W1ym6oCV+2Uak2M D791BWYY/qRPbjwfWkZPdohupfC4zz7ZJAgoWc/s1/2auOlinfHU7WiqwTQJ5KffzTVs jH6VGzm2er/OO8ItrRmhO+QQ5AByepM8BMSPaz/9qzVk2Zjm8gv55En3MekSUtUrBs/4 NlhfajJRoOtKtdnUx/3FoCikWLskVt9CSJD/aXry5QSPkYsrITj/2mRKhg/br6puxEPd fptA== X-Gm-Message-State: AOAM5305Hv28/vMDqHvxWJjRpk0v8OsHWmeoCfdgq0H4Uq2NKYUFLCNu DkTv3imQ3Su6h+u130ZXP4Db6+ubumH4Ag== X-Google-Smtp-Source: ABdhPJwLL09Fzk7AoNkXUyYe8+7Gun81VxMQmBgZtP5Dyt9KyLHbEzQI5+7LJZv9KQWRQ571n/V1Uw== X-Received: by 2002:a19:3fd5:: with SMTP id m204mr1228466lfa.233.1601141553668; Sat, 26 Sep 2020 10:32:33 -0700 (PDT) Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com. [209.85.208.177]) by smtp.gmail.com with ESMTPSA id j20sm1941480lfe.181.2020.09.26.10.32.31 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 26 Sep 2020 10:32:32 -0700 (PDT) Received: by mail-lj1-f177.google.com with SMTP id a15so5050896ljk.2 for ; Sat, 26 Sep 2020 10:32:31 -0700 (PDT) X-Received: by 2002:a05:651c:514:: with SMTP id o20mr3140153ljp.312.1601141551598; Sat, 26 Sep 2020 10:32:31 -0700 (PDT) MIME-Version: 1.0 References: <20200925211725.0fea54be9e9715486efea21f@linux-foundation.org> <20200926041928.9xJHGgkah%akpm@linux-foundation.org> In-Reply-To: <20200926041928.9xJHGgkah%akpm@linux-foundation.org> From: Linus Torvalds Date: Sat, 26 Sep 2020 10:32:15 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch 8/9] mm: replace memmap_context by meminit_context To: Andrew Morton Cc: cheloha@linux.ibm.com, David Hildenbrand , Fenghua Yu , Greg Kroah-Hartman , ldufour@linux.ibm.com, Linux-MM , Michal Hocko , mm-commits@vger.kernel.org, nathanl@linux.ibm.com, Oscar Salvador , Rafael Wysocki , stable , Tony Luck Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org The explanations here do not make sense. On Fri, Sep 25, 2020 at 9:19 PM Andrew Morton wrote: > > > There are 2 issues here: > > a. The sysfs memory and node's layouts are broken due to these multiple > links > > b. The link errors in link_mem_sections() should not lead to a system > panic. > > To address a. register_mem_sect_under_node should not rely on the system > state to detect whether the link operation is triggered by a hot plug > operation or not. This is addressed by the patches 1 and 2 of this series. > > The patch 3 is addressing the point b. > > This patch (of 2): > > The memmap_context enum is used to detect whether a memory operation is due > to a hot-add operation or happening at boot time. > > Make it general to the hotplug operation and rename it as meminit_context. > > There is no functional change introduced by this patch So far so good. But there is no "patch 3" that addresses point (b) in this series. I see it on lore, but it's not part of what actually got sent to me, so the commit message for patch 1 now makes no sense any more. Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED312C4741F for ; Sat, 26 Sep 2020 17:32:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 43ED42311D for ; Sat, 26 Sep 2020 17:32:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="YANRG3v8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43ED42311D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 72AB46B005C; Sat, 26 Sep 2020 13:32:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6DBDB6B005D; Sat, 26 Sep 2020 13:32:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F1816B0068; Sat, 26 Sep 2020 13:32:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0052.hostedemail.com [216.40.44.52]) by kanga.kvack.org (Postfix) with ESMTP id 49CB86B005C for ; Sat, 26 Sep 2020 13:32:36 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 07BE44DBC for ; Sat, 26 Sep 2020 17:32:36 +0000 (UTC) X-FDA: 77305907112.04.test75_081505f27172 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id E0213800FFA7 for ; Sat, 26 Sep 2020 17:32:35 +0000 (UTC) X-HE-Tag: test75_081505f27172 X-Filterd-Recvd-Size: 4718 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Sat, 26 Sep 2020 17:32:35 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id c2so4988219ljj.12 for ; Sat, 26 Sep 2020 10:32:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tWe98Z0+yeW9gkegitz9dCMR70Oh5RZVF1XD+EtjfBI=; b=YANRG3v8mFUdar8MnApQc7eZ0xpcy9rLqBogJxvFlVToZ9asxctFyxRLw7T7EgwW68 UWQDCWRz5Z0W51uhmXYLF32IgPz5NXZm9C8KyHb+TJeU/rVKewxu3RMuFrmOpx/2+cDV //gJ3pIIZv81LlPeoNW7dyyHoJGugzfK194yA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tWe98Z0+yeW9gkegitz9dCMR70Oh5RZVF1XD+EtjfBI=; b=NE7jevTuK3uDaSV6NKeO+1KrMRx3J4sfirfNJwUaOqjTix1n90WMrsDBGqCehfZT8e KMWWZp1ZHV9YRVY7fgw1HLdxOGmir3G8gsitFtvmkDXg1WzcyrlTsNI6OfVxaDTlBNfO Albg+2Nko+nCgiv5kHwEcnwfnNdp2dTyrNoeldTwTrNxelZabRhsUbtWT7FPRz81bEVO PNiCdowi5CKIcl8Vj4esrQd4gzK7MUmp2ML9mz5j8rt9YBEzbFzTuH4Ji/dRHdv4XapC 6mSp7ZEGWQ80nnZkACxJfgS6H7mQKrIALY4HoQy97BtwNBNPYibWsa8RutV2mJwJ0jUE n+3w== X-Gm-Message-State: AOAM530g7SRgci6BGwKDco2urQrT3HQdjtzkS4CEoekvwqezvUS365L1 DQFytb1zQDHUv8voaz9lih3umJPAfyRu6A== X-Google-Smtp-Source: ABdhPJwt8Hpme9PexiQMR5yaI3aU+AK+v+KaFy8FNZCOdKRkyWuv4TRdPifkK9cTiR1TC0lzRUmIrw== X-Received: by 2002:a2e:8798:: with SMTP id n24mr2678285lji.373.1601141553411; Sat, 26 Sep 2020 10:32:33 -0700 (PDT) Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com. [209.85.208.172]) by smtp.gmail.com with ESMTPSA id v17sm1951775lfr.42.2020.09.26.10.32.31 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 26 Sep 2020 10:32:32 -0700 (PDT) Received: by mail-lj1-f172.google.com with SMTP id k25so5005845ljg.9 for ; Sat, 26 Sep 2020 10:32:31 -0700 (PDT) X-Received: by 2002:a05:651c:514:: with SMTP id o20mr3140153ljp.312.1601141551598; Sat, 26 Sep 2020 10:32:31 -0700 (PDT) MIME-Version: 1.0 References: <20200925211725.0fea54be9e9715486efea21f@linux-foundation.org> <20200926041928.9xJHGgkah%akpm@linux-foundation.org> In-Reply-To: <20200926041928.9xJHGgkah%akpm@linux-foundation.org> From: Linus Torvalds Date: Sat, 26 Sep 2020 10:32:15 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch 8/9] mm: replace memmap_context by meminit_context To: Andrew Morton Cc: cheloha@linux.ibm.com, David Hildenbrand , Fenghua Yu , Greg Kroah-Hartman , ldufour@linux.ibm.com, Linux-MM , Michal Hocko , mm-commits@vger.kernel.org, nathanl@linux.ibm.com, Oscar Salvador , Rafael Wysocki , stable , Tony Luck Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The explanations here do not make sense. On Fri, Sep 25, 2020 at 9:19 PM Andrew Morton wrote: > > > There are 2 issues here: > > a. The sysfs memory and node's layouts are broken due to these multiple > links > > b. The link errors in link_mem_sections() should not lead to a system > panic. > > To address a. register_mem_sect_under_node should not rely on the system > state to detect whether the link operation is triggered by a hot plug > operation or not. This is addressed by the patches 1 and 2 of this series. > > The patch 3 is addressing the point b. > > This patch (of 2): > > The memmap_context enum is used to detect whether a memory operation is due > to a hot-add operation or happening at boot time. > > Make it general to the hotplug operation and rename it as meminit_context. > > There is no functional change introduced by this patch So far so good. But there is no "patch 3" that addresses point (b) in this series. I see it on lore, but it's not part of what actually got sent to me, so the commit message for patch 1 now makes no sense any more. Linus