All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Stefan Roesch <shr@fb.com>
Cc: io-uring <io-uring@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH v5 3/5] fs: split off do_getxattr from getxattr
Date: Tue, 21 Dec 2021 11:18:07 -0800	[thread overview]
Message-ID: <CAHk-=wjqUaF=Vj9f44m7SNxhANwoTCnukm6+HqWnbhhr2KHRsg@mail.gmail.com> (raw)
In-Reply-To: <a30eda4f-ebf2-5e46-d980-cd9d46d83e60@fb.com>

On Tue, Dec 21, 2021 at 11:15 AM Stefan Roesch <shr@fb.com> wrote:
>
> Linus, if we remove the constness, then we either need to cast away the constness (the system call
> is defined as const) or change the definition of the system call.

You could also do it as

        union {
                const void __user *setxattr_value;
                void __user *getxattr_value;
        };

if you wanted to..

                 Linus

  reply	other threads:[~2021-12-21 19:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-21 16:49 [PATCH v5 0/5] io_uring: add xattr support Stefan Roesch
2021-12-21 16:49 ` [PATCH v5 1/5] fs: split off do_user_path_at_empty from user_path_at_empty() Stefan Roesch
2021-12-21 16:49 ` [PATCH v5 2/5] fs: split off setxattr_setup function from setxattr Stefan Roesch
2021-12-21 16:49 ` [PATCH v5 3/5] fs: split off do_getxattr from getxattr Stefan Roesch
2021-12-21 17:22   ` Linus Torvalds
2021-12-21 19:15     ` Stefan Roesch
2021-12-21 19:18       ` Linus Torvalds [this message]
2021-12-21 21:59         ` Stefan Roesch
2021-12-21 22:57           ` Jens Axboe
2021-12-21 16:49 ` [PATCH v5 4/5] io_uring: add fsetxattr and setxattr support Stefan Roesch
2021-12-21 16:49 ` [PATCH v5 5/5] io_uring: add fgetxattr and getxattr support Stefan Roesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wjqUaF=Vj9f44m7SNxhANwoTCnukm6+HqWnbhhr2KHRsg@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=io-uring@vger.kernel.org \
    --cc=kernel-team@fb.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=shr@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.