From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 245A1C54F70 for ; Sun, 19 Apr 2020 21:15:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F210222250 for ; Sun, 19 Apr 2020 21:15:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587330915; bh=gNi+2t29glCYXfwQMb2AMaTfLjp7upmTADCRahx+0+s=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=XHsAIO6IHQELOaE92NV7gGCTKhTWqdOovLe1E6TR4rJUM9PSIxIwf7H6NvKqob+MN gkwtJjXXLfLT9l4hGs+7SHEUyCk1ax+1LMxcxe1B62bGKXEMXpSPnL+Zdysg0eG5Cm 6HetZtL49ItEfE8vkGlap/DQIf2MGbXeSTF2p93c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726022AbgDSVPN (ORCPT ); Sun, 19 Apr 2020 17:15:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725891AbgDSVPN (ORCPT ); Sun, 19 Apr 2020 17:15:13 -0400 Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15835C061A0C for ; Sun, 19 Apr 2020 14:15:13 -0700 (PDT) Received: by mail-ej1-x644.google.com with SMTP id s3so6239467eji.6 for ; Sun, 19 Apr 2020 14:15:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8JGN7wLVHXwvgXkhYgDE5pBGoB6Yj1cQ4trKcrvGh/o=; b=Tad6GT9AGCZSv2/7xBX5bjyZ5esROH/JcXlUtWQU+uUcgJtcCdw3yPJzlj7dZb5K7F mEO0if045eF3URAWdqTUUsLbriq/4/p58gEuhzAa8o341ht0/ri3x0YCUzwX5hCMMQyu 7MJ5QPZiankwcVyg8JFPeMxhI9PZwurPZ4Jmo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8JGN7wLVHXwvgXkhYgDE5pBGoB6Yj1cQ4trKcrvGh/o=; b=tviZmurZS2GQOIF7WB/9kgmbC0QAkoS/zmK9tkx1S4iHPgYtzcUSUiBujNJO/vnyJ6 eZRDJYSGYGooZg2Ya/3qJCtiO6LxNPR4LapkVtR6iznq5JkNkLd+8cJLGqSNj4f3z0SA eBMaABlF1ScfhjAgNEt1WBliZI/I/Lwc1d72PU0ltUUy0pszukkcjX0KKdOWdGVMOZc6 iMrGI8hxnx7cEUYte3+HB4dGkSRysVVI1QxVIGZ5pes/4/FG4YDMZCOhLBHJ8LmvY8MJ Ri3s9BYhuPg/C6/gX9k9xiIsDrxgxpDj3dzKqjXXxMi0zi65JalQKGeV7gS2xbbQI+Mx v20w== X-Gm-Message-State: AGi0Pubs4DVOiASg33WOrqBxVbwHpjJXCHYvijKfBAQNEB4dRR0DANnH ZUNQp16YF1PFEElV+29JWHPB8wfZMvM= X-Google-Smtp-Source: APiQypKKsAv0YcR2D/o96nsvLMedOxEstDrZIycoAlEdwcWcGiVXE9SjNaV/iYHWN6ycpVzrmHsFAw== X-Received: by 2002:a17:906:2ccc:: with SMTP id r12mr13336628ejr.47.1587330911107; Sun, 19 Apr 2020 14:15:11 -0700 (PDT) Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com. [209.85.218.54]) by smtp.gmail.com with ESMTPSA id l5sm3016096ejr.45.2020.04.19.14.15.10 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Apr 2020 14:15:10 -0700 (PDT) Received: by mail-ej1-f54.google.com with SMTP id n17so6224157ejh.7 for ; Sun, 19 Apr 2020 14:15:10 -0700 (PDT) X-Received: by 2002:a05:6512:405:: with SMTP id u5mr8190138lfk.192.1587330558759; Sun, 19 Apr 2020 14:09:18 -0700 (PDT) MIME-Version: 1.0 References: <20200417172556.217480-1-bgeffon@google.com> In-Reply-To: From: Linus Torvalds Date: Sun, 19 Apr 2020 14:09:03 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] mm: Fix MREMAP_DONTUNMAP accounting on VMA merge To: Brian Geffon Cc: Andrew Morton , Andy Lutomirski , Sonny Rao , Jesse Barnes , Dmitry Vyukov , Minchan Kim , "Kirill A . Shutemov" , Vlastimil Babka , Linux Kernel Mailing List , Linux-MM , Linux API , syzbot Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 19, 2020 at 10:59 AM Linus Torvalds wrote: > > So I do have a query: would it perhaps not be a good idea to simply > remove the "vma_merge()" call from copy_vma(), and do at the end of > move_vma() instead? I decided to apply the patch regardless, even if somebody does end up deciding "yeah, let's move the vma_merge() down" later. Linus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7118C54F70 for ; Sun, 19 Apr 2020 21:09:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 79D3F21927 for ; Sun, 19 Apr 2020 21:09:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="Tad6GT9A" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 79D3F21927 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 22B378E0005; Sun, 19 Apr 2020 17:09:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D9FD8E0003; Sun, 19 Apr 2020 17:09:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A2AA8E0005; Sun, 19 Apr 2020 17:09:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0187.hostedemail.com [216.40.44.187]) by kanga.kvack.org (Postfix) with ESMTP id E429E8E0003 for ; Sun, 19 Apr 2020 17:09:22 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A457C181AEF39 for ; Sun, 19 Apr 2020 21:09:22 +0000 (UTC) X-FDA: 76725845364.01.grape69_51d4c28269120 X-HE-Tag: grape69_51d4c28269120 X-Filterd-Recvd-Size: 3995 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Sun, 19 Apr 2020 21:09:22 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id y4so7720137ljn.7 for ; Sun, 19 Apr 2020 14:09:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8JGN7wLVHXwvgXkhYgDE5pBGoB6Yj1cQ4trKcrvGh/o=; b=Tad6GT9AGCZSv2/7xBX5bjyZ5esROH/JcXlUtWQU+uUcgJtcCdw3yPJzlj7dZb5K7F mEO0if045eF3URAWdqTUUsLbriq/4/p58gEuhzAa8o341ht0/ri3x0YCUzwX5hCMMQyu 7MJ5QPZiankwcVyg8JFPeMxhI9PZwurPZ4Jmo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8JGN7wLVHXwvgXkhYgDE5pBGoB6Yj1cQ4trKcrvGh/o=; b=hOXvBpSQJ6fcxUWo33ZluVJyLFld1P8oGLWqmAGBz9MQoYA8oX6YJ8tjzUjcRWqxrQ +1M4TtS7hcD+uF/BqRaXl4O5UD/mUUI5DMKprPibudYtCHNdhOQRanjBwqDknqXhUOvN E8wx5HUdiQ8KKIOaSRMM/hx8hHTgY5UndCpDh3ce2OpRHrDy8tZBscO5bzkWRfUXkxWB 08K07LPu9KaVVpzc3XbM0FKsOJ3a6YXn4666Pso/j7GDoYWfgMeE9MHqCn4GtXkS4hOz 0djp9xW+XA/q8bD4ommVnd3AIGBnZDysgWDqr1ugA7l6LOmi0Rzr6xIHu9u5ctjxTnpL fLCw== X-Gm-Message-State: AGi0Pua6mxvQL+yQc0lA9Q4H882OqxomnTETBELPTlEBXW7S/RNgAWmt Wq6yUua9ChDVhKPbCNwPpXrnpwmdgUs= X-Google-Smtp-Source: APiQypK052MAaR3SHGkwaZgewLSLcKWdrKm0Ao7g6xAc/8M+BB4LWpUwreQlUo9Axids5BkT8byHnQ== X-Received: by 2002:a2e:6a08:: with SMTP id f8mr8562709ljc.8.1587330560254; Sun, 19 Apr 2020 14:09:20 -0700 (PDT) Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com. [209.85.167.44]) by smtp.gmail.com with ESMTPSA id b16sm23801886lfj.2.2020.04.19.14.09.19 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Apr 2020 14:09:19 -0700 (PDT) Received: by mail-lf1-f44.google.com with SMTP id m2so6203081lfo.6 for ; Sun, 19 Apr 2020 14:09:19 -0700 (PDT) X-Received: by 2002:a05:6512:405:: with SMTP id u5mr8190138lfk.192.1587330558759; Sun, 19 Apr 2020 14:09:18 -0700 (PDT) MIME-Version: 1.0 References: <20200417172556.217480-1-bgeffon@google.com> In-Reply-To: From: Linus Torvalds Date: Sun, 19 Apr 2020 14:09:03 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] mm: Fix MREMAP_DONTUNMAP accounting on VMA merge To: Brian Geffon Cc: Andrew Morton , Andy Lutomirski , Sonny Rao , Jesse Barnes , Dmitry Vyukov , Minchan Kim , "Kirill A . Shutemov" , Vlastimil Babka , Linux Kernel Mailing List , Linux-MM , Linux API , syzbot Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Apr 19, 2020 at 10:59 AM Linus Torvalds wrote: > > So I do have a query: would it perhaps not be a good idea to simply > remove the "vma_merge()" call from copy_vma(), and do at the end of > move_vma() instead? I decided to apply the patch regardless, even if somebody does end up deciding "yeah, let's move the vma_merge() down" later. Linus