All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Porcedda <fabio.porcedda@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/3] Makefile: target-finalize: add TARGET_FINALIZE_HOOKS
Date: Mon, 23 Jun 2014 11:14:03 +0200	[thread overview]
Message-ID: <CAHkwnC85aJyCdojijcmak=A+Z_TH9Vj_xdqsrXNmkiRj=HRD2Q@mail.gmail.com> (raw)
In-Reply-To: <53A4C196.3060800@mind.be>

On Sat, Jun 21, 2014 at 1:19 AM, Arnout Vandecappelle <arnout@mind.be> wrote:
> On 20/06/14 10:26, Fabio Porcedda wrote:
>> Add TARGET_FINALIZE_HOOKS to the "target-finalize" rule to be able to
>> add to it commands as needed.
>> This is useful for having a nicer output because commands are executed
>> after the "target-finalize" initial message, also it is useful to ensure
>> an executing order even when top-level parallel makefile is being used.
>
>  This commit message suggests that the patch would just add the call to the
> hooks, not actually changing the purge-locales implementation (which would be a
> separate patch).
>
>  For me, it doesn't have to a be a separate patch, but at least that additional
> change should be mentioned in the commit message.

Ok, i will add at the end:

Also convert "TARGET_PURGE_LOCALES" to a hook that use
"TARGET_FINALIZE_HOOKS".

Thanks && BR
-- 
Fabio Porcedda

  reply	other threads:[~2014-06-23  9:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-20  8:26 [Buildroot] [PATCH v2 0/3] Add TARGET_FINALIZE_HOOKS Fabio Porcedda
2014-06-20  8:26 ` [Buildroot] [PATCH v2 1/3] Makefile: target-finalize: add TARGET_FINALIZE_HOOKS Fabio Porcedda
2014-06-20 23:19   ` Arnout Vandecappelle
2014-06-23  9:14     ` Fabio Porcedda [this message]
2014-06-23  9:20       ` Arnout Vandecappelle
2014-06-23  9:22         ` Fabio Porcedda
2014-06-20  8:26 ` [Buildroot] [PATCH v2 2/3] system: convert "system.mk" recipes to "target-finalize" hooks Fabio Porcedda
2014-06-20 23:35   ` Arnout Vandecappelle
2014-06-23  9:20     ` Fabio Porcedda
2014-06-20  8:26 ` [Buildroot] [PATCH v2 3/3] Makefile: do not add to targets common dependencies Fabio Porcedda
2014-06-20 23:48   ` Arnout Vandecappelle
2014-06-23  9:51     ` Fabio Porcedda
2014-06-23 12:34       ` Arnout Vandecappelle
2014-06-25  7:51         ` Fabio Porcedda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHkwnC85aJyCdojijcmak=A+Z_TH9Vj_xdqsrXNmkiRj=HRD2Q@mail.gmail.com' \
    --to=fabio.porcedda@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.