From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751800AbbKPTds (ORCPT ); Mon, 16 Nov 2015 14:33:48 -0500 Received: from frisell.zx2c4.com ([192.95.5.64]:59607 "EHLO frisell.zx2c4.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750878AbbKPTdq (ORCPT ); Mon, 16 Nov 2015 14:33:46 -0500 MIME-Version: 1.0 In-Reply-To: <20151116.141737.420755936779587001.davem@davemloft.net> References: <1447342212-5543-1-git-send-email-Jason@zx2c4.com> <1447346158-19257-1-git-send-email-Jason@zx2c4.com> <20151116.141737.420755936779587001.davem@davemloft.net> Date: Mon, 16 Nov 2015 20:33:42 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] ip_tunnel: disable preemption when updating per-cpu tstats From: "Jason A. Donenfeld" To: David Miller Cc: Netdev , LKML , tgraf@suug.ch, Tom Herbert , Jiri Benc , Alexey Kuznetsov Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 16, 2015 at 8:17 PM, David Miller wrote: > So another fix could have been to do local_bh_disable() in the > udp_tunnel6_xmit_skb() helper. This would have fixed one problem, but everywhere udp_tunnel_xmit_skb() (4, not 6) is called, iptunnel_xmit_stats is called right after it, so there would have to be a modicum of patches for all of these places too. By the way, there's something else I noticed about this in dealing with these functions: the return value of udp_tunnel_xmit_skb is different from that of udp_tunnel6_xmit_skb. Nobody is using them incorrectly, so far as I can see, but it is confusing that they return different things. I had started to clean this up and send a patch, but it got a bit invasive in drivers I shouldn't really touch. But if somebody with a bit more top-down command of things wants to poke at this, it's a low hanging fruit as far as I can see. > > Thanks again. My pleasure.