From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEC07C4361B for ; Sat, 19 Dec 2020 00:02:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9CFC923BAC for ; Sat, 19 Dec 2020 00:02:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725868AbgLSACs (ORCPT ); Fri, 18 Dec 2020 19:02:48 -0500 Received: from mail.zx2c4.com ([192.95.5.64]:46447 "EHLO mail.zx2c4.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725855AbgLSACr (ORCPT ); Fri, 18 Dec 2020 19:02:47 -0500 Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 42770fd4 for ; Fri, 18 Dec 2020 23:54:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=zx2c4.com; h=mime-version :references:in-reply-to:from:date:message-id:subject:to:cc :content-type; s=mail; bh=bkR1yLEqiPk/LbWl/sSMnksv9a0=; b=jpLr2L kIftMAwsa4ysRZkzR86P+cI/8ft2WmRWTnJrciWQ4UUiD+C6HdTiOTmHpkNW+0zC uKUVATg9lCmj3ukEW+FchKkz3E5aZVCyqrENlc1ELrAMHkwvEu5HWzlBSPuu8PhG aGejV5KBa3kPeluzHaig5GDEBKz60sMyRz1hzWkqTNH2FbJ6aG8aWAE1IUPyZ7/T tBqkh1gE5ijbsprYlHDTflRU4E3mkuMAjinGU26ZJDGjbbCQ2GklrwC7Hq75Fo6z /sMQYDODbEa9OqgzLF0o4yKOsN7sWRdGT/Km+k1YeqtifosFHrDDe1EWbl/2Ms/a JK7wzG7YqWwcecgg== Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id e96acc76 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Fri, 18 Dec 2020 23:54:08 +0000 (UTC) Received: by mail-yb1-f176.google.com with SMTP id k78so3446272ybf.12 for ; Fri, 18 Dec 2020 16:02:04 -0800 (PST) X-Gm-Message-State: AOAM531Rmi6vR4kvneNZo24BwBLwXmKuiOmmv/hcMzmHafTeQXO8m+A/ F9za/OsTvkdW7g+QwdPGkDXFRCSb7dJ2RLFjfZM= X-Google-Smtp-Source: ABdhPJyjYDTMwTgN4YuZDlaxdwp/1OgBv2p5IAlEqli0PXqbVa6wr9sPYZKiXGIHKYvJyxrJpx+ICU10Xuuivwwof1E= X-Received: by 2002:a25:2cd6:: with SMTP id s205mr9316601ybs.279.1608336124079; Fri, 18 Dec 2020 16:02:04 -0800 (PST) MIME-Version: 1.0 References: <20201217222138.170526-1-ebiggers@kernel.org> <20201217222138.170526-10-ebiggers@kernel.org> In-Reply-To: From: "Jason A. Donenfeld" Date: Sat, 19 Dec 2020 01:01:53 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 09/11] crypto: blake2s - share the "shash" API boilerplate code To: Eric Biggers Cc: Linux Crypto Mailing List , linux-arm-kernel , Ard Biesheuvel , Herbert Xu , David Sterba , Paul Crowley Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Hey Eric, The solution you've proposed at the end of your email is actually kind of similar to what we do with curve25519. Check out include/crypto/curve25519.h. The critical difference between that and the blake proposal is that it's in the header for curve25519, so the indirection disappears. Could we do that with headers for blake? Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93403C4361B for ; Sat, 19 Dec 2020 00:03:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2629520780 for ; Sat, 19 Dec 2020 00:03:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2629520780 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=zx2c4.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+9azo3EhzwOFIsDyobRtjbiLTa1WTUaxtAwzUhXs7gc=; b=229ucQpocAjCH4vPdZaZAFSbC DDsNI+N6s/d+IPBRTp+4S45McaMOgwT8tni5oX2aHWVxsn8+oezwVhYrdReHMcANpaHliGMqXsR1L fKffR9iKGERYPlmj8eYHlk/7CglosxmA8pyxJlUtozXyNiDZxqDUbEfYGlpFVZgJeiZ2f+hF5VHoA qkAV2s9yEmeavIov4B8wU89aYDUs6vSZ+57rDaThWuDzUjNa5szyh51DW+VV2aoyRch1pa2rmcMNc 4VU/hpY087nZVVDKxXdKmzHCXA5FxycPkFWBYQhfVcp1C4VX6QZSsGFuOwZrcaaqO7ZrQOAJ6MWro eIoW17MUw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kqPhK-0002Ca-8T; Sat, 19 Dec 2020 00:02:10 +0000 Received: from mail.zx2c4.com ([192.95.5.64]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kqPhG-0002Bf-Uj for linux-arm-kernel@lists.infradead.org; Sat, 19 Dec 2020 00:02:07 +0000 Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTP id d8638b7f for ; Fri, 18 Dec 2020 23:54:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=zx2c4.com; h=mime-version :references:in-reply-to:from:date:message-id:subject:to:cc :content-type; s=mail; bh=bkR1yLEqiPk/LbWl/sSMnksv9a0=; b=jpLr2L kIftMAwsa4ysRZkzR86P+cI/8ft2WmRWTnJrciWQ4UUiD+C6HdTiOTmHpkNW+0zC uKUVATg9lCmj3ukEW+FchKkz3E5aZVCyqrENlc1ELrAMHkwvEu5HWzlBSPuu8PhG aGejV5KBa3kPeluzHaig5GDEBKz60sMyRz1hzWkqTNH2FbJ6aG8aWAE1IUPyZ7/T tBqkh1gE5ijbsprYlHDTflRU4E3mkuMAjinGU26ZJDGjbbCQ2GklrwC7Hq75Fo6z /sMQYDODbEa9OqgzLF0o4yKOsN7sWRdGT/Km+k1YeqtifosFHrDDe1EWbl/2Ms/a JK7wzG7YqWwcecgg== Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id cea474c1 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Fri, 18 Dec 2020 23:54:08 +0000 (UTC) Received: by mail-yb1-f178.google.com with SMTP id 82so3471657yby.6 for ; Fri, 18 Dec 2020 16:02:04 -0800 (PST) X-Gm-Message-State: AOAM532lreZKmAwco2dnQ6Qc5b0rJ+5dwpaVg/Jg/BN/cTuyyyTnI0IK cBsCYx3TKb8t7M02sJf43MTaSH2PQc7BkHbP2uM= X-Google-Smtp-Source: ABdhPJyjYDTMwTgN4YuZDlaxdwp/1OgBv2p5IAlEqli0PXqbVa6wr9sPYZKiXGIHKYvJyxrJpx+ICU10Xuuivwwof1E= X-Received: by 2002:a25:2cd6:: with SMTP id s205mr9316601ybs.279.1608336124079; Fri, 18 Dec 2020 16:02:04 -0800 (PST) MIME-Version: 1.0 References: <20201217222138.170526-1-ebiggers@kernel.org> <20201217222138.170526-10-ebiggers@kernel.org> In-Reply-To: From: "Jason A. Donenfeld" Date: Sat, 19 Dec 2020 01:01:53 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 09/11] crypto: blake2s - share the "shash" API boilerplate code To: Eric Biggers X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201218_190207_072917_77F35BBA X-CRM114-Status: UNSURE ( 8.97 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Herbert Xu , Linux Crypto Mailing List , David Sterba , Ard Biesheuvel , linux-arm-kernel , Paul Crowley Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hey Eric, The solution you've proposed at the end of your email is actually kind of similar to what we do with curve25519. Check out include/crypto/curve25519.h. The critical difference between that and the blake proposal is that it's in the header for curve25519, so the indirection disappears. Could we do that with headers for blake? Jason _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel