From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jason A. Donenfeld" Subject: Re: [PATCH net-next v4 00/20] WireGuard: Secure Network Tunnel Date: Fri, 14 Sep 2018 19:47:18 +0200 Message-ID: References: <20180914161954.7325-1-Jason@zx2c4.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: LKML , Netdev , Linux Crypto Mailing List , David Miller , Greg Kroah-Hartman To: Ard Biesheuvel Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On Fri, Sep 14, 2018 at 7:40 PM Ard Biesheuvel wrote: > > - Move away from makefile ifdef maze and instead prefer kconfig values, > > which also makes the design a bit more modular too, which could help > > in the future. > > Could you elaborate on this? From the patches, it is not clear to me > how this has improved. Feature detection was prior done as a confusing set of ifeq and ifdefs. Instead, I've now put the logic for this into the kconfig, which makes the makefiles and header files a bit simpler. This also makes it easier to later on modularize Zinc itself if deemed necessary.