From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from frisell.zx2c4.com ([192.95.5.64]:52291 "EHLO frisell.zx2c4.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726559AbeKTNf1 (ORCPT ); Tue, 20 Nov 2018 08:35:27 -0500 MIME-Version: 1.0 References: <20181105232526.173947-1-ebiggers@kernel.org> <20181105232526.173947-11-ebiggers@kernel.org> <20181112185816.GA8663@gmail.com> <20181116060227.hwu4igi6bp26ddpi@gondor.apana.org.au> <20181117001718.GA175522@gmail.com> <20181119052451.qttzfgcm4hvbdc4u@gondor.apana.org.au> <20181119225414.GB258711@gmail.com> <20181120030635.xfr543j5nngxfnxk@gondor.apana.org.au> In-Reply-To: <20181120030635.xfr543j5nngxfnxk@gondor.apana.org.au> From: "Jason A. Donenfeld" Date: Tue, 20 Nov 2018 04:08:19 +0100 Message-ID: Subject: Re: [RFC PATCH] zinc chacha20 generic implementation using crypto API code To: Herbert Xu Cc: Eric Biggers , Ard Biesheuvel , Linux Crypto Mailing List , linux-fscrypt@vger.kernel.org, linux-arm-kernel@lists.infradead.org, LKML , Paul Crowley , Greg Kaiser , Samuel Neves , Tomer Ashur Content-Type: text/plain; charset="UTF-8" Sender: linux-crypto-owner@vger.kernel.org List-ID: Hi Herbert, On Tue, Nov 20, 2018 at 4:06 AM Herbert Xu wrote: > > I'd still prefer to see the conversion patches included. Skipping them would be > > kicking the can down the road and avoiding issues that will need to be addressed > > anyway. Like you, I don't want a "half-baked concoction that will be maybe > > possibly be replaced 'later'" :-) > > Are you guys talking about the conversion patches to eliminate the > two copies of chacha code that would otherwise exist in crypto as > well as in zinc? > > If so I think that's not negotiable. Having two copies of the same > code is just not acceptable. Yes, that's the topic. Eric already expressed his preference to keep them, and I agreed, so the plan is to keep them. Jason From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason@zx2c4.com (Jason A. Donenfeld) Date: Tue, 20 Nov 2018 04:08:19 +0100 Subject: [RFC PATCH] zinc chacha20 generic implementation using crypto API code In-Reply-To: <20181120030635.xfr543j5nngxfnxk@gondor.apana.org.au> References: <20181105232526.173947-1-ebiggers@kernel.org> <20181105232526.173947-11-ebiggers@kernel.org> <20181112185816.GA8663@gmail.com> <20181116060227.hwu4igi6bp26ddpi@gondor.apana.org.au> <20181117001718.GA175522@gmail.com> <20181119052451.qttzfgcm4hvbdc4u@gondor.apana.org.au> <20181119225414.GB258711@gmail.com> <20181120030635.xfr543j5nngxfnxk@gondor.apana.org.au> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Herbert, On Tue, Nov 20, 2018 at 4:06 AM Herbert Xu wrote: > > I'd still prefer to see the conversion patches included. Skipping them would be > > kicking the can down the road and avoiding issues that will need to be addressed > > anyway. Like you, I don't want a "half-baked concoction that will be maybe > > possibly be replaced 'later'" :-) > > Are you guys talking about the conversion patches to eliminate the > two copies of chacha code that would otherwise exist in crypto as > well as in zinc? > > If so I think that's not negotiable. Having two copies of the same > code is just not acceptable. Yes, that's the topic. Eric already expressed his preference to keep them, and I agreed, so the plan is to keep them. Jason