All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Network Development <netdev@vger.kernel.org>,
	SinYu <liuxyon@gmail.com>, Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH net v3] net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending
Date: Fri, 19 Feb 2021 03:03:30 +0100	[thread overview]
Message-ID: <CAHmME9r11eViwmghiuQsBf9k04gnWvNg8k8UPG2W4OJU3-TMnA@mail.gmail.com> (raw)
In-Reply-To: <CAF=yD-K-8Gacsnch-1nTh11QFaXkfCj4TTj=Or6PF+6PyhbKiQ@mail.gmail.com>

On Thu, Feb 18, 2021 at 11:06 PM Willem de Bruijn
<willemdebruijn.kernel@gmail.com> wrote:
>
> On Thu, Feb 18, 2021 at 3:39 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote:
> >
> > The icmp{,v6}_send functions make all sorts of use of skb->cb, casting
>
> Again, if respinning, please briefly describe the specific buggy code
> path. I think it's informative and cannot be gleaned from the fix.

Ack.

> > -               send(skb, type, code, info, NULL);
> > +               send(skb, type, code, info, NULL, IP6CB(skb));
>
> This should be parm.

Nice catch, thanks.

v4 coming up.

  reply	other threads:[~2021-02-19  2:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-18 12:30 [PATCH net] net: icmp: zero-out cb in icmp{,v6}_ndo_send before sending Jason A. Donenfeld
2021-02-18 14:56 ` Willem de Bruijn
2021-02-18 15:40   ` Jason A. Donenfeld
2021-02-18 16:07     ` [PATCH net v2] net: icmp: pass zeroed opts from " Jason A. Donenfeld
2021-02-18 16:33       ` Willem de Bruijn
2021-02-18 17:35         ` Jason A. Donenfeld
2021-02-18 20:15           ` Willem de Bruijn
2021-02-18 20:24             ` Jason A. Donenfeld
2021-02-18 20:34               ` [PATCH net v3] " Jason A. Donenfeld
2021-02-18 22:06                 ` Willem de Bruijn
2021-02-19  2:03                   ` Jason A. Donenfeld [this message]
2021-02-18 20:36               ` [PATCH net v2] " Willem de Bruijn
2021-02-18 20:39                 ` Jason A. Donenfeld
2021-02-18 17:29     ` [PATCH net] net: icmp: zero-out cb in " Willem de Bruijn
2021-02-18 19:08 ` Jakub Kicinski
2021-02-18 19:24   ` Jason A. Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHmME9r11eViwmghiuQsBf9k04gnWvNg8k8UPG2W4OJU3-TMnA@mail.gmail.com \
    --to=jason@zx2c4.com \
    --cc=liuxyon@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=willemb@google.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.