From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Sergey Ivanov <seriv@cs.umd.edu>
Cc: WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: RHEL-8.1 backported a couple features breaking wireguard compilation.
Date: Sun, 8 Dec 2019 11:44:35 +0100 [thread overview]
Message-ID: <CAHmME9r4mgUzrqxJ7vEJZLqG7UVnQjAKrJSpDDF8h0hr7hnYBw@mail.gmail.com> (raw)
In-Reply-To: <dcf2a064-9800-8fcc-bd0c-3a604f8bd9bd@cs.umd.edu>
[-- Attachment #1.1: Type: text/plain, Size: 1711 bytes --]
Thanks. The rhel backporting policy has generally been to not support older
point releases once new ones exist. So we'll move to supporting rhel 8.1
and drop 8.0. If you submit a properly formatted git patch with a sign off
line, I can apply it.
On Sun, Dec 8, 2019, 11:41 Sergey Ivanov <seriv@cs.umd.edu> wrote:
> Hi,
>
> on kernel 4.18.0-147.el8.x86_64 I am not able to compile
> https://git.zx2c4.com/WireGuard sources, tried tags 0.0.20191127 and
> 0.0.20191205 and master at 5eb87fb649.
>
> To compile it I did the following workaround:
>
> ===
>
>
> $ git diff
> diff --git a/src/compat/compat.h b/src/compat/compat.h
> index ab22fa4..6e034b5 100644
> --- a/src/compat/compat.h
> +++ b/src/compat/compat.h
> @@ -326,7 +326,7 @@ static inline int wait_for_random_bytes(void)
> }
> #endif
>
> -#if LINUX_VERSION_CODE < KERNEL_VERSION(4, 19, 0) && LINUX_VERSION_CODE
> >= KERNEL_VERSION(4, 2, 0)
> +#if LINUX_VERSION_CODE < KERNEL_VERSION(4, 19, 0) && defined(ISRHEL8)
> && RHEL_MINOR < 1 && LINUX_VERSION_CODE >= KERNEL_VERSION(4, 2, 0)
> #include <linux/random.h>
> #include <linux/slab.h>
> struct rng_is_initialized_callback {
> @@ -831,7 +831,7 @@ static inline void skb_mark_not_on_list(struct
> sk_buff *skb)
> }
> #endif
>
> -#if LINUX_VERSION_CODE < KERNEL_VERSION(4, 20, 0)
> +#if LINUX_VERSION_CODE < KERNEL_VERSION(4, 20, 0) && (!defined(ISRHEL8)
> || RHEL_MINOR < 1)
> #define NLA_EXACT_LEN NLA_UNSPEC
> #endif
> #if LINUX_VERSION_CODE < KERNEL_VERSION(5, 2, 0)
> ===
>
> --
>
> Regards,
>
> Sergey Ivanov
>
> _______________________________________________
> WireGuard mailing list
> WireGuard@lists.zx2c4.com
> https://lists.zx2c4.com/mailman/listinfo/wireguard
>
[-- Attachment #1.2: Type: text/html, Size: 2539 bytes --]
[-- Attachment #2: Type: text/plain, Size: 148 bytes --]
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard
next prev parent reply other threads:[~2019-12-08 10:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 17:21 RHEL-8.1 compile problem Sergey Ivanov
2019-12-05 12:55 ` RHEL-8.1 backported a couple features breaking wireguard compilation Sergey Ivanov
2019-12-08 10:44 ` Jason A. Donenfeld [this message]
2019-12-09 19:53 ` [PATCH 1/1] Support building for RHEL-8.1 instead of RHEL-8.0 Sergey Ivanov
2019-12-09 21:54 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHmME9r4mgUzrqxJ7vEJZLqG7UVnQjAKrJSpDDF8h0hr7hnYBw@mail.gmail.com \
--to=jason@zx2c4.com \
--cc=seriv@cs.umd.edu \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.