All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jussi Maki <joamaki@gmail.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: syzbot <syzbot+30622fb04ddd72a4d167@syzkaller.appspotmail.com>,
	ardb@kernel.org, jbaron@akamai.com, linux-kernel@vger.kernel.org,
	peterz@infradead.org, rostedt@goodmis.org,
	syzkaller-bugs@googlegroups.com,
	Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: [syzbot] WARNING in __static_key_slow_dec
Date: Sun, 5 Sep 2021 12:08:05 +0200	[thread overview]
Message-ID: <CAHn8xcnF5FT+i5jwsZGswyYt9Q9Amnj8N07wK08Fe_doGsBBaA@mail.gmail.com> (raw)
In-Reply-To: <20210904042010.5henc6pn5zotdq6v@treble>

On Sat, Sep 4, 2021 at 6:20 AM Josh Poimboeuf <jpoimboe@redhat.com> wrote:
>
> Looks like a jump label usage bug ("jump label: negative count!") may
> have been introduced, presumably with the following commit:
>
>   9e2ee5c7e7c3 ("net, bonding: Add XDP support to the bonding driver")
>
> Jussi, any idea?

Hey, thanks for looping me in.

The code in bond_xdp_set is unsafely assuming that it won't get called
multiple times with prog=NULL and that's likely the issue here. The
assumption seems to mostly hold as I haven't been able to reproduce
this locally yet, even with nested bonding or with non-XDP slaves in
the mix. I'll look into this more next week and try to decipher what
steps syzbot is doing. As soon as I have a repro + fix I'll send it to
the net tree.

      reply	other threads:[~2021-09-05 10:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-03 20:28 [syzbot] WARNING in __static_key_slow_dec syzbot
2021-09-04  4:20 ` Josh Poimboeuf
2021-09-05 10:08   ` Jussi Maki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHn8xcnF5FT+i5jwsZGswyYt9Q9Amnj8N07wK08Fe_doGsBBaA@mail.gmail.com \
    --to=joamaki@gmail.com \
    --cc=ardb@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=jbaron@akamai.com \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=syzbot+30622fb04ddd72a4d167@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.