From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3F5FC433E0 for ; Mon, 8 Mar 2021 14:58:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 79142650CB for ; Mon, 8 Mar 2021 14:58:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231246AbhCHO6T (ORCPT ); Mon, 8 Mar 2021 09:58:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231295AbhCHO5w (ORCPT ); Mon, 8 Mar 2021 09:57:52 -0500 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF05EC06174A; Mon, 8 Mar 2021 06:57:51 -0800 (PST) Received: by mail-pj1-x1030.google.com with SMTP id ga23-20020a17090b0397b02900c0b81bbcd4so3118845pjb.0; Mon, 08 Mar 2021 06:57:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1v0ao3b2/Ux4Trc+2qyo6Snq2zmvaCA06fjB7BxQBtk=; b=UN2m03gJoZakMr0gOlQjQr5POq2Jz4sA0ztlFhKdsp4HXOGelbToq5jKRqnI3v7zjc TVRSriUUvtKcFRhvvKGNdcmkwyI/o3i5ZzMytKZaF1m7DznLjrZ8iJCqLWYmgJnjuV3L mTQArkXhtOCZxDqQEGN7AxVsZTZL4ah2L8Uh9Cp1OrQQgVe2fpmMYPzG0w/sfLvv96yO 56x52+9LalsUGPXMQ9bwE7fM/f7ybD/qobWl3ryinOVUrWnrQnoaHThwxojB8VgJ0h2D BdFrVGbwBMi/tCtYP27qFCuVTn6pG64SMtEwJEcOSie7MTdvPvfR5V5OmFVncRm1i4R9 xB0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1v0ao3b2/Ux4Trc+2qyo6Snq2zmvaCA06fjB7BxQBtk=; b=dVva7WWv86XP5l8ZxqUZbzAghRfrGXm7Z2QYpQ+SQjUE7P3l+tS2h2Za6Bqc5Bzstn V5bXhnTul7Y6duQuFjj0d7uV+raZVB4H89pqgmD8lz3d6bIlwsawmDdjNqkFoqLDmZ4C XBm7XP7xnPrV3GijBNmMhwkuJ2Bzx3vE+T/24JpgL4efZgLh4eiHMSsFN6EmArO9IiKu MfbKZ/XFrywC98xJmcAA330ATCpGILuOGKgwCbmzMNCB40lvxXfy3ayqAH3kLajEV3gq 9TXO89rIBvUR01Kq+BK+8KBKk6tGZS3WNn0GHpHgPMhkbkVQfd3K+1jfG3V7x34Q43lf 9YxA== X-Gm-Message-State: AOAM530GSInHEGhMA+wZ7MYoYderLV5/8vFLUVxpGJ4tPvDKSmginjPh 0aC47mlhFdtxIPmFSOH/fUU37LMGHrmyxLIkOVs= X-Google-Smtp-Source: ABdhPJwWLAcn/zCc7JnKH0rPVVA2UFQqpno+iYzLW3XAAZ6juSRPbxlixiAKwoAOG82N4Y3z+Z9QJAbVtiVxxrJMbRk= X-Received: by 2002:a17:902:70c7:b029:e3:71cf:33d2 with SMTP id l7-20020a17090270c7b02900e371cf33d2mr21445892plt.21.1615215471340; Mon, 08 Mar 2021 06:57:51 -0800 (PST) MIME-Version: 1.0 References: <20210218052654.28995-1-calvin.johnson@oss.nxp.com> <20210218052654.28995-11-calvin.johnson@oss.nxp.com> <20210308140936.GA2740@lsv03152.swis.in-blr01.nxp.com> In-Reply-To: <20210308140936.GA2740@lsv03152.swis.in-blr01.nxp.com> From: Andy Shevchenko Date: Mon, 8 Mar 2021 16:57:35 +0200 Message-ID: Subject: Re: [net-next PATCH v6 10/15] net: mdio: Add ACPI support code for mdio To: Calvin Johnson Cc: Grant Likely , "Rafael J . Wysocki" , Jeremy Linton , Andrew Lunn , Florian Fainelli , Russell King - ARM Linux admin , Cristi Sovaiala , Florin Laurentiu Chiculita , Ioana Ciornei , Madalin Bucur , Heikki Krogerus , Marcin Wojtas , Pieter Jansen Van Vuuren , Jon , Saravana Kannan , Randy Dunlap , Linux Kernel Mailing List , netdev , ACPI Devel Maling List , Laurentiu Tudor , Diana Madalina Craciun , linux-arm Mailing List , "linux.cj" , "David S. Miller" , Heiner Kallweit , Jakub Kicinski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Mar 8, 2021 at 4:11 PM Calvin Johnson wrote: > On Thu, Feb 18, 2021 at 05:08:05PM +0200, Andy Shevchenko wrote: > > On Thu, Feb 18, 2021 at 7:28 AM Calvin Johnson > > wrote: > > > Define acpi_mdiobus_register() to Register mii_bus and create PHYs for > > > each ACPI child node. > > > > > +#include > > > +#include > > > > Perhaps it's better to provide the headers that this file is direct > > user of, i.e. > > bits.h > > dev_printk.h > > Looks like device.h needs to be used instead of dev_printk.h. Please > let me know if you've a different opinion. I don't see the user of device.h. dev_printk.h is definitely in use here... Do you see a user for device.h? Which line in your code requires it? It might be that I don't see something quite obvious... > > module.h > > types.h > > > > The rest seems fine because they are guaranteed to be included by > > acpi.h (IIUC about fwnode API and acpi_mdio includes MDIO PHY APIs). -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F53AC433DB for ; Mon, 8 Mar 2021 14:59:31 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C066D650CB for ; Mon, 8 Mar 2021 14:59:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C066D650CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lI3PcWqfIU1pZ1P+0EzU0ne63xXjjG7RFl3YGNpiNpo=; b=DuVofJ2qAGnoVVXdl/jP7wU3e hKMgr5qMdNKCw3GtcZFOM+nCOXI11BzEN35l6BOOHdS5DMEhI8z+Xyew7IiLlp9eW+1hfbcUxxsVS jh+QBHhho8c53qCUMdOgFKUe4fX7yCt9aPAkWyNfh+GQ3JPpjf1eI7PWLGkNdHr3CnY7W1vO2NbCf a4UYJRlR0vKaJDx3ckyCiaZz/T3SCfd8lnl6ifzGfbJh9AVK9dEgokE09FZ6mNELKhnb9jIxT+WGN 8ADt00ZoZf5FyNNAIYKKQ1upBTlTwiOxEwC6UnTBy7TxVUHZWOhkbKG393Pj0m0HB9d8X7u4kYOUH eX3BXmhLw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJHKa-000Ngx-5c; Mon, 08 Mar 2021 14:58:01 +0000 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lJHKT-000NfF-6u for linux-arm-kernel@lists.infradead.org; Mon, 08 Mar 2021 14:57:55 +0000 Received: by mail-pj1-x102a.google.com with SMTP id ga23-20020a17090b0397b02900c0b81bbcd4so3118848pjb.0 for ; Mon, 08 Mar 2021 06:57:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1v0ao3b2/Ux4Trc+2qyo6Snq2zmvaCA06fjB7BxQBtk=; b=UN2m03gJoZakMr0gOlQjQr5POq2Jz4sA0ztlFhKdsp4HXOGelbToq5jKRqnI3v7zjc TVRSriUUvtKcFRhvvKGNdcmkwyI/o3i5ZzMytKZaF1m7DznLjrZ8iJCqLWYmgJnjuV3L mTQArkXhtOCZxDqQEGN7AxVsZTZL4ah2L8Uh9Cp1OrQQgVe2fpmMYPzG0w/sfLvv96yO 56x52+9LalsUGPXMQ9bwE7fM/f7ybD/qobWl3ryinOVUrWnrQnoaHThwxojB8VgJ0h2D BdFrVGbwBMi/tCtYP27qFCuVTn6pG64SMtEwJEcOSie7MTdvPvfR5V5OmFVncRm1i4R9 xB0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1v0ao3b2/Ux4Trc+2qyo6Snq2zmvaCA06fjB7BxQBtk=; b=aL3ITEgx7YBTJQznO3iOg4ITGcWgib68Qd4i87tWpKgrDfPNEVCcgweIdKEy5TRx77 sDVUMwcy+LIrbMvAiXAcTG0R7AS8TdBFT/HLFSWIPbC2mtHc7ZS0tJmOFaG2EiNZ2l72 h/XmyQITOxpbeUCNOxNYKZ7OYZWQrrwc4uva9+CFyz66qAeSfWuyE4ySgpi2IfMwngAv efjKPX3wzrqbIBWRy4EJhDBHsv30VMNcJ5kuCzGnDOEo/pDoHr9A9suCXIxH+e5ptCYp rye8wIHsfuLujxarYVHXJOBehqZuOealEVYFst8Kobc4OhHTCtSSCGRFTSwTanE+srl3 wg/A== X-Gm-Message-State: AOAM533x3dPSl7XtAPcWdJHXDaccdx4CjTycjaEOsh+IBxLUqCfTayHi tGhOkBLOo+w3XlFHJuRv/0oydtKDwyATnLGFbucV+1lPsbVCMcqX X-Google-Smtp-Source: ABdhPJwWLAcn/zCc7JnKH0rPVVA2UFQqpno+iYzLW3XAAZ6juSRPbxlixiAKwoAOG82N4Y3z+Z9QJAbVtiVxxrJMbRk= X-Received: by 2002:a17:902:70c7:b029:e3:71cf:33d2 with SMTP id l7-20020a17090270c7b02900e371cf33d2mr21445892plt.21.1615215471340; Mon, 08 Mar 2021 06:57:51 -0800 (PST) MIME-Version: 1.0 References: <20210218052654.28995-1-calvin.johnson@oss.nxp.com> <20210218052654.28995-11-calvin.johnson@oss.nxp.com> <20210308140936.GA2740@lsv03152.swis.in-blr01.nxp.com> In-Reply-To: <20210308140936.GA2740@lsv03152.swis.in-blr01.nxp.com> From: Andy Shevchenko Date: Mon, 8 Mar 2021 16:57:35 +0200 Message-ID: Subject: Re: [net-next PATCH v6 10/15] net: mdio: Add ACPI support code for mdio To: Calvin Johnson Cc: Grant Likely , "Rafael J . Wysocki" , Jeremy Linton , Andrew Lunn , Florian Fainelli , Russell King - ARM Linux admin , Cristi Sovaiala , Florin Laurentiu Chiculita , Ioana Ciornei , Madalin Bucur , Heikki Krogerus , Marcin Wojtas , Pieter Jansen Van Vuuren , Jon , Saravana Kannan , Randy Dunlap , Linux Kernel Mailing List , netdev , ACPI Devel Maling List , Laurentiu Tudor , Diana Madalina Craciun , linux-arm Mailing List , "linux.cj" , "David S. Miller" , Heiner Kallweit , Jakub Kicinski X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210308_145753_488372_74CDE9D6 X-CRM114-Status: GOOD ( 18.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 8, 2021 at 4:11 PM Calvin Johnson wrote: > On Thu, Feb 18, 2021 at 05:08:05PM +0200, Andy Shevchenko wrote: > > On Thu, Feb 18, 2021 at 7:28 AM Calvin Johnson > > wrote: > > > Define acpi_mdiobus_register() to Register mii_bus and create PHYs for > > > each ACPI child node. > > > > > +#include > > > +#include > > > > Perhaps it's better to provide the headers that this file is direct > > user of, i.e. > > bits.h > > dev_printk.h > > Looks like device.h needs to be used instead of dev_printk.h. Please > let me know if you've a different opinion. I don't see the user of device.h. dev_printk.h is definitely in use here... Do you see a user for device.h? Which line in your code requires it? It might be that I don't see something quite obvious... > > module.h > > types.h > > > > The rest seems fine because they are guaranteed to be included by > > acpi.h (IIUC about fwnode API and acpi_mdio includes MDIO PHY APIs). -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel