From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F7BBC433EF for ; Fri, 15 Jul 2022 18:14:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229497AbiGOSO3 (ORCPT ); Fri, 15 Jul 2022 14:14:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbiGOSO3 (ORCPT ); Fri, 15 Jul 2022 14:14:29 -0400 Received: from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com [IPv6:2607:f8b0:4864:20::112f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8786015FD9; Fri, 15 Jul 2022 11:14:27 -0700 (PDT) Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-31bf3656517so54333307b3.12; Fri, 15 Jul 2022 11:14:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wYQx40/iCC7JCsgHdkd0E1jOgqV54xGVWGfgqFpzTxo=; b=CCNqrZ6xxLNILlnpWQJZURCM7WccDYI4HArJBKyxVZQ4tUE7wHsb8C+1xQrCcy/ctP hgNxqF3L/l+JVN/sIioIK7hlY2E24EgjBaYcjObgBZ96Go1MFnvrauI9olx68o+tAec5 0zqXIns8v8XdElhZwR+ilBWSFm2BAz09sy+iAz5QQOYZmnuuIUuyYZ7ilSKeAOMj7Dr0 nmKdVBdXufKKDMVxiWrXIc+cIpZBo8ghQfSQgHJj69Av/M38jJkwWwu38WYhZktwk2Sr Ktcv4iMX1VtKF6apNGtKuW2hT3Gz86OVl/1giJmpSuReSlovrn8AP0YP6RZk9atjVy9y /pvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wYQx40/iCC7JCsgHdkd0E1jOgqV54xGVWGfgqFpzTxo=; b=F1Rb0F4hJTU3z+RjtUcnUk40dINLOEJWsSkUJXA19zkvWio+EVFRGGZI3TZN9Jsdor ikHvlAI8RfNLkl6B+9LXP2LwEHF5pr3aEg6bTqDJQL3dw25xiXFDcxENbovKZxZpP9Me xJQqt9rCvQXLMtdk7s2mByd4+g9tglCxLp26Z/evry+1ygE8upN5PDhuGlYo3Ilm+yV5 ddRdRN9SNRTJxX6sefLpjqplGeirGYTyK2eVs6x+4XEUYSbyN+EwwtLuEORFiJPFD5jD WamwcsOyWXoUBf9l23BWRjFx67ikGRmfHHoVy0y4YK/24x32ZZJeLVRxytkeDPCwI9dX F07A== X-Gm-Message-State: AJIora+cA9Ick5GK3oJPozXOmfTohLm1/p2y2Rch9m3FQCOwpJtKa7H9 IXceeMgrt1X5ZX5XuFvKeZeE1MebIhmgsHZvXwjOCc4HxYo= X-Google-Smtp-Source: AGRyM1uDhQ/IPsk1j9mwzTNaBs0PF9Af75W/5SyN9tcIUEjc7IVgAe4YsQYGo3tn1MHf1/3mBdT0R30hiBZKjAGSBRA= X-Received: by 2002:a81:4bd7:0:b0:31c:91da:5a20 with SMTP id y206-20020a814bd7000000b0031c91da5a20mr18833575ywa.131.1657908866682; Fri, 15 Jul 2022 11:14:26 -0700 (PDT) MIME-Version: 1.0 References: <20220715112607.591-1-peterwu.pub@gmail.com> <20220715112607.591-13-peterwu.pub@gmail.com> In-Reply-To: <20220715112607.591-13-peterwu.pub@gmail.com> From: Andy Shevchenko Date: Fri, 15 Jul 2022 20:13:49 +0200 Message-ID: Subject: Re: [PATCH v5 12/13] leds: flashlight: mt6370: Add MediaTek MT6370 flashlight support To: ChiaEn Wu Cc: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sebastian Reichel , Chunfeng Yun , Greg Kroah-Hartman , Jonathan Cameron , Lars-Peter Clausen , Liam Girdwood , Mark Brown , Guenter Roeck , "Krogerus, Heikki" , Helge Deller , ChiaEn Wu , Alice Chen , cy_huang , dri-devel , Linux LED Subsystem , devicetree , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Linux PM , USB , linux-iio , "open list:FRAMEBUFFER LAYER" , szuni chen Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Fri, Jul 15, 2022 at 1:29 PM ChiaEn Wu wrote: > The MediaTek MT6370 is a highly-integrated smart power management IC, > whichincludes a single cell Li-Ion/Li-Polymer switching battery which includes > charger, a USB Type-C & Power Delivery (PD) controller, dual Flash > LED current sources, a RGB LED driver, a backlight WLED driver, > a display bias driver and a general LDO for portable devices. > > The Flash LED in MT6370 has 2 channel and support torch/strobe mode. channels > The commit add the support of MT6370 FLASH LED. Add the ... > +#define MT6370_FLCSEN_MASK_ALL (BIT(0) | BIT(1)) GENMASK() ... > + for (i = 0; i < MT6370_MAX_LEDS; i++) { > + ret = regmap_update_bits(priv->regmap, > + MT6370_REG_FLEDISTRB(i), > + MT6370_ISTROBE_MASK, flevel[i]); > + if (ret) > + return ret; > + } > + } else { > + ret = regmap_update_bits(priv->regmap, > + MT6370_REG_FLEDISTRB(led->led_no), > + MT6370_ISTROBE_MASK, val); > + } > + return ret; return regmap_update_bits(...); } return 0; ... > + /* > + * If the flash need to be on, needs > + * config the flash current ramping up to the setting value. > + * Else, always recover back to the minimum one. > + */ ... > + /* For the flash turn on/off, need to wait HW ramping up/down time to turn > + * 5ms/500us to prevent the unexpected problem. > + */ Wrong multi-line comment style. > + No need for a blank line. > + if (!prev && curr) > + usleep_range(5000, 6000); > + else if (prev && !curr) > + udelay(500); ... > +static int mt6370_led_register(struct device *parent, struct mt6370_led *led, > + struct led_init_data *init_data) > +{ > + struct v4l2_flash_config v4l2_config = {0}; > + int ret; > + > + ret = devm_led_classdev_flash_register_ext(parent, &led->flash, > + init_data); > + if (ret) { > + dev_err(parent, "Couldn't register flash %d\n", led->led_no); > + return ret; return dev_err_probe() here and everywhere where it is about probe stage. > + } > + > + mt6370_init_v4l2_flash_config(led, &v4l2_config); > + led->v4l2_flash = v4l2_flash_init(parent, init_data->fwnode, > + &led->flash, &v4l2_flash_ops, > + &v4l2_config); > + if (IS_ERR(led->v4l2_flash)) { > + dev_err(parent, "Failed to register %d v4l2 sd\n", led->led_no); > + return PTR_ERR(led->v4l2_flash); > + } > + > + return 0; > +} ... > + num = fwnode_property_count_u32(init_data->fwnode, "led-sources"); > + if (num < 1 || num > MT6370_MAX_LEDS) { > + dev_err(priv->dev, > + "Not specified or wrong number of led-sources\n"); > + return -EINVAL; Ditto. > + } ... > + ret = fwnode_property_read_u32(init_data->fwnode, "led-max-microamp", > + &val); One line? ... > + val = clamp_align(val, MT6370_STRBTO_MIN_US, MT6370_STRBTO_MAX_US, > + MT6370_STRBTO_STEP_US); I would name it mt6370_clamp() to avoid potential collision in the global namespace in the future. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E424C433EF for ; Fri, 15 Jul 2022 18:15:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RTvmjKs6J9J7x/gpdFgTPoDjZufxsTbhfG3dhE9PTW4=; b=DhzUSL7yBXhnB5 KzLvInG92Pkwi87XT14plEB8NqwrTat/YNXCz8HMjp4jIW5Bn0mb/9rWzdbtjKdQwYLkaTcR0k8q2 bTWB5EcODYn3uKDJq6MoCivZDwClOpUAnlIJKNdA0DzI+ioDV+AccYYiOgbTGxfA/pv5w7y/Q6lN7 UVCn3eNRzdsk9b6OdrHIGJQ72dCPDF8GFcyVgf6o0JYzR8+NXgCP842MOu3/DKW+6CVcTmdD/sJJu ENy0cFFLinyC0TTNJ3j1tS5+tb2snJ2cZHWpYdDw8np6dVmM5N0eTdYYlxjX7yhYUkr0fHdGY0uei a47v4RWnQNWR0nGokPNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCPpg-009Nxu-GT; Fri, 15 Jul 2022 18:14:32 +0000 Received: from mail-yw1-x1135.google.com ([2607:f8b0:4864:20::1135]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCPpd-009NtN-7K; Fri, 15 Jul 2022 18:14:30 +0000 Received: by mail-yw1-x1135.google.com with SMTP id 00721157ae682-2ef5380669cso54466267b3.9; Fri, 15 Jul 2022 11:14:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wYQx40/iCC7JCsgHdkd0E1jOgqV54xGVWGfgqFpzTxo=; b=CCNqrZ6xxLNILlnpWQJZURCM7WccDYI4HArJBKyxVZQ4tUE7wHsb8C+1xQrCcy/ctP hgNxqF3L/l+JVN/sIioIK7hlY2E24EgjBaYcjObgBZ96Go1MFnvrauI9olx68o+tAec5 0zqXIns8v8XdElhZwR+ilBWSFm2BAz09sy+iAz5QQOYZmnuuIUuyYZ7ilSKeAOMj7Dr0 nmKdVBdXufKKDMVxiWrXIc+cIpZBo8ghQfSQgHJj69Av/M38jJkwWwu38WYhZktwk2Sr Ktcv4iMX1VtKF6apNGtKuW2hT3Gz86OVl/1giJmpSuReSlovrn8AP0YP6RZk9atjVy9y /pvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wYQx40/iCC7JCsgHdkd0E1jOgqV54xGVWGfgqFpzTxo=; b=iWmtVgSwsEYADSIJlxSQUfqVpAAlsJWPpLkRNrOoTbQckOmN7NqOjPlYipBimjoZdi WCZRFXjgiGDzaifGtFS71b1EMAzk4kbxa5Cgv+B7lDan+DEvUcS0dH+9JDJdbEe5ucm/ DVQRyt1YV7FrZE+PlYmYCbg5pL8PzErA+nEI14ifkEhGjp/T1legdEVxGJZ0Wt7Sh5N4 UtPwZddzlZ9UacFs1wYNNxsLqLw0ypohhl4NcZdthD8bRmLF4zbV0NI+TasNMf9F6Cju 8oE/ozylvMy80ZDrGYWITuL6BJ+E4QyUJliBiYs0Tn3Fp5Fi9ItycvaLOm51cAkNibyS YxBg== X-Gm-Message-State: AJIora8WNhx2mJSoInjLlBLy27dH6nRP2zFGlHulgUWBo2KlLERm3ApA 1WyOaanMPXH9A2pxoJGoiYb9gwaoHiIvvoZl17g= X-Google-Smtp-Source: AGRyM1uDhQ/IPsk1j9mwzTNaBs0PF9Af75W/5SyN9tcIUEjc7IVgAe4YsQYGo3tn1MHf1/3mBdT0R30hiBZKjAGSBRA= X-Received: by 2002:a81:4bd7:0:b0:31c:91da:5a20 with SMTP id y206-20020a814bd7000000b0031c91da5a20mr18833575ywa.131.1657908866682; Fri, 15 Jul 2022 11:14:26 -0700 (PDT) MIME-Version: 1.0 References: <20220715112607.591-1-peterwu.pub@gmail.com> <20220715112607.591-13-peterwu.pub@gmail.com> In-Reply-To: <20220715112607.591-13-peterwu.pub@gmail.com> From: Andy Shevchenko Date: Fri, 15 Jul 2022 20:13:49 +0200 Message-ID: Subject: Re: [PATCH v5 12/13] leds: flashlight: mt6370: Add MediaTek MT6370 flashlight support To: ChiaEn Wu Cc: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sebastian Reichel , Chunfeng Yun , Greg Kroah-Hartman , Jonathan Cameron , Lars-Peter Clausen , Liam Girdwood , Mark Brown , Guenter Roeck , "Krogerus, Heikki" , Helge Deller , ChiaEn Wu , Alice Chen , cy_huang , dri-devel , Linux LED Subsystem , devicetree , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Linux PM , USB , linux-iio , "open list:FRAMEBUFFER LAYER" , szuni chen X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220715_111429_291325_7E8BD39F X-CRM114-Status: GOOD ( 22.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 15, 2022 at 1:29 PM ChiaEn Wu wrote: > The MediaTek MT6370 is a highly-integrated smart power management IC, > whichincludes a single cell Li-Ion/Li-Polymer switching battery which includes > charger, a USB Type-C & Power Delivery (PD) controller, dual Flash > LED current sources, a RGB LED driver, a backlight WLED driver, > a display bias driver and a general LDO for portable devices. > > The Flash LED in MT6370 has 2 channel and support torch/strobe mode. channels > The commit add the support of MT6370 FLASH LED. Add the ... > +#define MT6370_FLCSEN_MASK_ALL (BIT(0) | BIT(1)) GENMASK() ... > + for (i = 0; i < MT6370_MAX_LEDS; i++) { > + ret = regmap_update_bits(priv->regmap, > + MT6370_REG_FLEDISTRB(i), > + MT6370_ISTROBE_MASK, flevel[i]); > + if (ret) > + return ret; > + } > + } else { > + ret = regmap_update_bits(priv->regmap, > + MT6370_REG_FLEDISTRB(led->led_no), > + MT6370_ISTROBE_MASK, val); > + } > + return ret; return regmap_update_bits(...); } return 0; ... > + /* > + * If the flash need to be on, needs > + * config the flash current ramping up to the setting value. > + * Else, always recover back to the minimum one. > + */ ... > + /* For the flash turn on/off, need to wait HW ramping up/down time to turn > + * 5ms/500us to prevent the unexpected problem. > + */ Wrong multi-line comment style. > + No need for a blank line. > + if (!prev && curr) > + usleep_range(5000, 6000); > + else if (prev && !curr) > + udelay(500); ... > +static int mt6370_led_register(struct device *parent, struct mt6370_led *led, > + struct led_init_data *init_data) > +{ > + struct v4l2_flash_config v4l2_config = {0}; > + int ret; > + > + ret = devm_led_classdev_flash_register_ext(parent, &led->flash, > + init_data); > + if (ret) { > + dev_err(parent, "Couldn't register flash %d\n", led->led_no); > + return ret; return dev_err_probe() here and everywhere where it is about probe stage. > + } > + > + mt6370_init_v4l2_flash_config(led, &v4l2_config); > + led->v4l2_flash = v4l2_flash_init(parent, init_data->fwnode, > + &led->flash, &v4l2_flash_ops, > + &v4l2_config); > + if (IS_ERR(led->v4l2_flash)) { > + dev_err(parent, "Failed to register %d v4l2 sd\n", led->led_no); > + return PTR_ERR(led->v4l2_flash); > + } > + > + return 0; > +} ... > + num = fwnode_property_count_u32(init_data->fwnode, "led-sources"); > + if (num < 1 || num > MT6370_MAX_LEDS) { > + dev_err(priv->dev, > + "Not specified or wrong number of led-sources\n"); > + return -EINVAL; Ditto. > + } ... > + ret = fwnode_property_read_u32(init_data->fwnode, "led-max-microamp", > + &val); One line? ... > + val = clamp_align(val, MT6370_STRBTO_MIN_US, MT6370_STRBTO_MAX_US, > + MT6370_STRBTO_STEP_US); I would name it mt6370_clamp() to avoid potential collision in the global namespace in the future. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34D36C43334 for ; Sat, 16 Jul 2022 14:40:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 11CB510FB2B; Sat, 16 Jul 2022 14:36:05 +0000 (UTC) Received: from mail-yw1-x112d.google.com (mail-yw1-x112d.google.com [IPv6:2607:f8b0:4864:20::112d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9CDF410E19E for ; Fri, 15 Jul 2022 18:14:27 +0000 (UTC) Received: by mail-yw1-x112d.google.com with SMTP id 00721157ae682-31d85f82f0bso54465787b3.7 for ; Fri, 15 Jul 2022 11:14:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wYQx40/iCC7JCsgHdkd0E1jOgqV54xGVWGfgqFpzTxo=; b=CCNqrZ6xxLNILlnpWQJZURCM7WccDYI4HArJBKyxVZQ4tUE7wHsb8C+1xQrCcy/ctP hgNxqF3L/l+JVN/sIioIK7hlY2E24EgjBaYcjObgBZ96Go1MFnvrauI9olx68o+tAec5 0zqXIns8v8XdElhZwR+ilBWSFm2BAz09sy+iAz5QQOYZmnuuIUuyYZ7ilSKeAOMj7Dr0 nmKdVBdXufKKDMVxiWrXIc+cIpZBo8ghQfSQgHJj69Av/M38jJkwWwu38WYhZktwk2Sr Ktcv4iMX1VtKF6apNGtKuW2hT3Gz86OVl/1giJmpSuReSlovrn8AP0YP6RZk9atjVy9y /pvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wYQx40/iCC7JCsgHdkd0E1jOgqV54xGVWGfgqFpzTxo=; b=cy73WM/x0fooOsqfXkLDxegawi9i8cC17+9Efhp+unQ/0hmOug42b/d3oPxcBw2IMt 5fgOwqcaDPoFJX+x1EfPu0kITs55tkbvxdtImWucJkJcfAKmwpLSI12NlGmknZPXePWt MWMWxcZh65DKEr9CQVLQp7SOW5T075UGiI6JPeE0Ski+tC8M2330zLaeUkrvVVsKchR3 LINllkLBp0hfNBmdnP5AU1Yl173RXeU6LjgFJGGxPOipYKzi416WF9jSY6YWyNPAIUwQ 34kMo2jAjvVlUVtug/7BeWgYJh6DU+8QX7xolDdHaKL+lfGakOiBenrKvSvCsB+IZs/C c09w== X-Gm-Message-State: AJIora93+BzMjEiL9Femv8xTH5Ak+9KwF0o5MEmlMsxdmxnbdlFTesyk n6JBYRNdIngAdXJCJ3OpWk4JV20/bDy9DhcuRu4= X-Google-Smtp-Source: AGRyM1uDhQ/IPsk1j9mwzTNaBs0PF9Af75W/5SyN9tcIUEjc7IVgAe4YsQYGo3tn1MHf1/3mBdT0R30hiBZKjAGSBRA= X-Received: by 2002:a81:4bd7:0:b0:31c:91da:5a20 with SMTP id y206-20020a814bd7000000b0031c91da5a20mr18833575ywa.131.1657908866682; Fri, 15 Jul 2022 11:14:26 -0700 (PDT) MIME-Version: 1.0 References: <20220715112607.591-1-peterwu.pub@gmail.com> <20220715112607.591-13-peterwu.pub@gmail.com> In-Reply-To: <20220715112607.591-13-peterwu.pub@gmail.com> From: Andy Shevchenko Date: Fri, 15 Jul 2022 20:13:49 +0200 Message-ID: Subject: Re: [PATCH v5 12/13] leds: flashlight: mt6370: Add MediaTek MT6370 flashlight support To: ChiaEn Wu Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:FRAMEBUFFER LAYER" , "Krogerus, Heikki" , Krzysztof Kozlowski , Alice Chen , linux-iio , dri-devel , Liam Girdwood , cy_huang , Pavel Machek , Lee Jones , Linux LED Subsystem , Daniel Thompson , Helge Deller , Rob Herring , Chunfeng Yun , Guenter Roeck , devicetree , Linux PM , szuni chen , Mark Brown , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , linux-arm Mailing List , Jingoo Han , USB , Sebastian Reichel , Linux Kernel Mailing List , ChiaEn Wu , Greg Kroah-Hartman , Jonathan Cameron Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Jul 15, 2022 at 1:29 PM ChiaEn Wu wrote: > The MediaTek MT6370 is a highly-integrated smart power management IC, > whichincludes a single cell Li-Ion/Li-Polymer switching battery which includes > charger, a USB Type-C & Power Delivery (PD) controller, dual Flash > LED current sources, a RGB LED driver, a backlight WLED driver, > a display bias driver and a general LDO for portable devices. > > The Flash LED in MT6370 has 2 channel and support torch/strobe mode. channels > The commit add the support of MT6370 FLASH LED. Add the ... > +#define MT6370_FLCSEN_MASK_ALL (BIT(0) | BIT(1)) GENMASK() ... > + for (i = 0; i < MT6370_MAX_LEDS; i++) { > + ret = regmap_update_bits(priv->regmap, > + MT6370_REG_FLEDISTRB(i), > + MT6370_ISTROBE_MASK, flevel[i]); > + if (ret) > + return ret; > + } > + } else { > + ret = regmap_update_bits(priv->regmap, > + MT6370_REG_FLEDISTRB(led->led_no), > + MT6370_ISTROBE_MASK, val); > + } > + return ret; return regmap_update_bits(...); } return 0; ... > + /* > + * If the flash need to be on, needs > + * config the flash current ramping up to the setting value. > + * Else, always recover back to the minimum one. > + */ ... > + /* For the flash turn on/off, need to wait HW ramping up/down time to turn > + * 5ms/500us to prevent the unexpected problem. > + */ Wrong multi-line comment style. > + No need for a blank line. > + if (!prev && curr) > + usleep_range(5000, 6000); > + else if (prev && !curr) > + udelay(500); ... > +static int mt6370_led_register(struct device *parent, struct mt6370_led *led, > + struct led_init_data *init_data) > +{ > + struct v4l2_flash_config v4l2_config = {0}; > + int ret; > + > + ret = devm_led_classdev_flash_register_ext(parent, &led->flash, > + init_data); > + if (ret) { > + dev_err(parent, "Couldn't register flash %d\n", led->led_no); > + return ret; return dev_err_probe() here and everywhere where it is about probe stage. > + } > + > + mt6370_init_v4l2_flash_config(led, &v4l2_config); > + led->v4l2_flash = v4l2_flash_init(parent, init_data->fwnode, > + &led->flash, &v4l2_flash_ops, > + &v4l2_config); > + if (IS_ERR(led->v4l2_flash)) { > + dev_err(parent, "Failed to register %d v4l2 sd\n", led->led_no); > + return PTR_ERR(led->v4l2_flash); > + } > + > + return 0; > +} ... > + num = fwnode_property_count_u32(init_data->fwnode, "led-sources"); > + if (num < 1 || num > MT6370_MAX_LEDS) { > + dev_err(priv->dev, > + "Not specified or wrong number of led-sources\n"); > + return -EINVAL; Ditto. > + } ... > + ret = fwnode_property_read_u32(init_data->fwnode, "led-max-microamp", > + &val); One line? ... > + val = clamp_align(val, MT6370_STRBTO_MIN_US, MT6370_STRBTO_MAX_US, > + MT6370_STRBTO_STEP_US); I would name it mt6370_clamp() to avoid potential collision in the global namespace in the future. -- With Best Regards, Andy Shevchenko