All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Felipe Balbi <balbi@kernel.org>, USB <linux-usb@vger.kernel.org>,
	Ferry Toth <fntoth@gmail.com>,
	Wesley Cheng <wcheng@codeaurora.org>
Subject: Re: v5.13-rc3 --> v5.13-rc4 DWC3 breakage
Date: Mon, 31 May 2021 23:22:23 +0300	[thread overview]
Message-ID: <CAHp75Vc93a67fVqApGZ9qWy9d0yfasrO3S9-Ns7GqdSZSROuEQ@mail.gmail.com> (raw)
In-Reply-To: <CAHp75Vdjrj6=8thopwD7OPb-gxyVZx895Vd66mLSA4-BggdcWg@mail.gmail.com>

On Mon, May 31, 2021 at 6:45 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Mon, May 31, 2021 at 5:49 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Mon, May 31, 2021 at 05:33:02PM +0300, Andy Shevchenko wrote:
> > > Hi!
> > >
> > > The only patch that made v5.13-rc4 effectively broke USB on Intel Merrifield.
> > >
> > > My reproducer:
> > >  1. Boot with switch in gadget mode
> > >  2. Enable USB ethernet
> > >  3. Switch to host
> > >  4. wait a bit for device enumeration, etc
> > >  5. Switch back
> > >  6. No gadget mode, kernel RCU stall detected (USB become unusable, so
> > > does the system)
> > >
> > > [  115.792620] rcu: INFO: rcu_sched self-detected stall on CPU
> > > [  115.798410] rcu:     0-....: (24089 ticks this GP)
> > > idle=886/1/0x4000000000000000 softirq=3796/3797 fqs=5240
> > > [  115.808333]  (t=21000 jiffies g=6505 q=12158)
> > > [  115.812847] NMI backtrace for cpu 0
> > > [  115.816472] CPU: 0 PID: 23 Comm: kworker/0:1 Not tainted 5.13.0-rc4+ #213
> > > ...
> > >
> > > [  115.977913]  add_dma_entry+0xd4/0x1d0
> > > [  115.981760]  dma_map_page_attrs+0xd8/0x220
> > > [  115.986063]  usb_hcd_map_urb_for_dma+0x3b6/0x4f0
> > > [  115.990895]  usb_hcd_submit_urb+0x98/0xbf0
> > > [  115.995263]  dln2_rx+0x1ae/0x280 [dln2]
> > > ...
> > >
> > > 100% Reproducibility, revert of the 25dda9fc56bd ("usb: dwc3: gadget:
> > > Properly track pending and queued SG") fixes the issue.
> > >
> > > Please, fix it properly or revert. Thanks!
> >
> > Care to send the revert?
>
> Sure, But I want to give Thinh a chance to react to this, maybe it
> would be a better idea.
> Let's say if nothing happens I will send it on Wednesday.

Please, hold on, I have to perform additional testing (something odd
is going on on my side).

-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2021-05-31 20:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-31 14:33 v5.13-rc3 --> v5.13-rc4 DWC3 breakage Andy Shevchenko
2021-05-31 14:49 ` Greg Kroah-Hartman
2021-05-31 15:45   ` Andy Shevchenko
2021-05-31 20:22     ` Andy Shevchenko [this message]
2021-06-01 17:31       ` Andy Shevchenko
2021-06-01 20:00         ` Ferry Toth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHp75Vc93a67fVqApGZ9qWy9d0yfasrO3S9-Ns7GqdSZSROuEQ@mail.gmail.com \
    --to=andy.shevchenko@gmail.com \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=balbi@kernel.org \
    --cc=fntoth@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=wcheng@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.