From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BE3DC3A5A5 for ; Thu, 5 Sep 2019 08:11:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F36EB20828 for ; Thu, 5 Sep 2019 08:11:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FsniQefV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730809AbfIEILI (ORCPT ); Thu, 5 Sep 2019 04:11:08 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:43762 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725290AbfIEILI (ORCPT ); Thu, 5 Sep 2019 04:11:08 -0400 Received: by mail-pg1-f196.google.com with SMTP id u72so968422pgb.10; Thu, 05 Sep 2019 01:11:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BNUhBxF1OnG3d3ID43Jl2Sra4Jf1K5JNUVXSe0J/Mmo=; b=FsniQefV8YjuNc/PRrZO7rOT/9G0ax8+aLc2Sz/tUwIKjH+DrNsgTNPIdCNssllbf1 yTsw2jCCl+nhi3JG+3OiKUJbn9m3OqZzU/MwtpGG7EvVTeby+PTM1a4kWl+pAl/W8p2f QW3A2gnfv/hpd5csElAMUYftBSWWIMgYAbyA8tas18mDueWBGlE+8y8yMlS7K97UJz1e FdGd63Y59wGv26usW5cD/I64bNqERDONTXMRb/TQ1dMOR3neAW0ou+hw7gmHuZ/jLN3R Yq6qr2hqq64hFguW6qK+LgttRPvNo0jBVjB5hpdOXr7pVzj2BUERpVvhbtWwaa3rb9Bu 0X5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BNUhBxF1OnG3d3ID43Jl2Sra4Jf1K5JNUVXSe0J/Mmo=; b=TH+4o0+FR28jprocDOAgxdStGWwYI4ivFWyD9jEbgXJSqK/26fbtj+x1cpC51KPqf5 4BygmquP+5crbeqBq7wbVSV9zOCCP2mnPKGGHDcuBMzHSn0/ZJJg5mwOcUsFPPA+qIJg znozsFSRIbshEMeF9QTY9Tu8Hqy++Cw2il0jSdnqqp3O/msHAWRaJ0kNMcT9Tmn7/q8G /4TvZzJtdjul/KxSkoVIOiXvoyqmWMsfZwcHqKJURhidViw9Mf2d7gGP0SLRY4oP7+tJ /ow4wSMJ18pA9mc1diAxCajMA1D/610joibQO7e4Sb9QRdavgXeflmzTqc7Nd4QNmUvl fEsg== X-Gm-Message-State: APjAAAWty45o2FqkvW5k+m1tq+JCuS0f7XFROzp36srUBkbO3sgbupsg UqQ5Ym7uCHPazLoTmCKX47sQ2HNVCHwK/vdg8WA= X-Google-Smtp-Source: APXvYqxtpDJ3+oWsCUzA9PrngplgA8XurQG2hkrTxbU64Fwo0RP5J+VAvVKFqCivcEjjcIw5AUIW1TNKX62bq9nBXEs= X-Received: by 2002:a17:90a:338b:: with SMTP id n11mr2570783pjb.132.1567671067543; Thu, 05 Sep 2019 01:11:07 -0700 (PDT) MIME-Version: 1.0 References: <20190904061245.30770-1-rashmica.g@gmail.com> <20190904061245.30770-3-rashmica.g@gmail.com> <1ca6ffddd2452e218ef19ea84ac6c6277e1a9725.camel@gmail.com> In-Reply-To: <1ca6ffddd2452e218ef19ea84ac6c6277e1a9725.camel@gmail.com> From: Andy Shevchenko Date: Thu, 5 Sep 2019 11:10:55 +0300 Message-ID: Subject: Re: [PATCH 3/4] gpio: Add in ast2600 details to Aspeed driver To: Rashmica Gupta Cc: Linus Walleij , "open list:GPIO SUBSYSTEM" , Bartosz Golaszewski , linux-arm Mailing List , linux-aspeed@lists.ozlabs.org, Linux Kernel Mailing List , Joel Stanley , Andrew Jeffery Content-Type: text/plain; charset="UTF-8" Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, Sep 5, 2019 at 2:34 AM Rashmica Gupta wrote:> > On Wed, 2019-09-04 at 19:30 +0300, Andy Shevchenko wrote: > Perhaps this and your other comments below would be best addressed in > an additional cleanup patch? This patch follows the formatting of the > existing code and it's not very clean to differ from that or to change > the formatting of the current code in this patch. OK. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE284C3A5A5 for ; Thu, 5 Sep 2019 08:11:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7BAF921848 for ; Thu, 5 Sep 2019 08:11:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tvFzsNgy"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FsniQefV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BAF921848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=J3+RzR9M0C89z65naB/gRdxDjhWs60c4yGRxH2e70iE=; b=tvFzsNgyx5x75a WK2oYXzxfm0KhIe7ZBMentSDYslIgHaZ4K05MXXIM67gX+QXq1D7pfY6bqUCHD05CmP4ZTwslPwSR EzFMwJE015zeHDDsBrhpWGSSHsR7ehgvjjmqJ7cEZkkLxyEas4Id4d8Bak2YWGp2NNVpYkM5HMFqE eWOTwU6dgGzACDku9XmZT4WwS+0ti05TFCfnrW6YAJoRvUYjQ6/Jn7xQ2ck9I6iUtBGTIQ1yL7SbC 9vc0rrnNMcNXm2Q9xF6tQC6g6Me9C0UA78XxPf94ygBKuP8mi5JU2wzLii5ZJetEdVTpTKyyZLbuk Mp38G5fvBm7d2PIwU/0w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i5mrH-0005ws-1q; Thu, 05 Sep 2019 08:11:11 +0000 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i5mrE-0005tS-B2 for linux-arm-kernel@lists.infradead.org; Thu, 05 Sep 2019 08:11:09 +0000 Received: by mail-pg1-x544.google.com with SMTP id i18so965061pgl.11 for ; Thu, 05 Sep 2019 01:11:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BNUhBxF1OnG3d3ID43Jl2Sra4Jf1K5JNUVXSe0J/Mmo=; b=FsniQefV8YjuNc/PRrZO7rOT/9G0ax8+aLc2Sz/tUwIKjH+DrNsgTNPIdCNssllbf1 yTsw2jCCl+nhi3JG+3OiKUJbn9m3OqZzU/MwtpGG7EvVTeby+PTM1a4kWl+pAl/W8p2f QW3A2gnfv/hpd5csElAMUYftBSWWIMgYAbyA8tas18mDueWBGlE+8y8yMlS7K97UJz1e FdGd63Y59wGv26usW5cD/I64bNqERDONTXMRb/TQ1dMOR3neAW0ou+hw7gmHuZ/jLN3R Yq6qr2hqq64hFguW6qK+LgttRPvNo0jBVjB5hpdOXr7pVzj2BUERpVvhbtWwaa3rb9Bu 0X5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BNUhBxF1OnG3d3ID43Jl2Sra4Jf1K5JNUVXSe0J/Mmo=; b=QQhLKf5oJk8Px7ESDdVGxNHv8qeH9RKgJc+N/f6WJ2x/sNtcgEqM5B411dENPry3wq NtSqwMqz68OCJph1fZluS8gCx2ucTAWypeq8BoHGUmShmfUlfqV2i9nsHsoSLm7+sYNd oS4n9LOT2sqdpGTpxmU26qVDZXdqi08OFuFpboIhiKN+8Ewhk4r8kxsSOirpLrCbhO7Z nhgeN/Op8MYt9BTnsLii1sKdcyKZMDcA5pxHJZicbCKQxXzvN0rUMKUIxH63s5TxUIRN p/BGN+uy2aU3+LSEDc5M/D3MCbEdW8qtB/a8fwpTBN3rEL5ftwcWZp0JJyd1JOS/ayxT SOQg== X-Gm-Message-State: APjAAAUkns+ZzrmdUfiVqMr1egtJGdmLGPRcMvpe+UutjS6WWhzYZzHC WKLiq6U8jc481zDhrze3ntWIsQKU2kflelxuZUE= X-Google-Smtp-Source: APXvYqxtpDJ3+oWsCUzA9PrngplgA8XurQG2hkrTxbU64Fwo0RP5J+VAvVKFqCivcEjjcIw5AUIW1TNKX62bq9nBXEs= X-Received: by 2002:a17:90a:338b:: with SMTP id n11mr2570783pjb.132.1567671067543; Thu, 05 Sep 2019 01:11:07 -0700 (PDT) MIME-Version: 1.0 References: <20190904061245.30770-1-rashmica.g@gmail.com> <20190904061245.30770-3-rashmica.g@gmail.com> <1ca6ffddd2452e218ef19ea84ac6c6277e1a9725.camel@gmail.com> In-Reply-To: <1ca6ffddd2452e218ef19ea84ac6c6277e1a9725.camel@gmail.com> From: Andy Shevchenko Date: Thu, 5 Sep 2019 11:10:55 +0300 Message-ID: Subject: Re: [PATCH 3/4] gpio: Add in ast2600 details to Aspeed driver To: Rashmica Gupta X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190905_011108_375770_A62C17D5 X-CRM114-Status: UNSURE ( 9.56 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aspeed@lists.ozlabs.org, Bartosz Golaszewski , Andrew Jeffery , Linus Walleij , Linux Kernel Mailing List , "open list:GPIO SUBSYSTEM" , Joel Stanley , linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 5, 2019 at 2:34 AM Rashmica Gupta wrote:> > On Wed, 2019-09-04 at 19:30 +0300, Andy Shevchenko wrote: > Perhaps this and your other comments below would be best addressed in > an additional cleanup patch? This patch follows the formatting of the > existing code and it's not very clean to differ from that or to change > the formatting of the current code in this patch. OK. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel