From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Cc: Chris Ruehl <chris.ruehl@gtsys.com.hk>,
Jonathan Cameron <jic23@kernel.org>,
linux-iio <linux-iio@vger.kernel.org>
Subject: Re: [PATCH 2/3] iio: DAC extension for ltc2634-12/10/8
Date: Tue, 14 Apr 2020 18:07:09 +0300 [thread overview]
Message-ID: <CAHp75VcD6j-OLTN1hUZ5+j-L+yZmpmy8LSi1NkDoLdoKGyYEZw@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2004140920210.21841@vps.pmeerw.net>
On Tue, Apr 14, 2020 at 5:51 PM Peter Meerwald-Stadler
<pmeerw@pmeerw.net> wrote:
...
> > @@ -357,6 +393,12 @@ static const struct spi_device_id ltc2632_id[] = {
> > { "ltc2632-h12", (kernel_ulong_t)<c2632_chip_info_tbl[ID_LTC2632H12] },
> > { "ltc2632-h10", (kernel_ulong_t)<c2632_chip_info_tbl[ID_LTC2632H10] },
> > { "ltc2632-h8", (kernel_ulong_t)<c2632_chip_info_tbl[ID_LTC2632H8] },
> > + { "ltc2634-l12", (kernel_ulong_t)<c2632_chip_info_tbl[ID_LTC2634L12] },
>
> is kernel_ulong_t the correct type here?
Pretty much.
> i.e. guaranteed to hold a pointer value, such as uintptr_t in C?
> it seems so, but why not use uintptr_t?
Because of inconsistency with a definition of structure. Please, refer
to mod_devicetable.h for the details.
> > + { "ltc2634-l10", (kernel_ulong_t)<c2632_chip_info_tbl[ID_LTC2634L10] },
> > + { "ltc2634-l8", (kernel_ulong_t)<c2632_chip_info_tbl[ID_LTC2634L8] },
> > + { "ltc2634-h12", (kernel_ulong_t)<c2632_chip_info_tbl[ID_LTC2634H12] },
> > + { "ltc2634-h10", (kernel_ulong_t)<c2632_chip_info_tbl[ID_LTC2634H10] },
> > + { "ltc2634-h8", (kernel_ulong_t)<c2632_chip_info_tbl[ID_LTC2634H8] },
> > { "ltc2636-l12", (kernel_ulong_t)<c2632_chip_info_tbl[ID_LTC2636L12] },
> > { "ltc2636-l10", (kernel_ulong_t)<c2632_chip_info_tbl[ID_LTC2636L10] },
> > { "ltc2636-l8", (kernel_ulong_t)<c2632_chip_info_tbl[ID_LTC2636L8] },
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-04-14 15:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 6:27 [PATCH 2/3] iio: DAC extension for ltc2634-12/10/8 Chris Ruehl
2020-04-14 7:29 ` Peter Meerwald-Stadler
2020-04-14 9:49 ` Chris Ruehl
2020-04-14 18:03 ` Jonathan Cameron
2020-04-14 15:07 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VcD6j-OLTN1hUZ5+j-L+yZmpmy8LSi1NkDoLdoKGyYEZw@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=chris.ruehl@gtsys.com.hk \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.