From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751808AbeFAKwr (ORCPT ); Fri, 1 Jun 2018 06:52:47 -0400 Received: from mail-qk0-f193.google.com ([209.85.220.193]:35615 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751346AbeFAKwp (ORCPT ); Fri, 1 Jun 2018 06:52:45 -0400 X-Google-Smtp-Source: ADUXVKIy08YPwsPrrRNJNNSWJBOi6dvLX0Sqjt+sylq9QQKOILkoWHTmq7tZk2gf6SSZQvrbc7fWlwSZQrLFAiJjy1Y= MIME-Version: 1.0 In-Reply-To: <1527850145.28160.6.camel@mhfsdcap03> References: <1527822270-30280-1-git-send-email-honghui.zhang@mediatek.com> <1527850145.28160.6.camel@mhfsdcap03> From: Andy Shevchenko Date: Fri, 1 Jun 2018 13:52:44 +0300 Message-ID: Subject: Re: [PATCH v3] PCI: mediatek: Add system pm support for MT2712 To: Honghui Zhang Cc: Arnd Bergmann , Lorenzo Pieralisi , Marc Zyngier , Bjorn Helgaas , Matthias Brugger , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , linux-pci@vger.kernel.org, Linux Kernel Mailing List , devicetree , yingjoe.chen@mediatek.com, Eddie Huang , ryder.lee@mediatek.com, hongkun.cao@mediatek.com, youlin.pei@mediatek.com, yong.wu@mediatek.com, yt.shen@mediatek.com, sean.wang@mediatek.com, xinping.qian@mediatek.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 1, 2018 at 1:49 PM, Honghui Zhang wrote: > On Fri, 2018-06-01 at 13:17 +0300, Andy Shevchenko wrote: >> On Fri, Jun 1, 2018 at 6:04 AM, wrote: >> > From: Honghui Zhang >> >> > +#ifdef CONFIG_PM_SLEEP >> > +static int mtk_pcie_suspend_noirq(struct device *dev) >> >> __maybe_unused >> > > Hi, Andy, thanks for your review. > Bjorn had point this out that at: > https://www.spinics.net/lists/arm-kernel/msg656774.html Nice, one more maintainer with strong opinion here. Arnd, that's what I mentioned as a split in opinions earlier. Any new developer or even existing contributor would be now really confusing since maintainers asked for two different approaches on the same matter. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: MIME-Version: 1.0 In-Reply-To: <1527850145.28160.6.camel@mhfsdcap03> References: <1527822270-30280-1-git-send-email-honghui.zhang@mediatek.com> <1527850145.28160.6.camel@mhfsdcap03> From: Andy Shevchenko Date: Fri, 1 Jun 2018 13:52:44 +0300 Message-ID: Subject: Re: [PATCH v3] PCI: mediatek: Add system pm support for MT2712 To: Honghui Zhang List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: youlin.pei@mediatek.com, devicetree , hongkun.cao@mediatek.com, Lorenzo Pieralisi , Marc Zyngier , linux-pci@vger.kernel.org, sean.wang@mediatek.com, xinping.qian@mediatek.com, Linux Kernel Mailing List , yt.shen@mediatek.com, Matthias Brugger , ryder.lee@mediatek.com, "moderated list:ARM/Mediatek SoC support" , yong.wu@mediatek.com, Bjorn Helgaas , yingjoe.chen@mediatek.com, Arnd Bergmann , Eddie Huang , linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: On Fri, Jun 1, 2018 at 1:49 PM, Honghui Zhang wrote: > On Fri, 2018-06-01 at 13:17 +0300, Andy Shevchenko wrote: >> On Fri, Jun 1, 2018 at 6:04 AM, wrote: >> > From: Honghui Zhang >> >> > +#ifdef CONFIG_PM_SLEEP >> > +static int mtk_pcie_suspend_noirq(struct device *dev) >> >> __maybe_unused >> > > Hi, Andy, thanks for your review. > Bjorn had point this out that at: > https://www.spinics.net/lists/arm-kernel/msg656774.html Nice, one more maintainer with strong opinion here. Arnd, that's what I mentioned as a split in opinions earlier. Any new developer or even existing contributor would be now really confusing since maintainers asked for two different approaches on the same matter. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: andy.shevchenko@gmail.com (Andy Shevchenko) Date: Fri, 1 Jun 2018 13:52:44 +0300 Subject: [PATCH v3] PCI: mediatek: Add system pm support for MT2712 In-Reply-To: <1527850145.28160.6.camel@mhfsdcap03> References: <1527822270-30280-1-git-send-email-honghui.zhang@mediatek.com> <1527850145.28160.6.camel@mhfsdcap03> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Jun 1, 2018 at 1:49 PM, Honghui Zhang wrote: > On Fri, 2018-06-01 at 13:17 +0300, Andy Shevchenko wrote: >> On Fri, Jun 1, 2018 at 6:04 AM, wrote: >> > From: Honghui Zhang >> >> > +#ifdef CONFIG_PM_SLEEP >> > +static int mtk_pcie_suspend_noirq(struct device *dev) >> >> __maybe_unused >> > > Hi, Andy, thanks for your review. > Bjorn had point this out that at: > https://www.spinics.net/lists/arm-kernel/msg656774.html Nice, one more maintainer with strong opinion here. Arnd, that's what I mentioned as a split in opinions earlier. Any new developer or even existing contributor would be now really confusing since maintainers asked for two different approaches on the same matter. -- With Best Regards, Andy Shevchenko