From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Alban Bedel <alban.bedel@aerq.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio <linux-gpio@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio: pca953x: add support for open drain pins on PCAL6524
Date: Wed, 3 Feb 2021 12:12:52 +0200 [thread overview]
Message-ID: <CAHp75VcPeJOrX0A3DLM8Z0v-H2xVd0TrrssEXe5ZMOFcspsrfQ@mail.gmail.com> (raw)
In-Reply-To: <CAMpxmJXACfOkRB6m-_n_EmUf=6zLjQAie-UcQw+MNr-rTRC2SA@mail.gmail.com>
On Tue, Feb 2, 2021 at 1:45 PM Bartosz Golaszewski
<bgolaszewski@baylibre.com> wrote:
> On Thu, Jan 28, 2021 at 4:36 PM Alban Bedel <alban.bedel@aerq.com> wrote:
> >
> > From a quick glance at various datasheet the PCAL6524 seems to be the
Oh, even more typos
datasheets
> > only chip in this familly that support setting the drive mode of
supports
> > single pins. Other chips either don't support it at all, or can only
> > set the drive mode of whole banks, which doesn't map to the GPIO API.
> >
> > Add a new flag, PCAL6524, to mark chips that have the extra registers
> > needed for this feature. Then mark the needed register banks as
> > readable and writable, here we don't set OUT_CONF as writable,
> > although it is, as we only need to read it. Finally add a function
> > that configure the OUT_INDCONF register when the GPIO API set the
> > drive mode of the pins.
...
> Maybe call it PCAL6524_TYPE for consistency with the ones below?
In case you continue modifying this driver, I agree with Bart on
PCAL6524_TYPE along with new OF_6524() macro.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-02-03 10:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 15:36 [PATCH] gpio: pca953x: add support for open drain pins on PCAL6524 Alban Bedel
2021-02-02 11:42 ` Bartosz Golaszewski
2021-02-02 17:45 ` Bedel, Alban
2021-02-03 10:12 ` Andy Shevchenko [this message]
2021-02-02 13:57 ` Linus Walleij
2021-02-02 17:45 ` Bedel, Alban
2021-02-02 19:21 ` Linus Walleij
2021-02-03 10:10 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VcPeJOrX0A3DLM8Z0v-H2xVd0TrrssEXe5ZMOFcspsrfQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=alban.bedel@aerq.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.