All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Menglong Dong <menglong8.dong@gmail.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
	Jakub Kicinski <kuba@kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"axboe@kernel.dk" <axboe@kernel.dk>,
	"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
	"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
	"dong.menglong@zte.com.cn" <dong.menglong@zte.com.cn>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v4 RESEND net-next] net: socket: use BIT() for MSG_*
Date: Wed, 17 Mar 2021 11:40:03 +0200	[thread overview]
Message-ID: <CAHp75VcS0tEeDmDZA+mXs4mZRt-o39MHkxrgarB-O=6DTRjF1Q@mail.gmail.com> (raw)
In-Reply-To: <CAHp75Vfo=rtK0=nRTZNwL3peUXGt5PTo4d_epCgLChSD0CKRVw@mail.gmail.com>

On Wed, Mar 17, 2021 at 11:36 AM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Wed, Mar 17, 2021 at 10:21 AM Menglong Dong <menglong8.dong@gmail.com> wrote:

...

> It maybe fixed by swapping positions of the arguments, i.e. ~(FOO |
> BAR) & flags.

...and type casting will be needed anyway here...

I was thinking about this case

drivers/i2c/busses/i2c-designware-common.c:420:
dev->sda_hold_time & ~(u32)DW_IC_SDA_HOLD_RX_MASK
,

but sda_hold_time there is unsigned.

-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2021-03-17  9:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-10  1:51 [PATCH v4 RESEND net-next] net: socket: use BIT() for MSG_* menglong8.dong
2021-03-10 21:00 ` patchwork-bot+netdevbpf
2021-03-16 22:48 ` Guenter Roeck
     [not found]   ` <CAHp75VdE3fkCjb53vBso5uJX9aEFtAOAdh5NVOSbK0YR64+jOg@mail.gmail.com>
2021-03-16 23:54     ` Guenter Roeck
2021-03-17  1:37     ` Guenter Roeck
2021-03-17  8:21       ` Menglong Dong
2021-03-17  9:36         ` Andy Shevchenko
2021-03-17  9:40           ` Andy Shevchenko [this message]
2021-03-17 10:17             ` Guenter Roeck
2021-03-17 13:53           ` Menglong Dong
2021-03-17 14:15             ` Menglong Dong
2021-03-17 15:02             ` Guenter Roeck
2021-03-17 16:39         ` David Miller
2021-03-17 15:12       ` David Laight
2021-03-18  1:48         ` Menglong Dong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHp75VcS0tEeDmDZA+mXs4mZRt-o39MHkxrgarB-O=6DTRjF1Q@mail.gmail.com' \
    --to=andy.shevchenko@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=davem@davemloft.net \
    --cc=dong.menglong@zte.com.cn \
    --cc=herbert@gondor.apana.org.au \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=menglong8.dong@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.