From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1090EC433B4 for ; Mon, 19 Apr 2021 11:15:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DCF5660C3F for ; Mon, 19 Apr 2021 11:15:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233862AbhDSLPo (ORCPT ); Mon, 19 Apr 2021 07:15:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230070AbhDSLPm (ORCPT ); Mon, 19 Apr 2021 07:15:42 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9FD0C06174A; Mon, 19 Apr 2021 04:15:12 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id cu16so15728885pjb.4; Mon, 19 Apr 2021 04:15:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fyLO68cYQAdbeG7I5stptSDRdNhYWf3KZX5hVoH8RUc=; b=tVD+Frbk3fpsSGakZ6vAUeXjiXHk6aLxIzoWOJ79QCPRe5sg+qOssPKCBuFpZ5ExOh cYbxMV4raTskb/a7ddC9H5i2BKwdEq7spfQHIlf2jVAkHJxBU0Ei6GsXCcCdL2QMpnuE NuGaQ74p+iU9G4sazo85cs6eV/ZPi5LU+H8jafL3qNVRBzyNmgrPMsxyXExPo+DHuwFv tdPpf/Vv0zAL3K2sebt2+RdE1DKO/JaqaSETVgIsu5ibHTsU6O17m3ulHZtfSBA3otBu 36NS3LLD+mlC9bWFvFn98OLWOwUKvIpKeoMzxT9rPLm0PMCFOiMv5yHZ7jV44lhX0FUs RgGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fyLO68cYQAdbeG7I5stptSDRdNhYWf3KZX5hVoH8RUc=; b=mioWvyt+fHfRk88zYgm96AIrBvJoaQlcCMhkEQZjow9BrW4Y4NXqRIPY5HMyQRJQZk pK9c6F8eTDxhI0AaO/TSbDbOY+Mk1wY/unOAN/ksIvFen5ZKktNTMkeukiAzkX1NOyLP RY+OW9zc8qvhHZg7jMXe4nebJ3dV8inoKQ86CV7C9Uu3WJnfEmHe9rV3+My9sBln7wIT AIgO5kGQaU7IhEm7i0G0oSNJUW4fVAxG3rvzeSjQb0i52R1L6V9WCYwnLELWlv00DM1I VHk/IEhJII5yHE0iPYOQU564gSp2k3sX8rN2my8l3W1LLk6rZCsW/Vi4SPU4dbMHYT7F yJfQ== X-Gm-Message-State: AOAM53144tzNkvaI3rzKuKugd1VjBMQo2OIK7pa8BSvxvcvZW/eizFZk KkZk5V395zG0nsnKMiMxEeDD7iKULBywJgpjojU= X-Google-Smtp-Source: ABdhPJz+wzghLLCvx06cKOPWLeBhgarcoxi0Xt2i3Juf+K3Pdv7kq6+jr+XQ6egZQWF1rL5+Yj/RWsbr5jNrL4ku0SM= X-Received: by 2002:a17:902:a406:b029:e6:78c4:71c8 with SMTP id p6-20020a170902a406b02900e678c471c8mr22295456plq.17.1618830911997; Mon, 19 Apr 2021 04:15:11 -0700 (PDT) MIME-Version: 1.0 References: <20210416134546.38475-1-tomas.melin@vaisala.com> <20210416134546.38475-3-tomas.melin@vaisala.com> <91ea3aba-854e-30f1-1236-733debfcf5dc@vaisala.com> In-Reply-To: <91ea3aba-854e-30f1-1236-733debfcf5dc@vaisala.com> From: Andy Shevchenko Date: Mon, 19 Apr 2021 14:14:55 +0300 Message-ID: Subject: Re: [PATCH v2 2/2] iio: accel: Add driver for Murata SCA3300 accelerometer To: Tomas Melin Cc: Jonathan Cameron , devicetree , linux-iio , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 19, 2021 at 1:29 PM Tomas Melin wrote: > On 4/17/21 3:39 PM, Andy Shevchenko wrote: > > On Fri, Apr 16, 2021 at 5:21 PM Tomas Melin wrote: > >> Add initial support for Murata SCA3300 3-axis industrial > >> accelerometer with digital SPI interface. This device also > >> provides a temperature measurement. ... > >> + ret = spi_sync_transfer(sca_data->spi, xfers, ARRAY_SIZE(xfers)); > >> + if (ret < 0) { > >> + dev_err(&sca_data->spi->dev, > >> + "transfer error, error: %d\n", ret); > >> + return -EIO; > > Why shadowing error code? > > Returning EIO here to have full control over the return value from this > function. As return value of this is used for testing Care to show what kind of testing requires this? Also why can't it be refactored to accept all error codes? > for possible status error (EINVAL), feels more confident to have it like > this to avoid any confusion. And atleast spi_sync_transfer() return value > > would be visible in error message. > >> + } -- With Best Regards, Andy Shevchenko