All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Hammer Hsieh <hammerh0314@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh+dt@kernel.org>,
	"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	tony.huang@sunplus.com, wells.lu@sunplus.com,
	Hammer Hsieh <hammer.hsieh@sunplus.com>
Subject: Re: [PATCH v2 0/2] Add UART driver for Suplus SP7021 SoC
Date: Wed, 10 Nov 2021 18:41:25 +0200	[thread overview]
Message-ID: <CAHp75VcZuN0-zJjQUk5Afgqd-ON5PjVzMSjfM2Mouiq-EXjcWw@mail.gmail.com> (raw)
In-Reply-To: <1636530670-6995-1-git-send-email-hammer.hsieh@sunplus.com>

On Wed, Nov 10, 2021 at 9:51 AM Hammer Hsieh <hammerh0314@gmail.com> wrote:
>
> This is a patch series for UART driver for Suplus SP7021 SoC.
>
> Sunplus SP7021 is an ARM Cortex A7 (4 cores) based SoC. It integrates
> many peripherals (ex: UART. I2C, SPI, SDIO, eMMC, USB, SD card and
> etc.) into a single chip. It is designed for industrial control.
>
> Refer to:
> https://sunplus-tibbo.atlassian.net/wiki/spaces/doc/overview
> https://tibbo.com/store/plus1.html

...

>  drivers/tty/serial/sunplus-uart.c                  | 1591 ++++++++++++++++++++
>  include/soc/sunplus/sp_uart.h                      |  147 ++

Sorry, but I do not believe this driver requires so many LOCs. Please,
try to get it under 1000, I am pretty sure it's possible and
achievable.

-- 
With Best Regards,
Andy Shevchenko

  parent reply	other threads:[~2021-11-10 16:42 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-01  7:48 [PATCH 0/2] Add UART driver for Suplus SP7021 SoC hammer.hsieh
2021-11-01  7:48 ` [PATCH 1/2] dt-bindings:serial:Add bindings doc for Sunplus SoC UART Driver hammer.hsieh
2021-11-01 13:20   ` Rob Herring
2021-11-01 19:34   ` Rob Herring
2021-11-01  7:48 ` [PATCH 2/2] serial:sunplus-uart:Add " hammer.hsieh
2021-11-01  7:56   ` Greg KH
2021-11-10  7:51 ` [PATCH v2 0/2] Add UART driver for Suplus SP7021 SoC Hammer Hsieh
2021-11-10  7:51   ` [PATCH v2 1/2] dt-bindings:serial:Add bindings doc for Sunplus SoC UART Driver Hammer Hsieh
2021-11-10  7:51   ` [PATCH v2 2/2] serial:sunplus-uart:Add " Hammer Hsieh
2021-11-10  9:50     ` Philipp Zabel
2021-11-11  9:45       ` Hammer Hsieh 謝宏孟
2021-11-12  8:31     ` kernel test robot
2021-11-12  8:31       ` kernel test robot
2021-11-10 16:41   ` Andy Shevchenko [this message]
2021-11-19  5:19 ` [PATCH v3 0/2] Add UART driver for Suplus SP7021 SoC Hammer Hsieh
2021-11-19  5:19   ` [PATCH v3 1/2] dt-bindings:serial:Add bindings doc for Sunplus SoC UART Driver Hammer Hsieh
2021-11-29  0:22     ` Rob Herring
2021-11-19  5:19   ` [PATCH v3 2/2] serial:sunplus-uart:Add " Hammer Hsieh
2021-11-19  9:35     ` Andy Shevchenko
2021-11-23  3:43       ` Hammer Hsieh 謝宏孟

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHp75VcZuN0-zJjQUk5Afgqd-ON5PjVzMSjfM2Mouiq-EXjcWw@mail.gmail.com \
    --to=andy.shevchenko@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hammer.hsieh@sunplus.com \
    --cc=hammerh0314@gmail.com \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=tony.huang@sunplus.com \
    --cc=wells.lu@sunplus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.