From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Potin Lai <potin.lai.pt@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Patrick Williams <patrick@stwcx.xyz>,
Potin Lai <potin.lai@quantatw.com>,
linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] iio: humidity: hdc100x: switch to probe_new callback
Date: Wed, 27 Jul 2022 19:06:23 +0200 [thread overview]
Message-ID: <CAHp75Vcar4Ufg1UpS6kGcieBCAwVh_KiUgiMEDJugb1YqO_FHg@mail.gmail.com> (raw)
In-Reply-To: <20220727164133.973930-2-potin.lai.pt@gmail.com>
On Wed, Jul 27, 2022 at 6:43 PM Potin Lai <potin.lai.pt@gmail.com> wrote:
>
> Switch to probe_new callback due to probe is deprecated soon.
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Potin Lai <potin.lai.pt@gmail.com>
> ---
> drivers/iio/humidity/hdc100x.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/humidity/hdc100x.c b/drivers/iio/humidity/hdc100x.c
> index 9e0fce917ce4c..0d514818635cb 100644
> --- a/drivers/iio/humidity/hdc100x.c
> +++ b/drivers/iio/humidity/hdc100x.c
> @@ -351,8 +351,7 @@ static const struct iio_info hdc100x_info = {
> .attrs = &hdc100x_attribute_group,
> };
>
> -static int hdc100x_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int hdc100x_probe(struct i2c_client *client)
> {
> struct iio_dev *indio_dev;
> struct hdc100x_data *data;
> @@ -422,7 +421,7 @@ static struct i2c_driver hdc100x_driver = {
> .name = "hdc100x",
> .of_match_table = hdc100x_dt_ids,
> },
> - .probe = hdc100x_probe,
> + .probe_new = hdc100x_probe,
> .id_table = hdc100x_id,
> };
> module_i2c_driver(hdc100x_driver);
> --
> 2.31.1
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-07-27 18:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 16:41 [PATCH v3 0/2] iio: humidity: hdc100x: add manufacturer and device ID check Potin Lai
2022-07-27 16:41 ` [PATCH v3 1/2] iio: humidity: hdc100x: switch to probe_new callback Potin Lai
2022-07-27 17:06 ` Andy Shevchenko [this message]
2022-07-27 16:41 ` [PATCH v3 2/2] iio: humidity: hdc100x: add manufacturer and device ID check Potin Lai
2022-07-27 17:14 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vcar4Ufg1UpS6kGcieBCAwVh_KiUgiMEDJugb1YqO_FHg@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrick@stwcx.xyz \
--cc=potin.lai.pt@gmail.com \
--cc=potin.lai@quantatw.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.