From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Sergey Ryazanov <ryazanov.s.a@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"David S. Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Loic Poulain <loic.poulain@linaro.org>,
Johannes Berg <johannes@sipsolutions.net>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH v2 2/2] wwan: core: Unshadow error code returned by ida_alloc_range))
Date: Fri, 6 Aug 2021 17:19:44 +0300 [thread overview]
Message-ID: <CAHp75VcbucQ4w1rki2NZvpS7p-z5b582HwWXDMW5G67C7C6f3w@mail.gmail.com> (raw)
In-Reply-To: <CAHNKnsTPQp16FPuVxY+FtJVOXnSga7zt=K8bhXr2YG15M9Y0eQ@mail.gmail.com>
On Fri, Aug 6, 2021 at 5:14 PM Sergey Ryazanov <ryazanov.s.a@gmail.com> wrote:
> On Fri, Aug 6, 2021 at 12:00 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > ida_alloc_range)) may return other than -ENOMEM error code.
> > Unshadow it in the wwan_create_port().
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> A small nitpick, looks like "ida_alloc_range))" in the description is
> a typo and should be "ida_alloc_range()". Besides this:
Shall I resend?
> Reviewed-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>
Thanks!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-08-06 14:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 8:54 [PATCH v2 1/2] wwan: core: Avoid returning NULL from wwan_create_dev() Andy Shevchenko
2021-08-06 8:54 ` [PATCH v2 2/2] wwan: core: Unshadow error code returned by ida_alloc_range)) Andy Shevchenko
2021-08-06 9:17 ` Sergey Ryazanov
2021-08-06 14:19 ` Andy Shevchenko [this message]
2021-08-06 20:35 ` Sergey Ryazanov
2021-08-11 12:50 ` Andy Shevchenko
2021-08-06 9:32 ` Loic Poulain
2021-08-06 9:15 ` [PATCH v2 1/2] wwan: core: Avoid returning NULL from wwan_create_dev() Sergey Ryazanov
2021-08-06 9:29 ` Loic Poulain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VcbucQ4w1rki2NZvpS7p-z5b582HwWXDMW5G67C7C6f3w@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=ryazanov.s.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.