From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00931C433DB for ; Thu, 11 Mar 2021 18:15:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B50DB64E28 for ; Thu, 11 Mar 2021 18:15:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230173AbhCKSPT (ORCPT ); Thu, 11 Mar 2021 13:15:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230154AbhCKSPB (ORCPT ); Thu, 11 Mar 2021 13:15:01 -0500 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1774C061574; Thu, 11 Mar 2021 10:15:01 -0800 (PST) Received: by mail-pl1-x62a.google.com with SMTP id n17so7053724plc.7; Thu, 11 Mar 2021 10:15:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dws62jrAOnft9HTIUVBwsXMXaS222scIKagfo6JeNDg=; b=UsrBWEUSmoqSxYXawqPv2K0aIpL1I5euE8CjW7R4lm/gaQts9YOXll57qdHI3QvTAl Halp7lyd4id0oIVJQXTNvkS9FHZBL42kRBYUrKPJChZK+3Xux4Zw7HFIqpzXV8XX1nUs Wxavuf9SJnZYg2BW7vE6x1KJoofSMHEKmiPsh3J6pmTepCOGSmqaOrZUxrKqPEW2C6+k Q+IfTPAOwOnHYkUC/vkgCvV4VkmX3tfcPmuP07WjKYWZJpnxlZdWocIIamomXu+pK9ST 4QsFTy9TSr7zPW3LDdfGHWT83iFpK3AE0rl4vzGEUqFmkplaiIB+MlVxtgJPwkevg/kE Y/Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dws62jrAOnft9HTIUVBwsXMXaS222scIKagfo6JeNDg=; b=NW193A26ajEoZrdGTOXPGih03FXI3Wrag5W8FEZuMRrsUKgN3PzLC3scDJl58NvyFu qcG8NQIpnMx3j3Kesgvdn6Cp/IGvpMcKORoeifKf7SgaiDI/JIxf8x0DAElSixCIEkLq GZID8e8gZzzUzV7DSqBiy2iUh4z/wzVEqFnaX2HWKli8WzM0UE0/ybsS2UHThV9/g1qr XEFi0MdWGtuhWpo2EF0g0fCLrrc7xXYs66iyFVbEPJJhrBqn9oqXFW5rFEq3cLJ/Z/7r xc1WiktKxH6+3A1F8hid9hBQO9Li1nQzRCPb+NNJsUcogYptj5JJGWQpNz/jguMP/8EW oxUQ== X-Gm-Message-State: AOAM530n6ndoNBRRH/bHjPm7J6XqBoa9NNWBkCIrwNr+ix24CVpZTRCY ppWKkiCRtKmDUp6+nFRbiWB6yoCYu/hl+mGWGKQ= X-Google-Smtp-Source: ABdhPJwgL0YGRGL55JayrSg2l+lpYdFJjNs7gzsUjCmXydM88Y9NwFBtJ/YU2wE36U0WbNNGMOvQ0Hb1mQsBI0dyCdM= X-Received: by 2002:a17:90a:db49:: with SMTP id u9mr10457516pjx.181.1615486501144; Thu, 11 Mar 2021 10:15:01 -0800 (PST) MIME-Version: 1.0 References: <20210311062011.8054-1-calvin.johnson@oss.nxp.com> <20210311062011.8054-9-calvin.johnson@oss.nxp.com> <20210311180010.GC5031@lsv03152.swis.in-blr01.nxp.com> In-Reply-To: <20210311180010.GC5031@lsv03152.swis.in-blr01.nxp.com> From: Andy Shevchenko Date: Thu, 11 Mar 2021 20:14:44 +0200 Message-ID: Subject: Re: [net-next PATCH v7 08/16] net: mdiobus: Introduce fwnode_mdiobus_register_phy() To: Calvin Johnson Cc: Grant Likely , "Rafael J . Wysocki" , Jeremy Linton , Andrew Lunn , Florian Fainelli , Russell King - ARM Linux admin , Cristi Sovaiala , Florin Laurentiu Chiculita , Ioana Ciornei , Madalin Bucur , Heikki Krogerus , Marcin Wojtas , Pieter Jansen Van Vuuren , Jon , Saravana Kannan , Randy Dunlap , linux-arm Mailing List , Diana Madalina Craciun , ACPI Devel Maling List , Linux Kernel Mailing List , "linux.cj" , netdev , Laurentiu Tudor , "David S. Miller" , Frank Rowand , Heiner Kallweit , Jakub Kicinski , Rob Herring , devicetree Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Mar 11, 2021 at 8:00 PM Calvin Johnson wrote: > On Thu, Mar 11, 2021 at 02:09:37PM +0200, Andy Shevchenko wrote: > > On Thu, Mar 11, 2021 at 8:21 AM Calvin Johnson > > wrote: ... > > > +config FWNODE_MDIO > > > + def_tristate PHYLIB > > > > (Seems "selectable only" item) > > What do you mean by "selectable only" item here? Can you please point to some > other example? The Kconfig sections without descriptions are not user-visible. No user can run menuconfig and check a box with "I want this to be compiled". tristate // selectable-only tristate "bla bla bla" // user visible and selectable > > > + depends on ACPI > > > + depends on OF > > > > Wouldn't be better to have > > depends on (ACPI || OF) || COMPILE_TEST > > > > And honestly I don't understand it in either (AND or OR) variant. Why > > do you need a dependency like this for fwnode API? > > Here, fwnode_mdiobus_register_phy() uses objects from both ACPI and OF. APIs? Calls? What really fails if we have !ACPI and / or !OF? > > Moreover dependencies don't work for "selectable only" items. > > > > > + depends on PHYLIB > > > + select FIXED_PHY -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 256C1C433E0 for ; Thu, 11 Mar 2021 18:16:52 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FF9764E28 for ; Thu, 11 Mar 2021 18:16:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FF9764E28 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3d9xEn+QSjJooLTqTNjqG9rYGxWwhMV+hBfkR/ErYq8=; b=Goc1sMD7a5T+slaaIFUjvbLQ9 5IGB+Vdy5D43QJVgAKIQENOGCcBGPXz6iB5hf3M2DanMbsFXp5jDuT5plPnoVpxL06r2kJgaVrrqn gSSR29nZhzNY1EhK2xGk4lP/Cubd5S8yuWE6ZEtXronJ6hobZaN13Ers0l/52tZvso5nw9tuI7zHD Te9TxiSGyD+J6WW60ab1IZRfFzfvdV4XVjh2EoS52NnQmR/CZHHyhOlbQZg6RM+P0EP7TSgSTXBTF 5i23V3Ewcss/MFcItkJtQPxNqo+uXrflufEKECjT2I48M/W3yENUXMTCXCH9S+0MsYAdwjTrr9oZG yHugHIKbg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lKPq0-009pH4-U5; Thu, 11 Mar 2021 18:15:09 +0000 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lKPpv-009pFE-Pd for linux-arm-kernel@lists.infradead.org; Thu, 11 Mar 2021 18:15:05 +0000 Received: by mail-pj1-x1030.google.com with SMTP id t18so3863953pjs.3 for ; Thu, 11 Mar 2021 10:15:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dws62jrAOnft9HTIUVBwsXMXaS222scIKagfo6JeNDg=; b=UsrBWEUSmoqSxYXawqPv2K0aIpL1I5euE8CjW7R4lm/gaQts9YOXll57qdHI3QvTAl Halp7lyd4id0oIVJQXTNvkS9FHZBL42kRBYUrKPJChZK+3Xux4Zw7HFIqpzXV8XX1nUs Wxavuf9SJnZYg2BW7vE6x1KJoofSMHEKmiPsh3J6pmTepCOGSmqaOrZUxrKqPEW2C6+k Q+IfTPAOwOnHYkUC/vkgCvV4VkmX3tfcPmuP07WjKYWZJpnxlZdWocIIamomXu+pK9ST 4QsFTy9TSr7zPW3LDdfGHWT83iFpK3AE0rl4vzGEUqFmkplaiIB+MlVxtgJPwkevg/kE Y/Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dws62jrAOnft9HTIUVBwsXMXaS222scIKagfo6JeNDg=; b=BdpS6dUKrKvIQvrsHE9Ne2s0Hw5XsPQEaKW0aFfsjc7gkjrMHown4A5JoyYZTpxCwn MDeddCEwFmZ9J7iN/dOqvLYaJwAUO37l+scUzKwh0OXs273NxZnzLXe4SbygHlAQZYWn QcYptWB7/f1gSvFp75sN3VTwKRm5wgYYe0e4fc44Z9wp/7ypw6s9L92w55dVbtILPpu4 RfgclWrL1kdQ9VKhmYocU7E/AwPVbHRWr3Ev810GCr2upt4NzgO+fDZ4SkilrWbzj7NY ZGarzYsWVE8HKEaiZ6/KiD7kouaxZnCvfn1Mm805R/hROR3LQ2V38vmE4Jvldyq3Mmbf zf0A== X-Gm-Message-State: AOAM532DhF2mTeW/bm3pAqIwtaeZCZsxYAFfhT9qO5lsiYvFQuf2RWkB fxKqYjZjnrORMQeoBE7V2wRoHAHlkIjMnOqEzIo= X-Google-Smtp-Source: ABdhPJwgL0YGRGL55JayrSg2l+lpYdFJjNs7gzsUjCmXydM88Y9NwFBtJ/YU2wE36U0WbNNGMOvQ0Hb1mQsBI0dyCdM= X-Received: by 2002:a17:90a:db49:: with SMTP id u9mr10457516pjx.181.1615486501144; Thu, 11 Mar 2021 10:15:01 -0800 (PST) MIME-Version: 1.0 References: <20210311062011.8054-1-calvin.johnson@oss.nxp.com> <20210311062011.8054-9-calvin.johnson@oss.nxp.com> <20210311180010.GC5031@lsv03152.swis.in-blr01.nxp.com> In-Reply-To: <20210311180010.GC5031@lsv03152.swis.in-blr01.nxp.com> From: Andy Shevchenko Date: Thu, 11 Mar 2021 20:14:44 +0200 Message-ID: Subject: Re: [net-next PATCH v7 08/16] net: mdiobus: Introduce fwnode_mdiobus_register_phy() To: Calvin Johnson Cc: Grant Likely , "Rafael J . Wysocki" , Jeremy Linton , Andrew Lunn , Florian Fainelli , Russell King - ARM Linux admin , Cristi Sovaiala , Florin Laurentiu Chiculita , Ioana Ciornei , Madalin Bucur , Heikki Krogerus , Marcin Wojtas , Pieter Jansen Van Vuuren , Jon , Saravana Kannan , Randy Dunlap , linux-arm Mailing List , Diana Madalina Craciun , ACPI Devel Maling List , Linux Kernel Mailing List , "linux.cj" , netdev , Laurentiu Tudor , "David S. Miller" , Frank Rowand , Heiner Kallweit , Jakub Kicinski , Rob Herring , devicetree X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210311_181503_881857_AEE79F9A X-CRM114-Status: GOOD ( 19.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 11, 2021 at 8:00 PM Calvin Johnson wrote: > On Thu, Mar 11, 2021 at 02:09:37PM +0200, Andy Shevchenko wrote: > > On Thu, Mar 11, 2021 at 8:21 AM Calvin Johnson > > wrote: ... > > > +config FWNODE_MDIO > > > + def_tristate PHYLIB > > > > (Seems "selectable only" item) > > What do you mean by "selectable only" item here? Can you please point to some > other example? The Kconfig sections without descriptions are not user-visible. No user can run menuconfig and check a box with "I want this to be compiled". tristate // selectable-only tristate "bla bla bla" // user visible and selectable > > > + depends on ACPI > > > + depends on OF > > > > Wouldn't be better to have > > depends on (ACPI || OF) || COMPILE_TEST > > > > And honestly I don't understand it in either (AND or OR) variant. Why > > do you need a dependency like this for fwnode API? > > Here, fwnode_mdiobus_register_phy() uses objects from both ACPI and OF. APIs? Calls? What really fails if we have !ACPI and / or !OF? > > Moreover dependencies don't work for "selectable only" items. > > > > > + depends on PHYLIB > > > + select FIXED_PHY -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel