From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Gwendal Grignou <gwendal@chromium.org>,
Gabriele Mazzotta <gabriele.mzt@gmail.com>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio <linux-iio@vger.kernel.org>
Subject: Re: [PATCH v5 3/3] iio: acpi_als: Add trigger support
Date: Tue, 29 Dec 2020 20:13:34 +0200 [thread overview]
Message-ID: <CAHp75VcchW=rK00pQJcYD0-9txYcWVCfqvOs=Q+jNsBgcaNNfQ@mail.gmail.com> (raw)
In-Reply-To: <20201229175202.76682fcc@archlinux>
On Tue, Dec 29, 2020 at 7:52 PM Jonathan Cameron <jic23@kernel.org> wrote:
> On Tue, 29 Dec 2020 19:33:39 +0200
> Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
...
> It's not the same. As stated it's the inverse condition. Could add some brackets
> and a ! or, flip the logic of the whole if condition and not return early.
My bad, you are right.
I think I had something in mind about indentation as well, perhaps a
separate function or so...
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-12-29 18:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 21:41 [PATCH v5 0/3] iio: acpi_als: Add sotfware trigger support Gwendal Grignou
2020-12-16 21:41 ` [PATCH v5 1/3] iio: acpi_als: Add timestamp channel Gwendal Grignou
2020-12-16 22:39 ` Andy Shevchenko
2020-12-16 21:41 ` [PATCH v5 2/3] iio: acpi_als: Add local variable dev in probe Gwendal Grignou
2020-12-16 22:40 ` Andy Shevchenko
2020-12-16 21:41 ` [PATCH v5 3/3] iio: acpi_als: Add trigger support Gwendal Grignou
2020-12-16 22:38 ` Andy Shevchenko
2020-12-29 17:24 ` Jonathan Cameron
2020-12-29 17:33 ` Andy Shevchenko
2020-12-29 17:52 ` Jonathan Cameron
2020-12-29 18:13 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VcchW=rK00pQJcYD0-9txYcWVCfqvOs=Q+jNsBgcaNNfQ@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=gabriele.mzt@gmail.com \
--cc=gwendal@chromium.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.