From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752960AbbKZPWS (ORCPT ); Thu, 26 Nov 2015 10:22:18 -0500 Received: from mail-yk0-f176.google.com ([209.85.160.176]:35104 "EHLO mail-yk0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752056AbbKZPWM (ORCPT ); Thu, 26 Nov 2015 10:22:12 -0500 MIME-Version: 1.0 In-Reply-To: <87vb8tyttv.fsf@rasmusvillemoes.dk> References: <1447259718-19647-1-git-send-email-andriy.shevchenko@linux.intel.com> <1447259718-19647-4-git-send-email-andriy.shevchenko@linux.intel.com> <87twois3or.fsf@rasmusvillemoes.dk> <1448038684.31665.179.camel@linux.intel.com> <87vb8tyttv.fsf@rasmusvillemoes.dk> Date: Thu, 26 Nov 2015 17:22:11 +0200 Message-ID: Subject: Re: [PATCH v1 3/7] test_hexdump: go through all possible lengths of buffer From: Andy Shevchenko To: Rasmus Villemoes Cc: Andy Shevchenko , Andrew Morton , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 23, 2015 at 10:59 AM, Rasmus Villemoes wrote: > On Fri, Nov 20 2015, Andy Shevchenko wrote: > >> On Thu, 2015-11-19 at 11:07 +0100, Rasmus Villemoes wrote: >>> >>> >>> Why keep the variable l when it is just a synonym for the new >>> parameter buflen? It is quite confusing that you change some but not >>> all occurrences of l to buflen. If you want to make the diff minimal >>> but still have a descriptive parameter name, just keep the 'size_t l >>> = >>> buflen;' assignment and don't otherwise refer to buflen. But I think >>> it's better to eliminate 'l' and just change everything to >>> buflen. Don't mix the two approaches, though. >> >> Okay, I got it for the future, though the series is already in linux- >> next, so do we really need to re-hack half of it because of that? > > Stuff in -next isn't set in stone. I'm pretty sure Andrew can replace > one set of patches with another. Thanks for your review. I;m busy currently with some other stuff, you might have noticed, I will return back to the series maybe next week. -- With Best Regards, Andy Shevchenko