All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "yuechao.zhao(赵越超)" <yuechao.zhao@advantech.com.cn>
Cc: "345351830@qq.com" <345351830@qq.com>,
	"Rainbow.Zhang(張玉)" <Rainbow.Zhang@advantech.com.cn>,
	"yunxia.li(李云霞)" <yunxia.li@advantech.com.cn>,
	"pavel@ucw.cz" <pavel@ucw.cz>, "dmurphy@ti.com" <dmurphy@ti.com>,
	"Jia.Sui(贾睢)" <Jia.Sui@advantech.com.cn>,
	"Hans de Goede" <hdegoede@redhat.com>,
	"Mark Gross" <mgross@linux.intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"platform-driver-x86@vger.kernel.org"
	<platform-driver-x86@vger.kernel.org>
Subject: Re: [v3,1/1] adv_mix955x is a scheme that multiplexes PCA9554/PCA9555 into LED and GPIO
Date: Sun, 2 May 2021 13:50:19 +0300	[thread overview]
Message-ID: <CAHp75Vce_-m5uXgpyRO300M1Vw8DX2BmnBPsF5OaUK2_hNDb_A@mail.gmail.com> (raw)
In-Reply-To: <b787cd95ad7746d9a04e8cd7f6c0b645@ACNMB2.ACN.ADVANTECH.CORP>

On Fri, Apr 30, 2021 at 8:27 AM yuechao.zhao(赵越超)
<yuechao.zhao@advantech.com.cn> wrote:
>
> From: Yuechao Zhao <yuechao.zhao@advantech.com.cn>
>
> With this driver, we can multiplex PCA9554/PCA9555 into LED and GPIO
> based on the ACPI data of BIOS.

NAK as per v2.

Please, add a proper documentation and show ACPI excerpt, and last but
not least is missing justification.


-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2021-05-02 10:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <tencent_F8EEB847E2CD8A6813D0BF4863964CDF3508@qq.com>
2021-04-30  5:26 ` [v3,1/1] adv_mix955x is a scheme that multiplexes PCA9554/PCA9555 into LED and GPIO yuechao.zhao(赵越超)
2021-05-02 10:50   ` Andy Shevchenko [this message]
2021-05-03 13:16     ` yuechao.zhao(赵越超)
2021-05-05 13:23       ` Hans de Goede
2021-05-06  8:47         ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHp75Vce_-m5uXgpyRO300M1Vw8DX2BmnBPsF5OaUK2_hNDb_A@mail.gmail.com \
    --to=andy.shevchenko@gmail.com \
    --cc=345351830@qq.com \
    --cc=Jia.Sui@advantech.com.cn \
    --cc=Rainbow.Zhang@advantech.com.cn \
    --cc=dmurphy@ti.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgross@linux.intel.com \
    --cc=pavel@ucw.cz \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=yuechao.zhao@advantech.com.cn \
    --cc=yunxia.li@advantech.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.