From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33418C433B4 for ; Wed, 5 May 2021 09:17:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB7F1613C7 for ; Wed, 5 May 2021 09:17:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231636AbhEEJS2 (ORCPT ); Wed, 5 May 2021 05:18:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229696AbhEEJS2 (ORCPT ); Wed, 5 May 2021 05:18:28 -0400 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D128AC061574; Wed, 5 May 2021 02:17:30 -0700 (PDT) Received: by mail-pl1-x635.google.com with SMTP id e2so778158plh.8; Wed, 05 May 2021 02:17:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=+hdlGV1cUN6NljB1f2reBcd8Q4DpmutRMc4/6Gf8iqI=; b=P3sG7lnDmSPXT3uYXXvYoTUTIKUqeGvsiITgKApsDfTuVzIVm8UEBQD8XQlsDSaVJv Dg9KdKkliWDCbFd65g7X8Ydef+UkFU6tmG1mWrWLcQeVc6S8m8w8cwJ+7FuMJZOFNgBl fd4Jevni6iNb9Px7sdZeI0scw3ANCqwZherMQgYkzIboGvj0w4Zi8ulD3NZN3hX1utDu gFNO2WIQF16Q/N9dqdI3v0QwnjyjGLqRH8o3nZrQziSrC55YHahuVYbwv4OllmEMHVGI Ihkr8GyXoZqa3MXLnWsA1b0pg+liRKsaHpwyWpKUyelxPhpEEKqaHMe5A1mnsOAvrLlk gy3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=+hdlGV1cUN6NljB1f2reBcd8Q4DpmutRMc4/6Gf8iqI=; b=l5lDYAqi90pDRqEY2dx2IxBV4zSrbSXnvoybhmqx8zhwYYth2Oejb4G1G3bjiFQIBf HneSWeQlOCHWmaDRi7vsDa5RVr9tAEDwrSxlWWNSo7kCvyj1x6IDAaRCowpqZmf/aQ4z wlYPf+odnU91Ytp1INfp0UKM3A/kBQCilk9cL1W6C7NaXzvzwbfbweiqbijkv5jv2cS6 YfrjRR9LkTw/wjyK9oCqh1LlHrEWsPGMhifjnHaNqhaCxg7X2eNbPLLakQ9d2lELXFIz LeqtAN3wNzRjiLOzsclf6eDWEsLgm0SJ21M31TGpnnIadeaTZCBnc3tza1jsvvsnbKNs V9qg== X-Gm-Message-State: AOAM532QQrOD1E2c84FZb5ykcq61BviRWolPLmCj1/r7AEn9MuNEDLK2 Ljc4LcVMqpFH8y34v9dFc0qAGi+swxGmfTKxYlVLAlyHBmw= X-Google-Smtp-Source: ABdhPJxrjEyuzY1Uv6PT4uCbsCv1WEw2n5HqFzucR460BX9AZAaLE6eEDP9sSAIcg1VcepGwk/mWxNQ6/srQ85SDJXY= X-Received: by 2002:a17:902:264:b029:eb:3d3a:a09c with SMTP id 91-20020a1709020264b02900eb3d3aa09cmr30516458plc.0.1620206250236; Wed, 05 May 2021 02:17:30 -0700 (PDT) MIME-Version: 1.0 References: <20210503154647.142551-1-hdegoede@redhat.com> <20210503154647.142551-6-hdegoede@redhat.com> In-Reply-To: From: Andy Shevchenko Date: Wed, 5 May 2021 12:17:14 +0300 Message-ID: Subject: Re: [PATCH 5/9] drm/i915: Associate ACPI connector nodes with connector entries To: Hans de Goede , Sakari Ailus Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Daniel Vetter , David Airlie , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Greg Kroah-Hartman , Guenter Roeck , Heikki Krogerus , intel-gfx , "dri-devel@lists.freedesktop.org" , "platform-driver-x86@vger.kernel.org" , "linux-usb@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org On Wed, May 5, 2021 at 12:07 PM Hans de Goede wrote: > On 5/4/21 9:52 AM, Andy Shevchenko wrote: > > On Monday, May 3, 2021, Hans de Goede > wrote: ... > > + fwnode =3D device_get_next_child_node(kdev, fwnode)= ; > > Who is dropping reference counting on fwnode ? > > We are dealing with ACPI fwnode-s here and those are not ref-counted, the= y > are embedded inside a struct acpi_device and their lifetime is tied to > that struct. They should probably still be ref-counted (with the count > never dropping to 0) so that the generic fwnode functions behave the same > anywhere but atm the ACPI nodes are not refcounted, see: acpi_get_next_su= bnode() > in drivers/acpi/property.c which is the get_next_child_node() implementat= ion > for ACPI fwnode-s. Yes, ACPI currently is exceptional, but fwnode API is not. If you may guarantee that this case won't ever be outside of ACPI and even though if ACPI won't ever gain a reference counting for fwnodes, we can leave it as is. > > I=E2=80=99m in the middle of a pile of fixes for fwnode refcounting whe= n for_each_child or get_next_child is used. So, please double check you dro= p a reference. > > The kdoc comments on device_get_next_child_node() / fwnode_get_next_child= _node() > do not mention anything about these functions returning a reference. It's possible. I dunno if it had to be done earlier. Sakari? > So I think we need to first make up our mind here how we want this all to > work and then fix the actual implementation and docs before fixing caller= s. We have already issues, so I prefer not to wait for a documentation update, because for old kernels it will still be an issue. In any case most of my fixes are against LED subsystem (drivers) and they are valid due to use in the OF environment. --=20 With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9D86C433ED for ; Wed, 5 May 2021 09:17:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 47D0F613D6 for ; Wed, 5 May 2021 09:17:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47D0F613D6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A8EE86E0D0; Wed, 5 May 2021 09:17:31 +0000 (UTC) Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by gabe.freedesktop.org (Postfix) with ESMTPS id C9A706E0D0; Wed, 5 May 2021 09:17:30 +0000 (UTC) Received: by mail-pj1-x1030.google.com with SMTP id j6-20020a17090adc86b02900cbfe6f2c96so493344pjv.1; Wed, 05 May 2021 02:17:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=+hdlGV1cUN6NljB1f2reBcd8Q4DpmutRMc4/6Gf8iqI=; b=P3sG7lnDmSPXT3uYXXvYoTUTIKUqeGvsiITgKApsDfTuVzIVm8UEBQD8XQlsDSaVJv Dg9KdKkliWDCbFd65g7X8Ydef+UkFU6tmG1mWrWLcQeVc6S8m8w8cwJ+7FuMJZOFNgBl fd4Jevni6iNb9Px7sdZeI0scw3ANCqwZherMQgYkzIboGvj0w4Zi8ulD3NZN3hX1utDu gFNO2WIQF16Q/N9dqdI3v0QwnjyjGLqRH8o3nZrQziSrC55YHahuVYbwv4OllmEMHVGI Ihkr8GyXoZqa3MXLnWsA1b0pg+liRKsaHpwyWpKUyelxPhpEEKqaHMe5A1mnsOAvrLlk gy3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=+hdlGV1cUN6NljB1f2reBcd8Q4DpmutRMc4/6Gf8iqI=; b=SYW1Aw/GdEfMMclsYTi1hDxEXd2CgXAb21waipywuLz0r4U44/GQ7n3svebTm03/8B TC84rAJP83oznc0t3Vo9N1FXhnBv1onNucKL16jp6OOHEXEBNJNuQDa1dTYkpLXBg1Ae dWsalglBPr0DL9AXSqOsLd3Yc5H9mRJBcQuY5SxClzvQJpeEglYlJuOE2qLCUQ3VQZm+ Lm2YaEDkEVmi3f1aP7R7a7YHYiUIKS1zIWo2r+Bk48aS4SEj+BJVlbnsVTUrY6NEsCNu 5K7g7WY3ppjZTrGSTD7p6f+G/+yDIqhvpIr0tWF/KWKVcCPgFKu5/cL1faVF7Z0BXHbU AFXg== X-Gm-Message-State: AOAM531UJDuvGg28dPgR8/FsZ8ehw5hf/bFWcMztW/bEVvGzaESP9bnS ZQrMb6j4UhpQugX4xj1aDRmPRQSgK71VXqKGkXk= X-Google-Smtp-Source: ABdhPJxrjEyuzY1Uv6PT4uCbsCv1WEw2n5HqFzucR460BX9AZAaLE6eEDP9sSAIcg1VcepGwk/mWxNQ6/srQ85SDJXY= X-Received: by 2002:a17:902:264:b029:eb:3d3a:a09c with SMTP id 91-20020a1709020264b02900eb3d3aa09cmr30516458plc.0.1620206250236; Wed, 05 May 2021 02:17:30 -0700 (PDT) MIME-Version: 1.0 References: <20210503154647.142551-1-hdegoede@redhat.com> <20210503154647.142551-6-hdegoede@redhat.com> In-Reply-To: From: Andy Shevchenko Date: Wed, 5 May 2021 12:17:14 +0300 Message-ID: Subject: Re: [PATCH 5/9] drm/i915: Associate ACPI connector nodes with connector entries To: Hans de Goede , Sakari Ailus X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "dri-devel@lists.freedesktop.org" , Heikki Krogerus , Thomas Zimmermann , David Airlie , Greg Kroah-Hartman , intel-gfx , "platform-driver-x86@vger.kernel.org" , "linux-usb@vger.kernel.org" , Rodrigo Vivi , Guenter Roeck Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gV2VkLCBNYXkgNSwgMjAyMSBhdCAxMjowNyBQTSBIYW5zIGRlIEdvZWRlIDxoZGVnb2VkZUBy ZWRoYXQuY29tPiB3cm90ZToKPiBPbiA1LzQvMjEgOTo1MiBBTSwgQW5keSBTaGV2Y2hlbmtvIHdy b3RlOgo+ID4gT24gTW9uZGF5LCBNYXkgMywgMjAyMSwgSGFucyBkZSBHb2VkZSA8aGRlZ29lZGVA cmVkaGF0LmNvbSA8bWFpbHRvOmhkZWdvZWRlQHJlZGhhdC5jb20+PiB3cm90ZToKCi4uLgoKPiA+ ICAgICArICAgICAgICAgICAgICAgZndub2RlID0gZGV2aWNlX2dldF9uZXh0X2NoaWxkX25vZGUo a2RldiwgZndub2RlKTsKCj4gPiBXaG8gaXMgZHJvcHBpbmcgcmVmZXJlbmNlIGNvdW50aW5nIG9u IGZ3bm9kZSA/Cj4KPiBXZSBhcmUgZGVhbGluZyB3aXRoIEFDUEkgZndub2RlLXMgaGVyZSBhbmQg dGhvc2UgYXJlIG5vdCByZWYtY291bnRlZCwgdGhleQo+IGFyZSBlbWJlZGRlZCBpbnNpZGUgYSBz dHJ1Y3QgYWNwaV9kZXZpY2UgYW5kIHRoZWlyIGxpZmV0aW1lIGlzIHRpZWQgdG8KPiB0aGF0IHN0 cnVjdC4gVGhleSBzaG91bGQgcHJvYmFibHkgc3RpbGwgYmUgcmVmLWNvdW50ZWQgKHdpdGggdGhl IGNvdW50Cj4gbmV2ZXIgZHJvcHBpbmcgdG8gMCkgc28gdGhhdCB0aGUgZ2VuZXJpYyBmd25vZGUg ZnVuY3Rpb25zIGJlaGF2ZSB0aGUgc2FtZQo+IGFueXdoZXJlIGJ1dCBhdG0gdGhlIEFDUEkgbm9k ZXMgYXJlIG5vdCByZWZjb3VudGVkLCBzZWU6IGFjcGlfZ2V0X25leHRfc3Vibm9kZSgpCj4gaW4g ZHJpdmVycy9hY3BpL3Byb3BlcnR5LmMgd2hpY2ggaXMgdGhlIGdldF9uZXh0X2NoaWxkX25vZGUo KSBpbXBsZW1lbnRhdGlvbgo+IGZvciBBQ1BJIGZ3bm9kZS1zLgoKWWVzLCBBQ1BJIGN1cnJlbnRs eSBpcyBleGNlcHRpb25hbCwgYnV0IGZ3bm9kZSBBUEkgaXMgbm90LgpJZiB5b3UgbWF5IGd1YXJh bnRlZSB0aGF0IHRoaXMgY2FzZSB3b24ndCBldmVyIGJlIG91dHNpZGUgb2YgQUNQSSBhbmQKZXZl biB0aG91Z2ggaWYgQUNQSSB3b24ndCBldmVyIGdhaW4gYSByZWZlcmVuY2UgY291bnRpbmcgZm9y IGZ3bm9kZXMsCndlIGNhbiBsZWF2ZSBpdCBhcyBpcy4KCj4gPiBJ4oCZbSBpbiB0aGUgbWlkZGxl IG9mIGEgcGlsZSBvZiBmaXhlcyBmb3IgZndub2RlIHJlZmNvdW50aW5nIHdoZW4gZm9yX2VhY2hf Y2hpbGQgb3IgZ2V0X25leHRfY2hpbGQgaXMgdXNlZC4gU28sIHBsZWFzZSBkb3VibGUgY2hlY2sg eW91IGRyb3AgYSByZWZlcmVuY2UuCj4KPiBUaGUga2RvYyBjb21tZW50cyBvbiBkZXZpY2VfZ2V0 X25leHRfY2hpbGRfbm9kZSgpIC8gZndub2RlX2dldF9uZXh0X2NoaWxkX25vZGUoKQo+IGRvIG5v dCBtZW50aW9uIGFueXRoaW5nIGFib3V0IHRoZXNlIGZ1bmN0aW9ucyByZXR1cm5pbmcgYSByZWZl cmVuY2UuCgpJdCdzIHBvc3NpYmxlLiBJIGR1bm5vIGlmIGl0IGhhZCB0byBiZSBkb25lIGVhcmxp ZXIuIFNha2FyaT8KCj4gU28gSSB0aGluayB3ZSBuZWVkIHRvIGZpcnN0IG1ha2UgdXAgb3VyIG1p bmQgaGVyZSBob3cgd2Ugd2FudCB0aGlzIGFsbCB0bwo+IHdvcmsgYW5kIHRoZW4gZml4IHRoZSBh Y3R1YWwgaW1wbGVtZW50YXRpb24gYW5kIGRvY3MgYmVmb3JlIGZpeGluZyBjYWxsZXJzLgoKV2Ug aGF2ZSBhbHJlYWR5IGlzc3Vlcywgc28gSSBwcmVmZXIgbm90IHRvIHdhaXQgZm9yIGEgZG9jdW1l bnRhdGlvbgp1cGRhdGUsIGJlY2F1c2UgZm9yIG9sZCBrZXJuZWxzIGl0IHdpbGwgc3RpbGwgYmUg YW4gaXNzdWUuCgpJbiBhbnkgY2FzZSBtb3N0IG9mIG15IGZpeGVzIGFyZSBhZ2FpbnN0IExFRCBz dWJzeXN0ZW0gKGRyaXZlcnMpIGFuZAp0aGV5IGFyZSB2YWxpZCBkdWUgdG8gdXNlIGluIHRoZSBP RiBlbnZpcm9ubWVudC4KCi0tIApXaXRoIEJlc3QgUmVnYXJkcywKQW5keSBTaGV2Y2hlbmtvCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F1DBC43461 for ; Wed, 5 May 2021 09:17:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC069613DD for ; Wed, 5 May 2021 09:17:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC069613DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C38896E0E5; Wed, 5 May 2021 09:17:31 +0000 (UTC) Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by gabe.freedesktop.org (Postfix) with ESMTPS id C9A706E0D0; Wed, 5 May 2021 09:17:30 +0000 (UTC) Received: by mail-pj1-x1030.google.com with SMTP id j6-20020a17090adc86b02900cbfe6f2c96so493344pjv.1; Wed, 05 May 2021 02:17:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=+hdlGV1cUN6NljB1f2reBcd8Q4DpmutRMc4/6Gf8iqI=; b=P3sG7lnDmSPXT3uYXXvYoTUTIKUqeGvsiITgKApsDfTuVzIVm8UEBQD8XQlsDSaVJv Dg9KdKkliWDCbFd65g7X8Ydef+UkFU6tmG1mWrWLcQeVc6S8m8w8cwJ+7FuMJZOFNgBl fd4Jevni6iNb9Px7sdZeI0scw3ANCqwZherMQgYkzIboGvj0w4Zi8ulD3NZN3hX1utDu gFNO2WIQF16Q/N9dqdI3v0QwnjyjGLqRH8o3nZrQziSrC55YHahuVYbwv4OllmEMHVGI Ihkr8GyXoZqa3MXLnWsA1b0pg+liRKsaHpwyWpKUyelxPhpEEKqaHMe5A1mnsOAvrLlk gy3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=+hdlGV1cUN6NljB1f2reBcd8Q4DpmutRMc4/6Gf8iqI=; b=SYW1Aw/GdEfMMclsYTi1hDxEXd2CgXAb21waipywuLz0r4U44/GQ7n3svebTm03/8B TC84rAJP83oznc0t3Vo9N1FXhnBv1onNucKL16jp6OOHEXEBNJNuQDa1dTYkpLXBg1Ae dWsalglBPr0DL9AXSqOsLd3Yc5H9mRJBcQuY5SxClzvQJpeEglYlJuOE2qLCUQ3VQZm+ Lm2YaEDkEVmi3f1aP7R7a7YHYiUIKS1zIWo2r+Bk48aS4SEj+BJVlbnsVTUrY6NEsCNu 5K7g7WY3ppjZTrGSTD7p6f+G/+yDIqhvpIr0tWF/KWKVcCPgFKu5/cL1faVF7Z0BXHbU AFXg== X-Gm-Message-State: AOAM531UJDuvGg28dPgR8/FsZ8ehw5hf/bFWcMztW/bEVvGzaESP9bnS ZQrMb6j4UhpQugX4xj1aDRmPRQSgK71VXqKGkXk= X-Google-Smtp-Source: ABdhPJxrjEyuzY1Uv6PT4uCbsCv1WEw2n5HqFzucR460BX9AZAaLE6eEDP9sSAIcg1VcepGwk/mWxNQ6/srQ85SDJXY= X-Received: by 2002:a17:902:264:b029:eb:3d3a:a09c with SMTP id 91-20020a1709020264b02900eb3d3aa09cmr30516458plc.0.1620206250236; Wed, 05 May 2021 02:17:30 -0700 (PDT) MIME-Version: 1.0 References: <20210503154647.142551-1-hdegoede@redhat.com> <20210503154647.142551-6-hdegoede@redhat.com> In-Reply-To: From: Andy Shevchenko Date: Wed, 5 May 2021 12:17:14 +0300 Message-ID: To: Hans de Goede , Sakari Ailus Subject: Re: [Intel-gfx] [PATCH 5/9] drm/i915: Associate ACPI connector nodes with connector entries X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "dri-devel@lists.freedesktop.org" , Heikki Krogerus , Thomas Zimmermann , David Airlie , Greg Kroah-Hartman , intel-gfx , "platform-driver-x86@vger.kernel.org" , "linux-usb@vger.kernel.org" , Maxime Ripard , Guenter Roeck Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gV2VkLCBNYXkgNSwgMjAyMSBhdCAxMjowNyBQTSBIYW5zIGRlIEdvZWRlIDxoZGVnb2VkZUBy ZWRoYXQuY29tPiB3cm90ZToKPiBPbiA1LzQvMjEgOTo1MiBBTSwgQW5keSBTaGV2Y2hlbmtvIHdy b3RlOgo+ID4gT24gTW9uZGF5LCBNYXkgMywgMjAyMSwgSGFucyBkZSBHb2VkZSA8aGRlZ29lZGVA cmVkaGF0LmNvbSA8bWFpbHRvOmhkZWdvZWRlQHJlZGhhdC5jb20+PiB3cm90ZToKCi4uLgoKPiA+ ICAgICArICAgICAgICAgICAgICAgZndub2RlID0gZGV2aWNlX2dldF9uZXh0X2NoaWxkX25vZGUo a2RldiwgZndub2RlKTsKCj4gPiBXaG8gaXMgZHJvcHBpbmcgcmVmZXJlbmNlIGNvdW50aW5nIG9u IGZ3bm9kZSA/Cj4KPiBXZSBhcmUgZGVhbGluZyB3aXRoIEFDUEkgZndub2RlLXMgaGVyZSBhbmQg dGhvc2UgYXJlIG5vdCByZWYtY291bnRlZCwgdGhleQo+IGFyZSBlbWJlZGRlZCBpbnNpZGUgYSBz dHJ1Y3QgYWNwaV9kZXZpY2UgYW5kIHRoZWlyIGxpZmV0aW1lIGlzIHRpZWQgdG8KPiB0aGF0IHN0 cnVjdC4gVGhleSBzaG91bGQgcHJvYmFibHkgc3RpbGwgYmUgcmVmLWNvdW50ZWQgKHdpdGggdGhl IGNvdW50Cj4gbmV2ZXIgZHJvcHBpbmcgdG8gMCkgc28gdGhhdCB0aGUgZ2VuZXJpYyBmd25vZGUg ZnVuY3Rpb25zIGJlaGF2ZSB0aGUgc2FtZQo+IGFueXdoZXJlIGJ1dCBhdG0gdGhlIEFDUEkgbm9k ZXMgYXJlIG5vdCByZWZjb3VudGVkLCBzZWU6IGFjcGlfZ2V0X25leHRfc3Vibm9kZSgpCj4gaW4g ZHJpdmVycy9hY3BpL3Byb3BlcnR5LmMgd2hpY2ggaXMgdGhlIGdldF9uZXh0X2NoaWxkX25vZGUo KSBpbXBsZW1lbnRhdGlvbgo+IGZvciBBQ1BJIGZ3bm9kZS1zLgoKWWVzLCBBQ1BJIGN1cnJlbnRs eSBpcyBleGNlcHRpb25hbCwgYnV0IGZ3bm9kZSBBUEkgaXMgbm90LgpJZiB5b3UgbWF5IGd1YXJh bnRlZSB0aGF0IHRoaXMgY2FzZSB3b24ndCBldmVyIGJlIG91dHNpZGUgb2YgQUNQSSBhbmQKZXZl biB0aG91Z2ggaWYgQUNQSSB3b24ndCBldmVyIGdhaW4gYSByZWZlcmVuY2UgY291bnRpbmcgZm9y IGZ3bm9kZXMsCndlIGNhbiBsZWF2ZSBpdCBhcyBpcy4KCj4gPiBJ4oCZbSBpbiB0aGUgbWlkZGxl IG9mIGEgcGlsZSBvZiBmaXhlcyBmb3IgZndub2RlIHJlZmNvdW50aW5nIHdoZW4gZm9yX2VhY2hf Y2hpbGQgb3IgZ2V0X25leHRfY2hpbGQgaXMgdXNlZC4gU28sIHBsZWFzZSBkb3VibGUgY2hlY2sg eW91IGRyb3AgYSByZWZlcmVuY2UuCj4KPiBUaGUga2RvYyBjb21tZW50cyBvbiBkZXZpY2VfZ2V0 X25leHRfY2hpbGRfbm9kZSgpIC8gZndub2RlX2dldF9uZXh0X2NoaWxkX25vZGUoKQo+IGRvIG5v dCBtZW50aW9uIGFueXRoaW5nIGFib3V0IHRoZXNlIGZ1bmN0aW9ucyByZXR1cm5pbmcgYSByZWZl cmVuY2UuCgpJdCdzIHBvc3NpYmxlLiBJIGR1bm5vIGlmIGl0IGhhZCB0byBiZSBkb25lIGVhcmxp ZXIuIFNha2FyaT8KCj4gU28gSSB0aGluayB3ZSBuZWVkIHRvIGZpcnN0IG1ha2UgdXAgb3VyIG1p bmQgaGVyZSBob3cgd2Ugd2FudCB0aGlzIGFsbCB0bwo+IHdvcmsgYW5kIHRoZW4gZml4IHRoZSBh Y3R1YWwgaW1wbGVtZW50YXRpb24gYW5kIGRvY3MgYmVmb3JlIGZpeGluZyBjYWxsZXJzLgoKV2Ug aGF2ZSBhbHJlYWR5IGlzc3Vlcywgc28gSSBwcmVmZXIgbm90IHRvIHdhaXQgZm9yIGEgZG9jdW1l bnRhdGlvbgp1cGRhdGUsIGJlY2F1c2UgZm9yIG9sZCBrZXJuZWxzIGl0IHdpbGwgc3RpbGwgYmUg YW4gaXNzdWUuCgpJbiBhbnkgY2FzZSBtb3N0IG9mIG15IGZpeGVzIGFyZSBhZ2FpbnN0IExFRCBz dWJzeXN0ZW0gKGRyaXZlcnMpIGFuZAp0aGV5IGFyZSB2YWxpZCBkdWUgdG8gdXNlIGluIHRoZSBP RiBlbnZpcm9ubWVudC4KCi0tIApXaXRoIEJlc3QgUmVnYXJkcywKQW5keSBTaGV2Y2hlbmtvCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=