From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v2 4/6] platform/x86: dell-laptop: import dell_micmute_led_set() from drivers/leds/dell-led.c Date: Wed, 18 Jan 2017 21:12:10 +0200 Message-ID: References: <20170116132204.6421-1-kernel@kempniu.pl> <20170116132204.6421-5-kernel@kempniu.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-qt0-f194.google.com ([209.85.216.194]:34993 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752690AbdARTMQ (ORCPT ); Wed, 18 Jan 2017 14:12:16 -0500 In-Reply-To: <20170116132204.6421-5-kernel@kempniu.pl> Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: =?UTF-8?B?TWljaGHFgiBLxJlwaWXFhA==?= Cc: Richard Purdie , Jacek Anaszewski , Pavel Machek , =?UTF-8?Q?Pali_Roh=C3=A1r?= , Darren Hart , Jaroslav Kysela , Takashi Iwai , Anthony Wong , linux-leds@vger.kernel.org, Platform Driver , ALSA Development Mailing List , "linux-kernel@vger.kernel.org" On Mon, Jan 16, 2017 at 3:22 PM, Micha=C5=82 K=C4=99pie=C5=84 wrote: > To ensure all users of dell-smbios are in drivers/platform/x86, move the > dell_micmute_led_set() method from drivers/leds/dell-led.c to > drivers/platform/x86/dell-laptop.c. > Acked-by: Andy Shevchenko Couple of nitpicks below. > --- a/drivers/platform/x86/dell-laptop.c > +++ b/drivers/platform/x86/dell-laptop.c > @@ -30,6 +30,7 @@ > #include > #include > #include > +#include Perhaps move this one line above > +#define GLOBAL_MIC_MUTE_ENABLE 0x364 > +#define GLOBAL_MIC_MUTE_DISABLE 0x365 Same as Pali told. --=20 With Best Regards, Andy Shevchenko