From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932607AbcBJLOw (ORCPT ); Wed, 10 Feb 2016 06:14:52 -0500 Received: from mail-yw0-f196.google.com ([209.85.161.196]:32936 "EHLO mail-yw0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932266AbcBJLOs (ORCPT ); Wed, 10 Feb 2016 06:14:48 -0500 MIME-Version: 1.0 In-Reply-To: <20160210111125.GD5270@kuha.fi.intel.com> References: <1455037283-106479-1-git-send-email-heikki.krogerus@linux.intel.com> <1455037283-106479-2-git-send-email-heikki.krogerus@linux.intel.com> <1455101342.8878.5.camel@suse.com> <20160210111125.GD5270@kuha.fi.intel.com> Date: Wed, 10 Feb 2016 13:14:47 +0200 Message-ID: Subject: Re: [PATCH 1/3] usb: USB Type-C Connector Class From: Andy Shevchenko To: Heikki Krogerus Cc: Oliver Neukum , Greg KH , Felipe Balbi , Mathias Nyman , "linux-kernel@vger.kernel.org" , USB Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 10, 2016 at 1:11 PM, Heikki Krogerus wrote: > On Wed, Feb 10, 2016 at 01:05:27PM +0200, Andy Shevchenko wrote: >> On Wed, Feb 10, 2016 at 12:49 PM, Oliver Neukum wrote: >> > On Tue, 2016-02-09 at 19:01 +0200, Heikki Krogerus wrote: >> >> The purpose of this class is to provide unified interface >> >> for user space to get the status and basic information about >> >> USB Type-C Connectors in the system, control data role >> >> swapping, and when USB PD is available, also power role >> >> swapping and Altenate Modes. >> >> >> >> The class will export the following interfaces for every >> >> USB Type-C Connector in the system to sysfs: >> >> >> >> 1. connected - Connection status of the connector >> >> 2. alternate_mode - The current Alternate Mode >> >> 3. alternate_modes - Lists all Alternate Modes the connector supports >> > >> > These names are a bit problematic, as they are too similar. >> > How about >> > >> > current_alternate_mode > > That works for me. > >> > potential_alternate_modes >> >> I would vote for supported_* > > How about connector_alternate_modes? Would be fine as well. -- With Best Regards, Andy Shevchenko