From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752028AbcBJOYv (ORCPT <rfc822;w@1wt.eu>);
	Wed, 10 Feb 2016 09:24:51 -0500
Received: from mail-yk0-f196.google.com ([209.85.160.196]:36489 "EHLO
	mail-yk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751481AbcBJOYt (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 10 Feb 2016 09:24:49 -0500
MIME-Version: 1.0
In-Reply-To: <1455113742.8878.14.camel@suse.com>
References: <1455037283-106479-1-git-send-email-heikki.krogerus@linux.intel.com>
	<1455037283-106479-3-git-send-email-heikki.krogerus@linux.intel.com>
	<CAHp75VeUt_uRgxQDxzMw3uoqaRC3TDEyVt1xDSGUicACf4H-_A@mail.gmail.com>
	<1455113742.8878.14.camel@suse.com>
Date: Wed, 10 Feb 2016 16:24:48 +0200
Message-ID: <CAHp75VcuDpUtEKihpu1uAfkVKuf6eOjrt6Y4VwWE0wcYoN3ERQ@mail.gmail.com>
Subject: Re: [PATCH 2/3] usb: type-c: USB Type-C Connector System Software Interface
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Oliver Neukum <oneukum@suse.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Felipe Balbi <balbi@kernel.org>,
        Mathias Nyman <mathias.nyman@linux.intel.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        USB <linux-usb@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Feb 10, 2016 at 4:15 PM, Oliver Neukum <oneukum@suse.com> wrote:
> On Wed, 2016-02-10 at 13:56 +0200, Andy Shevchenko wrote:
>> > +err:
>> > +       if (i > 0)
>> > +               for (; i >= 0; i--, con--)
>> > +                       typec_unregister_port(con->port);
>>
>> Perhaps
>>
>> while (--i >= 0) {
>>  ...
>> }
>
> While we are at it. No we should not change the semantics
> of conditionals for the sake of appearance.

I'm sorry I didn't get you.
How this more or less standard pattern to clean up stuff on error path
does with conditional semantics?

I also noticed that this code might be factored out to helper which
will do same things (only number of loops is different) in both cases.
What did I miss?

-- 
With Best Regards,
Andy Shevchenko