From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Kent Gibson <warthog618@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: gpiolib: why does gpio_set_bias() suppress ENOTSUPP?
Date: Mon, 4 Apr 2022 12:23:18 +0300 [thread overview]
Message-ID: <CAHp75VcuM2qZjZCkcZ01u=KSqyudMJTB8meORpZ0hxA4_PFg8A@mail.gmail.com> (raw)
In-Reply-To: <90f7d9eb-935b-3803-1531-65bd20418bc3@redhat.com>
On Sun, Apr 3, 2022 at 6:34 PM Hans de Goede <hdegoede@redhat.com> wrote:
> On 4/2/22 03:45, Kent Gibson wrote:
> > On Fri, Apr 01, 2022 at 12:36:57PM +0200, Hans de Goede wrote:
...
> > Probably best to extend the uAPI to add a strict mode and leave
> > existing usage unchanged.
>
> Agreed, adding a strict mode to the uAPI seems best.
>
> And if you do it this way, you should probably also make
> the kernel log (using a ratelimited log function) why (e.g.
> bias setting not supported) the call is failing since errno is
> not going to tell the user enough here I think.
...which reminds me this one: https://lwn.net/Articles/657341/
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-04-04 9:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 2:52 gpiolib: why does gpio_set_bias() suppress ENOTSUPP? Kent Gibson
2022-03-31 13:53 ` Andy Shevchenko
2022-03-31 14:15 ` Kent Gibson
2022-03-31 17:19 ` Andy Shevchenko
2022-04-01 0:08 ` Kent Gibson
2022-04-01 10:42 ` Andy Shevchenko
2022-04-02 1:45 ` Kent Gibson
2022-04-01 10:36 ` Hans de Goede
2022-04-02 1:45 ` Kent Gibson
2022-04-02 9:11 ` Hans de Goede
2022-04-04 9:23 ` Andy Shevchenko [this message]
2022-04-04 10:06 ` Kent Gibson
2022-04-04 10:16 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VcuM2qZjZCkcZ01u=KSqyudMJTB8meORpZ0hxA4_PFg8A@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=hdegoede@redhat.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.