From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CDA3C433FE for ; Sat, 25 Dec 2021 17:49:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232605AbhLYRtZ (ORCPT ); Sat, 25 Dec 2021 12:49:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229488AbhLYRtY (ORCPT ); Sat, 25 Dec 2021 12:49:24 -0500 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62653C061401; Sat, 25 Dec 2021 09:49:24 -0800 (PST) Received: by mail-ed1-x534.google.com with SMTP id f5so44802321edq.6; Sat, 25 Dec 2021 09:49:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gM3VpFGbnRlsUdu/qU43co/kdMZXZwIKIYTPggeA3/c=; b=Zpo3jRJagdt8cSZ6tuYV2LzBTh56FD1vaWBUSZWUqabX40Qh+y+LXphzIMClqKQH/k UVu8CKKTXXrAe9fgGF6well70V7ogypPUERe0BxoqJUoQxqlxWH5FLCRrerjp/rZN4Rl DB1/eM2SKhzgFsn0QQFyCzgM1nP1YCgY77aBkZWe/TPbpjLlLwIVb9fIMTUwMRK6ii3x cQ7INo8bvLJL8883EJsfO5FjDx7ugbkfAQdDiNgssiEL/6q9dUNeAQBDFPpU5vunZ7dH 21qJK1jG63sqHhW7M+Poyd5o2LVx4vo88G90JrdblJdEvTDT/jVuspP50qtBf6+devqF 3zNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gM3VpFGbnRlsUdu/qU43co/kdMZXZwIKIYTPggeA3/c=; b=dJ0e1qCATKDhJG7wLDefixEqIbyAWMdHWwZa/AOhJyH+aHkWJJ/AolsxkeQ+j00CEN su2SB/7E8kD7bCup+Lc1vZlbCBMkpoqpnpmeaGT+NtDskQTJ5ylD4Dtz4c/kdj78Mm9C MvqcB3IRMSom2J2ewOKTLUDxsjWFKyaC4bcmyNYo4bMdDToxNXC1Jg0PFuaC6C+C/iVW 1E2APClTnPX5mgsZHw2ZraL7gFtwURmll1dsydKpVodzXpLjJDjShR70kI9Yrxg5KBPH 1LwP4Grr34mjw4T/duu4oHgDkXdVLPfODRzQ6M8jWBBZY1PBpdFbx7r7zygpR4eixGVR LB/g== X-Gm-Message-State: AOAM532sCtZ9RIs18n5c7VcQNw9xayA8if2nxXEupoxyv4bHixKAkciE SGffGTDjDuU8ZnaLVA5mJ53bHdoWiwyFBgzBql4= X-Google-Smtp-Source: ABdhPJy7x6W89zkrinOTPZz0lb4PsAdSjaFqF/BP/cBoCZYOiEv0gzK46jeBYq8/j34jt1lO3eHUQNERWm9JkeR+YFc= X-Received: by 2002:a05:6402:2693:: with SMTP id w19mr9901452edd.158.1640454562884; Sat, 25 Dec 2021 09:49:22 -0800 (PST) MIME-Version: 1.0 References: <20211221175322.7096-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20211221175322.7096-3-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: <20211221175322.7096-3-prabhakar.mahadev-lad.rj@bp.renesas.com> From: Andy Shevchenko Date: Sat, 25 Dec 2021 19:48:46 +0200 Message-ID: Subject: Re: [PATCH v2 2/3] i2c: sh_mobile: Use platform_get_irq_optional() to get the interrupt To: Lad Prabhakar Cc: Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list , Nicolas Saenz Julienne , Chris Brandt , Wolfram Sang , linux-i2c , linux-rpi-kernel , linux-arm Mailing List , Linux-Renesas , Linux Kernel Mailing List , Prabhakarprabhakar.csengg@gmail.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 22, 2021 at 2:41 PM Lad Prabhakar wrote: > > platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static > allocation of IRQ resources in DT core code, this causes an issue > when using hierarchical interrupt domains using "interrupts" property > in the node as this bypasses the hierarchical setup and messes up the > irq chaining. > > In preparation for removal of static setup of IRQ resource from DT core > code use platform_get_irq_optional() for DT users only. ... > + if (np) { Same comments as per your other patches, i.e. Why is this check here? > + int irq; > + > + while ((irq = platform_get_irq_optional(dev, k)) != -ENXIO) { Consider 0 as no IRQ. > + if (irq < 0) > + return irq; > + ret = devm_request_irq(&dev->dev, irq, sh_mobile_i2c_isr, > + 0, dev_name(&dev->dev), pd); > if (ret) { > - dev_err(&dev->dev, "cannot request IRQ %pa\n", &n); > + dev_err(&dev->dev, "cannot request IRQ %d\n", irq); > return ret; > } > + k++; > + }; > + } else { > + struct resource *res; > + resource_size_t n; > + > + while ((res = platform_get_resource(dev, IORESOURCE_IRQ, k))) { > + for (n = res->start; n <= res->end; n++) { > + ret = devm_request_irq(&dev->dev, n, sh_mobile_i2c_isr, > + 0, dev_name(&dev->dev), pd); > + if (ret) { > + dev_err(&dev->dev, "cannot request IRQ %pa\n", &n); > + return ret; > + } > + } > + k++; > } > - k++; > } -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3FB4CC433F5 for ; Sat, 25 Dec 2021 17:50:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hnZsoB92x99XO9VCbgdB44pcRiX5exF8SjAgA2od0aM=; b=DxsGqJVo9JdgBM i5N++cPmOufzI3AUjVXzh/JGuwWgC0dwXQvWvRLsKOcLPCo1ls1hA1B4zsZbMasg+5jHwgZDv1KA8 V6Pvaa4jTqwUL5bTtFJh6aAH9boM6/3/l0RbWDBHXoT8iw8loIz5kQ3Zb4sAODtR37s4b06tyttdQ fhJF4pGpvha4iKU7Hm5F8InGDwgwHmv/8r+vKBJ1NBJcBcSXguk7cfZdyRmWVxSEKBZmeUhbwE2YF 6vW9fXWjpVJN6txos1XVlt8rIyPt60PJGDNvnWPcuIkyZznzpnnTKuS+oOpU7czlxVorK1Yuqoivg 6upEj1hTmQ2g8iyisqEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n1BAd-00F1pG-8E; Sat, 25 Dec 2021 17:49:27 +0000 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n1BAa-00F1oV-EN; Sat, 25 Dec 2021 17:49:25 +0000 Received: by mail-ed1-x52a.google.com with SMTP id y22so44921651edq.2; Sat, 25 Dec 2021 09:49:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gM3VpFGbnRlsUdu/qU43co/kdMZXZwIKIYTPggeA3/c=; b=Zpo3jRJagdt8cSZ6tuYV2LzBTh56FD1vaWBUSZWUqabX40Qh+y+LXphzIMClqKQH/k UVu8CKKTXXrAe9fgGF6well70V7ogypPUERe0BxoqJUoQxqlxWH5FLCRrerjp/rZN4Rl DB1/eM2SKhzgFsn0QQFyCzgM1nP1YCgY77aBkZWe/TPbpjLlLwIVb9fIMTUwMRK6ii3x cQ7INo8bvLJL8883EJsfO5FjDx7ugbkfAQdDiNgssiEL/6q9dUNeAQBDFPpU5vunZ7dH 21qJK1jG63sqHhW7M+Poyd5o2LVx4vo88G90JrdblJdEvTDT/jVuspP50qtBf6+devqF 3zNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gM3VpFGbnRlsUdu/qU43co/kdMZXZwIKIYTPggeA3/c=; b=OHuL0Tizc5V54Oi8abnZELXati50tytZ/d97ZSDyTL9zNmMM8xDvzgnfsEkh2R2l5W 3n/EN1AKschY0hE5f211dDr2gEfQs1ziuBA0tNvEJ3RN90CCESfGxB3z9+12lS7SWyyf QUDcwkymZh9WzsWsfCOd07fIc6wp8s1AJhDhE/CPvKrZzwgtGF6dgv1U3JyxuJzRgmKp GAMjKLrxes7q1N07RmQQ7GBudWg/ti6FlaQGEm09M/RGulLWN59iOrT//Gtkxany/elK DHqOLJsbs7BrpJyYOGtRbqoK/uqtx8IfkfL8pxSckCJaccbWkeY96OMoKpJ3L8SMvDC0 HH8w== X-Gm-Message-State: AOAM533qncCNpCKpyUHpbBaiZYYsm5A25k0U9C2lYHLlJkIQDqP5g3fR vRjNnUEEOthEsDbQtE1ca/Y7trVkdNpqNuv+S50= X-Google-Smtp-Source: ABdhPJy7x6W89zkrinOTPZz0lb4PsAdSjaFqF/BP/cBoCZYOiEv0gzK46jeBYq8/j34jt1lO3eHUQNERWm9JkeR+YFc= X-Received: by 2002:a05:6402:2693:: with SMTP id w19mr9901452edd.158.1640454562884; Sat, 25 Dec 2021 09:49:22 -0800 (PST) MIME-Version: 1.0 References: <20211221175322.7096-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20211221175322.7096-3-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: <20211221175322.7096-3-prabhakar.mahadev-lad.rj@bp.renesas.com> From: Andy Shevchenko Date: Sat, 25 Dec 2021 19:48:46 +0200 Message-ID: Subject: Re: [PATCH v2 2/3] i2c: sh_mobile: Use platform_get_irq_optional() to get the interrupt To: Lad Prabhakar Cc: Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list , Nicolas Saenz Julienne , Chris Brandt , Wolfram Sang , linux-i2c , linux-rpi-kernel , linux-arm Mailing List , Linux-Renesas , Linux Kernel Mailing List , Prabhakarprabhakar.csengg@gmail.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211225_094924_506436_0AD49D53 X-CRM114-Status: GOOD ( 14.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 22, 2021 at 2:41 PM Lad Prabhakar wrote: > > platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static > allocation of IRQ resources in DT core code, this causes an issue > when using hierarchical interrupt domains using "interrupts" property > in the node as this bypasses the hierarchical setup and messes up the > irq chaining. > > In preparation for removal of static setup of IRQ resource from DT core > code use platform_get_irq_optional() for DT users only. ... > + if (np) { Same comments as per your other patches, i.e. Why is this check here? > + int irq; > + > + while ((irq = platform_get_irq_optional(dev, k)) != -ENXIO) { Consider 0 as no IRQ. > + if (irq < 0) > + return irq; > + ret = devm_request_irq(&dev->dev, irq, sh_mobile_i2c_isr, > + 0, dev_name(&dev->dev), pd); > if (ret) { > - dev_err(&dev->dev, "cannot request IRQ %pa\n", &n); > + dev_err(&dev->dev, "cannot request IRQ %d\n", irq); > return ret; > } > + k++; > + }; > + } else { > + struct resource *res; > + resource_size_t n; > + > + while ((res = platform_get_resource(dev, IORESOURCE_IRQ, k))) { > + for (n = res->start; n <= res->end; n++) { > + ret = devm_request_irq(&dev->dev, n, sh_mobile_i2c_isr, > + 0, dev_name(&dev->dev), pd); > + if (ret) { > + dev_err(&dev->dev, "cannot request IRQ %pa\n", &n); > + return ret; > + } > + } > + k++; > } > - k++; > } -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel