From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5F6BC433E1 for ; Fri, 29 May 2020 12:04:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4504207F5 for ; Fri, 29 May 2020 12:04:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ID4REpDk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726549AbgE2MED (ORCPT ); Fri, 29 May 2020 08:04:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725775AbgE2MEC (ORCPT ); Fri, 29 May 2020 08:04:02 -0400 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82F32C03E969; Fri, 29 May 2020 05:04:02 -0700 (PDT) Received: by mail-pg1-x542.google.com with SMTP id c75so1413885pga.3; Fri, 29 May 2020 05:04:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Mnz73Vl3a4PfmC0Z2phyqbZVdHEOz6JLhDTMxB2wsIM=; b=ID4REpDkr7y96phQaJslv9etO7e56tB1Fvs2pQVFThbt3OWxnE9cd6GOB4rfNCZKy9 SwmDBqEJwZh4h1516wBaUfJ5W0ErSpigoJo+K36t1tPn3Y1NrFHpmHJb5tCMcudzMvyv TEgH2Mm0Tvj974phEVKJVRrjUnKCpqIQm9Z8bW5wIzbYafwg6tnpmNTemy8Uvw0guST4 Wv4LD8tAAcArg51qh6JzClmSlR2Qemwv5raR/846IhRnK84BKN6fnbwcKWf4h8uf2H9q QxvInPyaI7jXvmtBaIeEZ6vUxQv8eXDeKzto41yIYFuVP30P/tA6/MaBD+7fhmmGXVvz Fykg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Mnz73Vl3a4PfmC0Z2phyqbZVdHEOz6JLhDTMxB2wsIM=; b=Ok9Kf0XXaYLgyVk9nWpfl/Yal6oy3ZkQl0oFB5LO2pdM+vVd21gWMBJdqQILL9ky2l 1KhvGnPisXC42klf3Z8mOhev92TGjrzkPwD8mlz7Gt2UgCaFCyOKjWaNHwN4kI/Gk7Q1 X5Srwmq9krHAC5H43nqpQw1CuUfQgSI4BKVnF8X7Azosv6hEj9WPXQ9DRM0wWUcMKCQA F601hP2IeB0i7hoZhEde9DccTnKD4mm20xPuI7/yA6o14XsQRetOb7vBLsovF5CElz1L +UisuHggskjwg4paV/6njCd+XDViQlehW17fmRkgoNsW5GkIlRYJzHSEYccSfkR2JXg8 N0hg== X-Gm-Message-State: AOAM532EEBY48aQwRlVjOUcuBlvEaO1F52ICRh4hjk6v3hbV6jsvwoqc +B2dpxIPPt/EwGprI1nAqLvkuqheltv6cY52d+0= X-Google-Smtp-Source: ABdhPJy3uKd3F67NcorbaDRpeFbpdAHqLp9X6qgyjdspi41F2UUGxJniR9HNoYQ1KudpdkBhWYdPVejNGSthnAiDc3A= X-Received: by 2002:a63:545a:: with SMTP id e26mr7868665pgm.4.1590753841885; Fri, 29 May 2020 05:04:01 -0700 (PDT) MIME-Version: 1.0 References: <89f6393934fc6d493f8b9e87c1a6e916642b6a18.1590749143.git.cristian.ciocaltea@gmail.com> <20200529113419.GA1631227@kroah.com> <4c40d6c1-47e8-b4ec-f2fd-e9767b03630c@suse.de> In-Reply-To: <4c40d6c1-47e8-b4ec-f2fd-e9767b03630c@suse.de> From: Andy Shevchenko Date: Fri, 29 May 2020 15:03:50 +0300 Message-ID: Subject: Re: [PATCH 1/1] tty: serial: owl: Initialize lock before registering port To: =?UTF-8?Q?Andreas_F=C3=A4rber?= Cc: Greg Kroah-Hartman , Cristian Ciocaltea , Manivannan Sadhasivam , Jiri Slaby , Andy Shevchenko , "open list:SERIAL DRIVERS" , linux-arm Mailing List , Linux Kernel Mailing List , linux-actions@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 29, 2020 at 2:56 PM Andreas F=C3=A4rber wrot= e: > > Am 29.05.20 um 13:34 schrieb Greg Kroah-Hartman: > > On Fri, May 29, 2020 at 02:06:47PM +0300, Cristian Ciocaltea wrote: > >> Running a lockdep-enabled kernel leads to the following splat when > >> probing the owl-uart driver: ... > >> Fixes: a3cb39d258ef ("serial: core: Allow detach and attach serial dev= ice for console") > >> Signed-off-by: Cristian Ciocaltea > >> + spin_lock_init(&owl_port->port.lock); > >> + > >> ret =3D uart_add_one_port(&owl_uart_driver, &owl_port->port); > >> if (ret) > >> owl_uart_ports[pdev->id] =3D NULL; > > > > Ugh, another one :( > > > > Thanks for this, will queue this up now. > > Thanks. If this is the expected pattern now, I'll also have to update > in-flight patches, such as Sunplus. Expected is to register properly console via register_console() call. If you do so, you also need to initialize spin lock before coming to uart_add_one_port(). It seems drivers (ab)used that feature. $ git grep -n -w register_console -- drivers/tty/serial/ | cut -f1 -d: | sort -u | wc -l 37 $ git grep -n _CONSOLE -- drivers/tty/serial/ | cut -f1 -d: | sort -u | wc= -l 77 But as a quick fix this initialization is okay. --=20 With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15555C433DF for ; Fri, 29 May 2020 12:04:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B6780207F5 for ; Fri, 29 May 2020 12:04:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lRIz7CAA"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ID4REpDk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B6780207F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2NRSP4RZh92V/0i0uSlmX69XpvJ1wjEePFzkEETvsGw=; b=lRIz7CAALNCyKP eW0Zt5AeC3n/xpZ13uUCUcw+01PUvsh8JX4grTeJ7+Jwf/d+J+41MyCQlPLArJhEt/fO2EVQv9/1x s++HfzAR06Q/S4gK2quLqOFUvIUe1fOECaHJBzEJdxyVQHeDc7a7PWPxufwT7BLrzfWc0tFPsiCXl Qx7UWbB/o61BKZng4aCwP/p2pAhusNwmzlIZncwKO3HIB3V8gFRSzY7jvG/lKEf/ldz1AVSdEJL2t OrphlLxXuoviguxPrBktQkGO+PmdQ/JgljuLFukBfvJD8mbKiaW5X44DfNfo0JXUL9c+M4H9xcQqh 0pQQCmQNtLzht3L2vVNQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jedk5-0002ov-MA; Fri, 29 May 2020 12:04:05 +0000 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jedk2-0002oU-QJ; Fri, 29 May 2020 12:04:04 +0000 Received: by mail-pg1-x544.google.com with SMTP id p21so1391276pgm.13; Fri, 29 May 2020 05:04:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Mnz73Vl3a4PfmC0Z2phyqbZVdHEOz6JLhDTMxB2wsIM=; b=ID4REpDkr7y96phQaJslv9etO7e56tB1Fvs2pQVFThbt3OWxnE9cd6GOB4rfNCZKy9 SwmDBqEJwZh4h1516wBaUfJ5W0ErSpigoJo+K36t1tPn3Y1NrFHpmHJb5tCMcudzMvyv TEgH2Mm0Tvj974phEVKJVRrjUnKCpqIQm9Z8bW5wIzbYafwg6tnpmNTemy8Uvw0guST4 Wv4LD8tAAcArg51qh6JzClmSlR2Qemwv5raR/846IhRnK84BKN6fnbwcKWf4h8uf2H9q QxvInPyaI7jXvmtBaIeEZ6vUxQv8eXDeKzto41yIYFuVP30P/tA6/MaBD+7fhmmGXVvz Fykg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Mnz73Vl3a4PfmC0Z2phyqbZVdHEOz6JLhDTMxB2wsIM=; b=WcQZmJNao21FYKjLqgjeIrJLKHF8wolu9V+rkxGLuA7AQ/lIIEpsBwIzMXgeKi9qt8 PvzsNnugvUbTcYc6C0GEeqcq8c9vTP3yWxMEu5WCqQ34aLVsPzLD70WU89o92rr+Xj/J pQ7UnJOk3hFs5wTczeClfciwkJ4oLE1TjegEVEIO8h6TpfYV/IOcAv65uaj8AfVBplWP M3ZlAxPN/V2TNCRgejN/Ix/j7sLRt0MKf+s3zveMqg6+KI++LMW8sZOdUTL0sORWjqwG AAOKqNgMF3bxDAIi0XRYjQyzCwgk+E1DmIYhAE4pmPUhZEmwehXJL8fuullABzaFxFOd 0JOg== X-Gm-Message-State: AOAM531Iz59cOkbF6/wV/OgJ3tObMGQt+Y7WZ8VFVUE1p2AoRcer+M5d k/G3nqEkLdGaQS/8YRawCRmdAgorTOPP1pNINvQ= X-Google-Smtp-Source: ABdhPJy3uKd3F67NcorbaDRpeFbpdAHqLp9X6qgyjdspi41F2UUGxJniR9HNoYQ1KudpdkBhWYdPVejNGSthnAiDc3A= X-Received: by 2002:a63:545a:: with SMTP id e26mr7868665pgm.4.1590753841885; Fri, 29 May 2020 05:04:01 -0700 (PDT) MIME-Version: 1.0 References: <89f6393934fc6d493f8b9e87c1a6e916642b6a18.1590749143.git.cristian.ciocaltea@gmail.com> <20200529113419.GA1631227@kroah.com> <4c40d6c1-47e8-b4ec-f2fd-e9767b03630c@suse.de> In-Reply-To: <4c40d6c1-47e8-b4ec-f2fd-e9767b03630c@suse.de> From: Andy Shevchenko Date: Fri, 29 May 2020 15:03:50 +0300 Message-ID: Subject: Re: [PATCH 1/1] tty: serial: owl: Initialize lock before registering port To: =?UTF-8?Q?Andreas_F=C3=A4rber?= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200529_050402_864076_71833372 X-CRM114-Status: GOOD ( 12.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Manivannan Sadhasivam , linux-actions@lists.infradead.org, Linux Kernel Mailing List , Cristian Ciocaltea , "open list:SERIAL DRIVERS" , Jiri Slaby , Andy Shevchenko , linux-arm Mailing List Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBNYXkgMjksIDIwMjAgYXQgMjo1NiBQTSBBbmRyZWFzIEbDpHJiZXIgPGFmYWVyYmVy QHN1c2UuZGU+IHdyb3RlOgo+Cj4gQW0gMjkuMDUuMjAgdW0gMTM6MzQgc2NocmllYiBHcmVnIEty b2FoLUhhcnRtYW46Cj4gPiBPbiBGcmksIE1heSAyOSwgMjAyMCBhdCAwMjowNjo0N1BNICswMzAw LCBDcmlzdGlhbiBDaW9jYWx0ZWEgd3JvdGU6Cj4gPj4gUnVubmluZyBhIGxvY2tkZXAtZW5hYmxl ZCBrZXJuZWwgbGVhZHMgdG8gdGhlIGZvbGxvd2luZyBzcGxhdCB3aGVuCj4gPj4gcHJvYmluZyB0 aGUgb3dsLXVhcnQgZHJpdmVyOgoKLi4uCgo+ID4+IEZpeGVzOiBhM2NiMzlkMjU4ZWYgKCJzZXJp YWw6IGNvcmU6IEFsbG93IGRldGFjaCBhbmQgYXR0YWNoIHNlcmlhbCBkZXZpY2UgZm9yIGNvbnNv bGUiKQo+ID4+IFNpZ25lZC1vZmYtYnk6IENyaXN0aWFuIENpb2NhbHRlYSA8Y3Jpc3RpYW4uY2lv Y2FsdGVhQGdtYWlsLmNvbT4KCj4gPj4gKyAgICBzcGluX2xvY2tfaW5pdCgmb3dsX3BvcnQtPnBv cnQubG9jayk7Cj4gPj4gKwo+ID4+ICAgICAgcmV0ID0gdWFydF9hZGRfb25lX3BvcnQoJm93bF91 YXJ0X2RyaXZlciwgJm93bF9wb3J0LT5wb3J0KTsKPiA+PiAgICAgIGlmIChyZXQpCj4gPj4gICAg ICAgICAgICAgIG93bF91YXJ0X3BvcnRzW3BkZXYtPmlkXSA9IE5VTEw7Cj4gPgo+ID4gVWdoLCBh bm90aGVyIG9uZSA6KAo+ID4KPiA+IFRoYW5rcyBmb3IgdGhpcywgd2lsbCBxdWV1ZSB0aGlzIHVw IG5vdy4KPgo+IFRoYW5rcy4gSWYgdGhpcyBpcyB0aGUgZXhwZWN0ZWQgcGF0dGVybiBub3csIEkn bGwgYWxzbyBoYXZlIHRvIHVwZGF0ZQo+IGluLWZsaWdodCBwYXRjaGVzLCBzdWNoIGFzIFN1bnBs dXMuCgpFeHBlY3RlZCBpcyB0byByZWdpc3RlciBwcm9wZXJseSBjb25zb2xlIHZpYSByZWdpc3Rl cl9jb25zb2xlKCkgY2FsbC4KSWYgeW91IGRvIHNvLCB5b3UgYWxzbyBuZWVkIHRvIGluaXRpYWxp emUgc3BpbiBsb2NrIGJlZm9yZSBjb21pbmcgdG8KdWFydF9hZGRfb25lX3BvcnQoKS4KSXQgc2Vl bXMgZHJpdmVycyAoYWIpdXNlZCB0aGF0IGZlYXR1cmUuCgokIGdpdCBncmVwIC1uIC13IHJlZ2lz dGVyX2NvbnNvbGUgLS0gZHJpdmVycy90dHkvc2VyaWFsLyB8IGN1dCAtZjEgLWQ6Cnwgc29ydCAt dSB8IHdjIC1sCiAgICAzNwokIGdpdCBncmVwIC1uIF9DT05TT0xFIC0tIGRyaXZlcnMvdHR5L3Nl cmlhbC8gfCBjdXQgLWYxIC1kOiAgfCBzb3J0IC11IHwgd2MgLWwKICAgIDc3CgpCdXQgYXMgYSBx dWljayBmaXggdGhpcyBpbml0aWFsaXphdGlvbiBpcyBva2F5LgoKLS0gCldpdGggQmVzdCBSZWdh cmRzLApBbmR5IFNoZXZjaGVua28KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJu ZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK