From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61DA8C433EF for ; Thu, 10 Feb 2022 11:15:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240685AbiBJLPB (ORCPT ); Thu, 10 Feb 2022 06:15:01 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:48734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240674AbiBJLO7 (ORCPT ); Thu, 10 Feb 2022 06:14:59 -0500 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29F68CCA; Thu, 10 Feb 2022 03:15:01 -0800 (PST) Received: by mail-ed1-x52a.google.com with SMTP id cz16so10231302edb.8; Thu, 10 Feb 2022 03:15:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=86WvMXZHLjkGbiJZp5ccobLzsZbB0pdZcrhUodCwW5E=; b=jbBWNeFpcaENFcXzIP+FtT16BHbVbBhNZ8K2JjRHALDwTKGfZd94WmyMuhUTeSVcyt t4TfJ4Ql6XAQ86Wy9jqNgMthktqHp8XwXmcrCUp2OMVrjjs7y9coNUd/tursxZzXQ1Cv t81NxiWRlVc1q6CIxQzv0DWYtfjlT9ATbIfXX57rjYiGEAx2NHTYoB5Kkqs+QEjwAC6N Cs/VMcgAcGHZnIToTNwxG/3ro+MnwBd5aw+55RhGytRlEmGamtSnTtGMi9lQPb89EI4U NrBj3LwMyti1KEPBaBLta2RaUHPUkcYy6CBLKyrTQgN6WRTx0ewpxkuqGxFlh/5vpGVe 5TfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=86WvMXZHLjkGbiJZp5ccobLzsZbB0pdZcrhUodCwW5E=; b=LFxt/krCB59yni4XRTq3yE20uRoeXmS0MLevpH740S7C+WtJecynZdIEZt5tvb/gn6 nEqN9tvQ7gHVu5JrPc8/nk58dpuqrNu7VWKt2Ncj7RMI14sv44q/lFawhEvBiH3ERUJS wUWcXs984sBhzURYUvuxdUPag/fblGA7ZUMd9UP+NOEFIzoQplha803bVq41N0zJPMuw lh1uCR4v5QKwo7SGSFTDgJuVKoF0t9VdrHaCnZ22b9dO1Rga6jQaLFQeqVzCOw7gtbEK b9O7fK/lJhDWws5+L9Uh5z+a/i/aMfjAdBxrIaXyU6DWI6reT70Zza/4480N6Xzn/Puw TYyw== X-Gm-Message-State: AOAM533zvqVQ2t2cC0XW6N1j0rUXiOzoGYUTwu6Vw4dsOlFPZZNaZV11 MAZKzukCkuNS4bfM/Nv0OaDVtRY1d7hlHpIQR8c= X-Google-Smtp-Source: ABdhPJwt4DzuSAvUl6+QCoPSNRZVDryR+G7Pk+UnooBQRefAASpZeECFwgpI2N0KRWI9tN4IO2kRQIA5cNfNs1sDIhs= X-Received: by 2002:aa7:c413:: with SMTP id j19mr7838615edq.200.1644491699638; Thu, 10 Feb 2022 03:14:59 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andy Shevchenko Date: Thu, 10 Feb 2022 13:13:28 +0200 Message-ID: Subject: Re: [PATCH v2] serial: 8259_aspeed_vuart: replace snprintf with sysfs_emit To: davidcomponentone@gmail.com Cc: Greg Kroah-Hartman , Jiri Slaby , Joel Stanley , Andrew Jeffery , Zev Weiss , Johan Hovold , Yang Guang , "open list:SERIAL DRIVERS" , linux-arm Mailing List , "moderated list:ARM/ASPEED MACHINE SUPPORT" , Linux Kernel Mailing List , Zeal Robot Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 10, 2022 at 12:54 PM wrote: > > From: Yang Guang > > coccinelle report: > ./drivers/tty/serial/8250/8250_aspeed_vuart.c:85:8-16: > WARNING: use scnprintf or sprintf > ./drivers/tty/serial/8250/8250_aspeed_vuart.c:174:8-16: > WARNING: use scnprintf or sprintf > ./drivers/tty/serial/8250/8250_aspeed_vuart.c:127:8-16: > WARNING: use scnprintf or sprintf > > Use sysfs_emit instead of scnprintf or sprintf makes more sense. sysfs_emit() scnprintf() sprintf() ... > CC: David Yang > - Use the CC for patch sender This is incorrect. The submitter must have (the last) SoB tag. Question was about authorship just to be clear. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3C8DC433EF for ; Thu, 10 Feb 2022 11:16:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rNWBG6F4sU92kGKjK0+ABmunICmPJSkmtLYigD1AEF4=; b=pMt6mTSX3F+alN 0lUc8qae4NARbDVRt0BWUDPQrVKKpFlfdbc5OllwZ9x3SU7Du0W2+0/2BWtSMhQvum6ITHWPpCuus O+4t44SWnvMYMgX1nG+TF/GxtES+PpzGRGd6cq9+aSbS3TCQpVaVx5LxQChHoMQmJco8UJAndghtG CExtWCi9xx4dKBseQKi/B+9/mHcZQRI/aZN4bE6II6gHgsZpGNlVJm+lp42ZxJCY7yt7vwDqdUlp2 rrgPmCX7BvB6DvuInEdbh5jTdaO+gVl/VlCeMNryFvb3SL/EHI3acxufoggQLUvaQ1FHGWhR77/l4 /lNYqS5t49NQdW06TsIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nI7Pl-003YB0-3E; Thu, 10 Feb 2022 11:15:05 +0000 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nI7Ph-003YA4-J5 for linux-arm-kernel@lists.infradead.org; Thu, 10 Feb 2022 11:15:02 +0000 Received: by mail-ed1-x52d.google.com with SMTP id s7so10334381edd.3 for ; Thu, 10 Feb 2022 03:15:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=86WvMXZHLjkGbiJZp5ccobLzsZbB0pdZcrhUodCwW5E=; b=jbBWNeFpcaENFcXzIP+FtT16BHbVbBhNZ8K2JjRHALDwTKGfZd94WmyMuhUTeSVcyt t4TfJ4Ql6XAQ86Wy9jqNgMthktqHp8XwXmcrCUp2OMVrjjs7y9coNUd/tursxZzXQ1Cv t81NxiWRlVc1q6CIxQzv0DWYtfjlT9ATbIfXX57rjYiGEAx2NHTYoB5Kkqs+QEjwAC6N Cs/VMcgAcGHZnIToTNwxG/3ro+MnwBd5aw+55RhGytRlEmGamtSnTtGMi9lQPb89EI4U NrBj3LwMyti1KEPBaBLta2RaUHPUkcYy6CBLKyrTQgN6WRTx0ewpxkuqGxFlh/5vpGVe 5TfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=86WvMXZHLjkGbiJZp5ccobLzsZbB0pdZcrhUodCwW5E=; b=7OboUX/Gy8Rhnz3XxeNPB4w8uLkPTN6B4Ba+uobD8izyp4lTk9cpxFYPdRQlJkU64Y RnNHzUhGnVFlAwZfAqopmL9dfX/B0fQjMVewNTpi/4wXF2+m5BWbcUo6hwMV/bc0NrEu rbSkULbYwoQy1sQ+aQlAkS5AgvHlOE9dTjGuGybgxlH3pnEuTMchD+vNdY96zBjhdKNb 7Snv00jaH5YCiVdFl/L1hIfVa0g0HMTQx8oKaYPlh2wGZg0bdKH4n5ERLmazpz0kCjp1 pcSXjW04eDBqUyXhYQGAAXuWTgX458216lCUzm7xKYkpNnWp7xOavA3wuVeKJTMwQDgv BD4A== X-Gm-Message-State: AOAM533tLrQr/wNf9Tys4nd9I2rucDrH60d08YM9X4aZImp/2JzcSWSn wNZ1t0HzPTETRcOe7o32jcospuIkESTY8T9LzVc= X-Google-Smtp-Source: ABdhPJwt4DzuSAvUl6+QCoPSNRZVDryR+G7Pk+UnooBQRefAASpZeECFwgpI2N0KRWI9tN4IO2kRQIA5cNfNs1sDIhs= X-Received: by 2002:aa7:c413:: with SMTP id j19mr7838615edq.200.1644491699638; Thu, 10 Feb 2022 03:14:59 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andy Shevchenko Date: Thu, 10 Feb 2022 13:13:28 +0200 Message-ID: Subject: Re: [PATCH v2] serial: 8259_aspeed_vuart: replace snprintf with sysfs_emit To: davidcomponentone@gmail.com Cc: Greg Kroah-Hartman , Jiri Slaby , Joel Stanley , Andrew Jeffery , Zev Weiss , Johan Hovold , Yang Guang , "open list:SERIAL DRIVERS" , linux-arm Mailing List , "moderated list:ARM/ASPEED MACHINE SUPPORT" , Linux Kernel Mailing List , Zeal Robot X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220210_031501_653129_79363F3B X-CRM114-Status: GOOD ( 11.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 10, 2022 at 12:54 PM wrote: > > From: Yang Guang > > coccinelle report: > ./drivers/tty/serial/8250/8250_aspeed_vuart.c:85:8-16: > WARNING: use scnprintf or sprintf > ./drivers/tty/serial/8250/8250_aspeed_vuart.c:174:8-16: > WARNING: use scnprintf or sprintf > ./drivers/tty/serial/8250/8250_aspeed_vuart.c:127:8-16: > WARNING: use scnprintf or sprintf > > Use sysfs_emit instead of scnprintf or sprintf makes more sense. sysfs_emit() scnprintf() sprintf() ... > CC: David Yang > - Use the CC for patch sender This is incorrect. The submitter must have (the last) SoB tag. Question was about authorship just to be clear. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel