From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751500AbeAZRW4 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 26 Jan 2018 12:22:56 -0500
Received: from mail-qt0-f179.google.com ([209.85.216.179]:45510 "EHLO
        mail-qt0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750959AbeAZRWz (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 26 Jan 2018 12:22:55 -0500
X-Google-Smtp-Source: AH8x2262tLv+3MsUKAyV9guapDS2hmWDoG3O/FYvFjk1X1eSs85iJToL1wWUPStuJJ3yT1laXKYYrtJk7pmxNrOYaHM=
MIME-Version: 1.0
In-Reply-To: <20180119161103.15035-2-jolsa@kernel.org>
References: <20180119161103.15035-1-jolsa@kernel.org> <20180119161103.15035-2-jolsa@kernel.org>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Fri, 26 Jan 2018 19:22:53 +0200
Message-ID: <CAHp75Vd7A8JdTR_oiKrG5VOabkMKNRiD4c560DRqRzZn=oDPGA@mail.gmail.com>
Subject: Re: [PATCH 1/2] tools lib symbol: Use strtoul instead of hex2u64 in kallsyms__parse
To: Jiri Olsa <jolsa@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>, David Ahern <dsahern@gmail.com>,
        Andi Kleen <ak@linux.intel.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 19, 2018 at 6:11 PM, Jiri Olsa <jolsa@kernel.org> wrote:
> Current kallsyms__parse uses hex2u64, which gives
> no indication of error. Using strtoul to checkup
> on failed attempt to parse the number and stop the
> rest of the kallsyms__parse processing early.

> +               start = strtoul(line, &endptr, 16);
> +               if (line == endptr)
> +                       continue;
> +
> +               len = endptr - line + 1;
>
> -               len++;
>                 if (len + 2 >= line_len)
>                         continue;

https://patchwork.kernel.org/patch/4087681/


-- 
With Best Regards,
Andy Shevchenko