From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Markuss Broks <markuss.broks@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 1/3] leds: ktd2692: Avoid duplicate error messages on probe deferral
Date: Sun, 8 May 2022 11:55:31 +0200 [thread overview]
Message-ID: <CAHp75Vd=iD4QO2SV5h_P4GowVEy4Afk4nVyLezVa4w2u4jKybA@mail.gmail.com> (raw)
In-Reply-To: <20220507211402.GD11004@duo.ucw.cz>
On Sat, May 7, 2022 at 11:14 PM Pavel Machek <pavel@ucw.cz> wrote:
>
> Hi!
>
> > > Use dev_err_probe instead of dev_err to avoid duplicate error
> > > messages if the GPIO allocation makes the probe defer.
> >
> > Thanks!
> >
> > There are two improvements we can make here.
> > 1) adding a Fixes tag, so it can be backported to stable kernels;
> > 2) see below.
>
> I don't believe this is severe-enough error to be worth stable.
Fixes tag is good to have in either case, but I agree that is not so critical.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-05-08 9:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 15:25 [PATCH v8 0/2] Make AUX gpio pin optional for ktd2692 Markuss Broks
2022-05-05 15:25 ` [PATCH v8 1/3] leds: ktd2692: Avoid duplicate error messages on probe deferral Markuss Broks
2022-05-05 17:29 ` Andy Shevchenko
2022-05-05 17:34 ` Andy Shevchenko
2022-05-07 21:14 ` Pavel Machek
2022-05-08 9:55 ` Andy Shevchenko [this message]
2022-05-05 15:25 ` [PATCH v8 2/3] dt-bindings: leds: convert ktd2692 bindings to yaml Markuss Broks
2022-05-05 15:25 ` [PATCH v8 3/3] leds: ktd2692: Make aux-gpios optional Markuss Broks
2022-05-07 21:13 ` [PATCH v8 0/2] Make AUX gpio pin optional for ktd2692 Pavel Machek
2022-05-06 5:44 [PATCH v8 1/3] leds: ktd2692: Avoid duplicate error messages on probe deferral kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vd=iD4QO2SV5h_P4GowVEy4Afk4nVyLezVa4w2u4jKybA@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=markuss.broks@gmail.com \
--cc=pavel@ucw.cz \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.