From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87F70C43333 for ; Fri, 20 Mar 2020 14:58:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4761820777 for ; Fri, 20 Mar 2020 14:58:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eDQwtq1z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727002AbgCTO6s (ORCPT ); Fri, 20 Mar 2020 10:58:48 -0400 Received: from mail-pj1-f68.google.com ([209.85.216.68]:38564 "EHLO mail-pj1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726144AbgCTO6s (ORCPT ); Fri, 20 Mar 2020 10:58:48 -0400 Received: by mail-pj1-f68.google.com with SMTP id m15so2563662pje.3; Fri, 20 Mar 2020 07:58:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=x0CYiHRmjAbhtOwx0x1mf5Pz7QynYzQVMMGgwVVNtoU=; b=eDQwtq1zQtOLd13ST3FOE7Sk2oulpHAzFYSjgwUoCzQ5WXHo9DAhlrJaeQIaykrd+D RplqyKdtZ/hBD2YanBGphKOaQw6ZGvbr0itJPAkcQv55q1L6wgeyumguRo6p+04KrtfS cuICJ881I+mOiFh+XhbFOLVUzh47gmQCawWmusNQ5h3rTXlwTQzV6jyF+TjbqNAuBBh4 uOiRkmD2pufS8fD21xLXacQlf3uZ5k7XnWVnqm3MfyCs52uigESXh8xdmxrTEGhKK6nZ tdFZiB/kjTQl6dQHrucJG+0TR0zyhbbEFUdK76SQDWixZFCkUUWBTTTTzYOJdhdCS1D3 aweg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x0CYiHRmjAbhtOwx0x1mf5Pz7QynYzQVMMGgwVVNtoU=; b=reG2UAJbZYVr+fAX61hc6JUMV6nO4l4XWNsn5FvCQomTxzQK589//RJ9gU4N+tcgid ThJgvuo3x4WknXD1T715yHf2CdBHoJ4Ma8PXhzXOZLl0ihOPuSYE/E2rD6H8resTqoHT c+uJw+0wSs6HQlcERZl/3wrweUyua3Dta7HRFJ/xBAErWTKiUoAvcS9orpGCC0vjhlhq IhpivcrYrMk6ZLDYQnW4j63Uo3fQOiniAq/8RDf/SJoZiYrKkx/eu/MiJxRX/YO4b90F p4UWKDTO+ECLOdkgFDHr26jNeGljTkkmOql0uOwaNj6lL20xodI1mi2Z7sUVibabBpPh BtRg== X-Gm-Message-State: ANhLgQ3he0nB0LArE0DUb6tHd3Ufcy4WgcQUrMppJ7Cqyyhf+LRzAaYc MmfYINoFUXqllgFBMZbSBZVdxCtdxelc+UPqPrY= X-Google-Smtp-Source: ADFU+vteYsnR7L5XY9pl14RxIG6UQ4TH7+FGZCql5w8AqUCpZZGK/AtSNu9A6VkE0ZiE9rOAuclYQjce/FWRjxLrLDc= X-Received: by 2002:a17:902:54f:: with SMTP id 73mr8686783plf.255.1584716325841; Fri, 20 Mar 2020 07:58:45 -0700 (PDT) MIME-Version: 1.0 References: <20200320131345.635023594@linutronix.de> <20200320131510.594671507@linutronix.de> In-Reply-To: <20200320131510.594671507@linutronix.de> From: Andy Shevchenko Date: Fri, 20 Mar 2020 16:58:38 +0200 Message-ID: Subject: Re: [patch 19/22] ASoC: Intel: Convert to new X86 CPU match macros To: Thomas Gleixner Cc: LKML , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Greg Kroah-Hartman , Mark Gross , Tony Luck , Takashi Iwai , ALSA Development Mailing List , Paolo Bonzini , Darren Hart , Andy Shevchenko , "Rafael J. Wysocki" , Len Brown , ACPI Devel Maling List , Viresh Kumar , Linux PM , Srinivas Pandruvada , linux-edac@vger.kernel.org, Platform Driver , Jean Delvare , Guenter Roeck , linux-hwmon@vger.kernel.org, Zhang Rui , Daniel Lezcano , Amit Kucheria , Chanwoo Choi , Jacob Pan , Adrian Hunter , Ulf Hansson , linux-mmc , Bjorn Helgaas , linux-pci@vger.kernel.org, Herbert Xu , "David S. Miller" , linux-crypto Content-Type: text/plain; charset="UTF-8" Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On Fri, Mar 20, 2020 at 3:18 PM Thomas Gleixner wrote: > > The new macro set has a consistent namespace and uses C99 initializers > instead of the grufty C89 ones. > > Get rid the of the local macro wrappers for consistency. > -#define ICPU(model) { X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, } > - > #define SOC_INTEL_IS_CPU(soc, type) \ > static inline bool soc_intel_is_##soc(void) \ > { \ > static const struct x86_cpu_id soc##_cpu_ids[] = { \ > - ICPU(type), \ > + X86_MATCH_INTEL_FAM6_MODEL(type, NULL), \ > {} \ > }; \ > const struct x86_cpu_id *id; \ > @@ -32,11 +30,11 @@ static inline bool soc_intel_is_##soc(vo > return false; \ > } > > +SOC_INTEL_IS_CPU(byt, ATOM_SILVERMONT); > +SOC_INTEL_IS_CPU(cht, ATOM_AIRMONT); > +SOC_INTEL_IS_CPU(apl, ATOM_GOLDMONT); > +SOC_INTEL_IS_CPU(glk, ATOM_GOLDMONT_PLUS); > +SOC_INTEL_IS_CPU(cml, KABYLAKE_L); I'm wondering if driver data can be used in one macro to distinguish which CPU we are run on. Takashi, what do you think? -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [patch 19/22] ASoC: Intel: Convert to new X86 CPU match macros Date: Fri, 20 Mar 2020 16:58:38 +0200 Message-ID: References: <20200320131345.635023594@linutronix.de> <20200320131510.594671507@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20200320131510.594671507@linutronix.de> Sender: linux-acpi-owner@vger.kernel.org To: Thomas Gleixner Cc: LKML , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Greg Kroah-Hartman , Mark Gross , Tony Luck , Takashi Iwai , ALSA Development Mailing List , Paolo Bonzini , Darren Hart , Andy Shevchenko , "Rafael J. Wysocki" , Len Brown , ACPI Devel Maling List , Viresh Kumar , Linux PM , Srinivas Pandruvada , linux-edac@vger.kernel.org, Platform Driver List-Id: platform-driver-x86.vger.kernel.org On Fri, Mar 20, 2020 at 3:18 PM Thomas Gleixner wrote: > > The new macro set has a consistent namespace and uses C99 initializers > instead of the grufty C89 ones. > > Get rid the of the local macro wrappers for consistency. > -#define ICPU(model) { X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, } > - > #define SOC_INTEL_IS_CPU(soc, type) \ > static inline bool soc_intel_is_##soc(void) \ > { \ > static const struct x86_cpu_id soc##_cpu_ids[] = { \ > - ICPU(type), \ > + X86_MATCH_INTEL_FAM6_MODEL(type, NULL), \ > {} \ > }; \ > const struct x86_cpu_id *id; \ > @@ -32,11 +30,11 @@ static inline bool soc_intel_is_##soc(vo > return false; \ > } > > +SOC_INTEL_IS_CPU(byt, ATOM_SILVERMONT); > +SOC_INTEL_IS_CPU(cht, ATOM_AIRMONT); > +SOC_INTEL_IS_CPU(apl, ATOM_GOLDMONT); > +SOC_INTEL_IS_CPU(glk, ATOM_GOLDMONT_PLUS); > +SOC_INTEL_IS_CPU(cml, KABYLAKE_L); I'm wondering if driver data can be used in one macro to distinguish which CPU we are run on. Takashi, what do you think? -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B949BC4332B for ; Mon, 23 Mar 2020 13:53:29 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4851F2072D for ; Mon, 23 Mar 2020 13:53:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="g10L35OW"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eDQwtq1z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4851F2072D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 88A811654; Mon, 23 Mar 2020 14:52:37 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 88A811654 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1584971607; bh=QCZgPhjNN5F7O9GyDR0nFEeqOj8OYONZ+eQTj5mfITQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=g10L35OWOkW3PtCXKxgYERHAYbQ/nsSDoyw3mBPp3w9wlI3x7lTtEgq0bPRZ47bXW gzM6oKMdvfZusa6R/qZIIgG+Gl5Ni0Ge1lK5zQZwoTZ/BizQ3SxVBZt0wkQgHykXEG aYzwTk+qo0p0e5V9WNaGsJ4ujDQflgX7QNqsNvIA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 97424F802D2; Mon, 23 Mar 2020 14:47:47 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2976CF8015B; Fri, 20 Mar 2020 15:58:56 +0100 (CET) Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6F7D1F800C0 for ; Fri, 20 Mar 2020 15:58:47 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6F7D1F800C0 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eDQwtq1z" Received: by mail-pj1-x1044.google.com with SMTP id l36so2576260pjb.3 for ; Fri, 20 Mar 2020 07:58:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=x0CYiHRmjAbhtOwx0x1mf5Pz7QynYzQVMMGgwVVNtoU=; b=eDQwtq1zQtOLd13ST3FOE7Sk2oulpHAzFYSjgwUoCzQ5WXHo9DAhlrJaeQIaykrd+D RplqyKdtZ/hBD2YanBGphKOaQw6ZGvbr0itJPAkcQv55q1L6wgeyumguRo6p+04KrtfS cuICJ881I+mOiFh+XhbFOLVUzh47gmQCawWmusNQ5h3rTXlwTQzV6jyF+TjbqNAuBBh4 uOiRkmD2pufS8fD21xLXacQlf3uZ5k7XnWVnqm3MfyCs52uigESXh8xdmxrTEGhKK6nZ tdFZiB/kjTQl6dQHrucJG+0TR0zyhbbEFUdK76SQDWixZFCkUUWBTTTTzYOJdhdCS1D3 aweg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x0CYiHRmjAbhtOwx0x1mf5Pz7QynYzQVMMGgwVVNtoU=; b=fwNzY6oC9w8hHnv5PgPFxSobx8+QLt4aNX3vVbxEvtCuydowrUFgDSl0rRKxkGLa9H vgxpEO5W3xppb/h37lzf5nj7SaH8SppsCb2YxOh39ug4XMIJFOwRcZQRVO1ebQ2D1noi yC4SFrB1hctYIZ69hcwzvCoCQCRQidAuuOCmeFIBzYFejn3qbU00DcEE8mCnlTEiI+Kj 5MWHPpniB4NTzxpjtkM3z9rBeLBgWJFQi9G/Z0Tmxcm8JbM24DDvxn9YkpNY25RB0SdB qWV9TWv9bdxU82QuBZjNOT0hgzRaAgSi/0mOxak8Pid0L2hazRZV9mm/4gIMkrnIvW6s AUhQ== X-Gm-Message-State: ANhLgQ05mTkymp7oHKezk7XnHvJ0MXOj3tdmPOHyo9oFc9Dru1WdBCNU cpNgrjpSSXY1N027Z3fDaq9jGd3YcVAETB1hgtM= X-Google-Smtp-Source: ADFU+vteYsnR7L5XY9pl14RxIG6UQ4TH7+FGZCql5w8AqUCpZZGK/AtSNu9A6VkE0ZiE9rOAuclYQjce/FWRjxLrLDc= X-Received: by 2002:a17:902:54f:: with SMTP id 73mr8686783plf.255.1584716325841; Fri, 20 Mar 2020 07:58:45 -0700 (PDT) MIME-Version: 1.0 References: <20200320131345.635023594@linutronix.de> <20200320131510.594671507@linutronix.de> In-Reply-To: <20200320131510.594671507@linutronix.de> From: Andy Shevchenko Date: Fri, 20 Mar 2020 16:58:38 +0200 Message-ID: Subject: Re: [patch 19/22] ASoC: Intel: Convert to new X86 CPU match macros To: Thomas Gleixner Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Mon, 23 Mar 2020 14:47:37 +0100 Cc: ALSA Development Mailing List , Daniel Lezcano , Viresh Kumar , Ulf Hansson , Platform Driver , Jacob Pan , Srinivas Pandruvada , Amit Kucheria , Mark Gross , Herbert Xu , Chanwoo Choi , "maintainer:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)" , ACPI Devel Maling List , linux-pci@vger.kernel.org, Darren Hart , Zhang Rui , Guenter Roeck , Len Brown , Jean Delvare , Linux PM , linux-mmc , Bjorn Helgaas , Adrian Hunter , linux-edac@vger.kernel.org, linux-hwmon@vger.kernel.org, Tony Luck , Greg Kroah-Hartman , "Rafael J. Wysocki" , Takashi Iwai , LKML , linux-crypto , Paolo Bonzini , "David S. Miller" , Andy Shevchenko X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, Mar 20, 2020 at 3:18 PM Thomas Gleixner wrote: > > The new macro set has a consistent namespace and uses C99 initializers > instead of the grufty C89 ones. > > Get rid the of the local macro wrappers for consistency. > -#define ICPU(model) { X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, } > - > #define SOC_INTEL_IS_CPU(soc, type) \ > static inline bool soc_intel_is_##soc(void) \ > { \ > static const struct x86_cpu_id soc##_cpu_ids[] = { \ > - ICPU(type), \ > + X86_MATCH_INTEL_FAM6_MODEL(type, NULL), \ > {} \ > }; \ > const struct x86_cpu_id *id; \ > @@ -32,11 +30,11 @@ static inline bool soc_intel_is_##soc(vo > return false; \ > } > > +SOC_INTEL_IS_CPU(byt, ATOM_SILVERMONT); > +SOC_INTEL_IS_CPU(cht, ATOM_AIRMONT); > +SOC_INTEL_IS_CPU(apl, ATOM_GOLDMONT); > +SOC_INTEL_IS_CPU(glk, ATOM_GOLDMONT_PLUS); > +SOC_INTEL_IS_CPU(cml, KABYLAKE_L); I'm wondering if driver data can be used in one macro to distinguish which CPU we are run on. Takashi, what do you think? -- With Best Regards, Andy Shevchenko