From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7813EB64DA for ; Fri, 30 Jun 2023 13:58:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232314AbjF3N6c (ORCPT ); Fri, 30 Jun 2023 09:58:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230455AbjF3N6b (ORCPT ); Fri, 30 Jun 2023 09:58:31 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 761F92118; Fri, 30 Jun 2023 06:58:30 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-4f973035d60so3145381e87.3; Fri, 30 Jun 2023 06:58:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688133509; x=1690725509; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=4xr+BE0ly7fBWXnqMsQwKwm70dkU7KbNm8LkIP3WhyM=; b=DSnREMF0t6Qc7HldDaPdQWNjEWBUF0ZyO7+NRR3Hs8PS2c1wPLX1eQt3TDJbT9P8za F5m24a0iEUnzZCkjef1CKSsb2xbHA1WMlF4Tff745ZVVy8ZYFKgFpJbmKxy1B9fOTVvr mHaKpIB9kmXj9r3cL/+3CxfnG7ULRhkLmw2F3VIK9wmAxzrxaLjZemAoVzDIyywttHTM uD41WlyfLtla6iyh/DmSKJF28vYz7ExSyfN5KfhGDvg6icsJ7V/aJ4cEmvgyxFje1vrS PD4ArxjMxCeaEHFudtDZIJFe7vVv4MIj0tP7L7yMkwI4j/tcYwX1wqX20JmYnGrHTS2R 2gcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688133509; x=1690725509; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4xr+BE0ly7fBWXnqMsQwKwm70dkU7KbNm8LkIP3WhyM=; b=ATLkdSFP7yeotWcpHA5hNRYMPYslR/bC8inT0Ph81VybDa4flR/IytRK5WXinrTlSu qZ7gurXZBaUlcaGVK7GtV0uzNIGGoy1yxMhtHrPcKLovYIWhPx7bA0vTXIDa0wDYPsx9 +38lRcpFpcXUzHB54CAuWcvaL3PeXNqFToEu+Tf0V1XJ0YULqEgrHJ9mTleDUTip6f3e rYcFjDuHQf0EbgzP/t/yT7Bni54xXCkEd5iUW9zIIhMJBjyPhVlrvp6niLSG9h8sm2Rg pcHxLYLtsD+5GfsjXC6L8+cJFbPKSEdYKc+LrAQz3DZzVFvPLjBYJ6ivXbPY9qmxZR5L 7A7Q== X-Gm-Message-State: ABy/qLb1bibASA2IIlRIle62F4glL8gzatdo2ZMqeYYpdg9gjj5BVRZA Icx8vnMB11+yIB2EtxH1nURFgd+1wPIlw/5/jyi4HNUOG8Y39Q== X-Google-Smtp-Source: APBJJlErxfH7dl9dMd59h8X+td0bzEYk+tOW/ORTtUeuHdVs108TJTdPx/yccjEiXV37/2wbet3pMQvjmdD8LKPYXAA= X-Received: by 2002:a05:6512:285:b0:4fb:82d8:994f with SMTP id j5-20020a056512028500b004fb82d8994fmr2224306lfp.33.1688133508366; Fri, 30 Jun 2023 06:58:28 -0700 (PDT) MIME-Version: 1.0 References: <20230621174943.30302-1-andriy.shevchenko@linux.intel.com> <20230621174943.30302-5-andriy.shevchenko@linux.intel.com> In-Reply-To: From: Andy Shevchenko Date: Fri, 30 Jun 2023 16:57:52 +0300 Message-ID: Subject: Re: [PATCH v1 5/5] gpiolib: Replace open coded gpiochip_irqchip_add_allocated_domain() To: Linus Walleij Cc: Andy Shevchenko , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski , Andy Shevchenko Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Fri, Jun 30, 2023 at 2:52=E2=80=AFPM Linus Walleij wrote: > > On Wed, Jun 21, 2023 at 7:49=E2=80=AFPM Andy Shevchenko > wrote: > > > Replace open coded variant of gpiochip_irqchip_add_allocated_domain() > > in gpiochip_add_irqchip(). > > > > Signed-off-by: Andy Shevchenko > > and this concludes patches 4,5 very nicely as well. Yep! > Reviewed-by: Linus Walleij Thank you for the review! While at it, I would like to ask on ->to_irq() callback. IIUC assigning it with an IRQ chip makes a dead code in the driver. Am I correct? If not, can somebody shed some light on how the RT5677 driver, for example, works with GPIO IRQ? --=20 With Best Regards, Andy Shevchenko