Re: [PATCH] leds: lm3692x: Return 0 from remove callback

From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Pavel Machek <pavel@ucw.cz>,
	Linux LED Subsystem <linux-leds@vger.kernel.org>,
	Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [PATCH] leds: lm3692x: Return 0 from remove callback
Date: Mon, 7 Feb 2022 17:23:40 +0200	[thread overview]
Message-ID: <CAHp75VdHjN94JXsfdF+K-zG2RL_mtZov3aB+4wdQKO8BRKBhgQ@mail.gmail.com> (raw)
In-Reply-To: <20220206220812.21471-1-u.kleine-koenig@pengutronix.de>

On Mon, Feb 7, 2022 at 5:08 PM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
>
> The only difference between returning zero or a non-zero value is that
> for the non-zero case the i2c will print a generic error message
> ("remove failed (-ESOMETHING), will be ignored").
>
> In this case however the driver itself already emitted a more helpful
> error message, so the additional error message isn't helpful at all.
>
> The long-term goal is to make the i2c remove callback return void, making
> all implementations return 0 is preparatory work for this change.

...

> +       lm3692x_leds_disable(led);

Since it emits a message, perhaps converting it to void also can be
done here. Otherwise what's the point to have it int?

-- 
With Best Regards,
Andy Shevchenko