From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: nick.hawkins@hpe.com
Cc: verdun@hpe.com, linus.walleij@linaro.org, brgl@bgdev.pl,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
jdelvare@suse.com, linux@roeck-us.net,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v4 1/5] gpio: gxp: Add HPE GXP GPIO
Date: Thu, 22 Jun 2023 17:15:43 +0300 [thread overview]
Message-ID: <CAHp75VdJjeMwHt31tKeiVLbS36aGmhDgGowT951UVwkxr2_VXQ@mail.gmail.com> (raw)
In-Reply-To: <20230621213115.113266-2-nick.hawkins@hpe.com>
On Thu, Jun 22, 2023 at 12:35 AM <nick.hawkins@hpe.com> wrote:
>
> From: Nick Hawkins <nick.hawkins@hpe.com>
>
> The GXP SoC supports GPIO on multiple interfaces. The interfaces are
> CPLD and Host. The GPIOs is a combination of both physical and virtual
GPIOs are
> I/O across the interfaces. The gpio-gxp driver specifically covers the
> CSM(physical), FN2(virtual), and VUHC(virtual) which are the host. The
"...are the host"?! hosts?
> driver supports interrupts from the host.
I will have some comments against the code, but I will try to review
it probably later on (next week or so). Taking into account the
approaching release date, I think we have a couple more months for
polishing this series.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-06-22 14:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 21:31 [PATCH v4 0/5] ARM: Add GPIO support nick.hawkins
2023-06-21 21:31 ` [PATCH v4 1/5] gpio: gxp: Add HPE GXP GPIO nick.hawkins
2023-06-22 14:15 ` Andy Shevchenko [this message]
2023-06-27 13:36 ` Andy Shevchenko
2023-06-27 18:55 ` Hawkins, Nick
2023-06-21 21:31 ` [PATCH v4 2/5] gpio: gxp: Add HPE GXP GPIO PL nick.hawkins
2023-06-22 7:02 ` Linus Walleij
2023-06-21 21:31 ` [PATCH v4 3/5] dt-bindings: hwmon: hpe,gxp-fan-ctrl: remove fn2 and pl registers nick.hawkins
2023-06-21 21:31 ` [PATCH v4 4/5] hwmon: (gxp_fan_ctrl) Provide fan info via gpio nick.hawkins
2023-06-21 21:31 ` [PATCH v4 5/5] MAINTAINERS: hpe: Add GPIO nick.hawkins
2023-06-22 7:13 ` [PATCH v4 0/5] ARM: Add GPIO support Linus Walleij
2023-07-03 15:31 ` Hawkins, Nick
2023-07-03 22:19 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VdJjeMwHt31tKeiVLbS36aGmhDgGowT951UVwkxr2_VXQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nick.hawkins@hpe.com \
--cc=robh+dt@kernel.org \
--cc=verdun@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.