From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A373C352B6 for ; Mon, 13 Apr 2020 20:01:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A7FF20656 for ; Mon, 13 Apr 2020 20:01:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PJwMvVoX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388199AbgDMUB4 (ORCPT ); Mon, 13 Apr 2020 16:01:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2388135AbgDMUBz (ORCPT ); Mon, 13 Apr 2020 16:01:55 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4A92C0A3BDC; Mon, 13 Apr 2020 13:01:54 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id d17so4963584pgo.0; Mon, 13 Apr 2020 13:01:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=J3cCNpgRJA9avR4kz32VesjN9UmFQ5b6+1OU9lUWCYU=; b=PJwMvVoXHoh4ZCGjOlCpUMNzvy6UrIjQWAHhMIjj+JVy8Pu82RfBsUSKYmE/Rf2mqN qhfFm/q/wzwzjvL69WZlhzM+tYdCmkg8xvV92ag8NduUlZikQ3Qo7MkcM/aGSRaZbbm1 PR2isRezDgLdCJC5x3+1TtkUhf0BRkive2D9kL3EzKQAx01uFitZpemacjOiiim14BMp tjGWSfV4s9rj3B5jnS7OnBZUjOIzfUMOk3OakXnSLWgFL9Z3FX27RCNxf7PHl6M0iI/V +yipALkcxF2pRKWEcAZJmqTu5yyFZW6mySMJYsLgaA2xL+ZKQsP3zbkU7iAKVZfeGPR2 Wtzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=J3cCNpgRJA9avR4kz32VesjN9UmFQ5b6+1OU9lUWCYU=; b=hcbU4jkh7+TZLPMa3PISJiXHvs2MKz+L+Jx6LQl4TLE1xElOwxtMUxG4Zbgj7//yh6 JUSgoD4ua2G0pnPqICDNfYY+HqdjILl/9+B30CmAldq/NGP5u5aStbL1bU2O8D3nAMQ8 6IPr0bJhenp2N84N9IMyQxrQiYuo0HCJwgXrOnMTlSpw+k9BYECN1tJGKJeYfm95JIke I56ulz215XNQ529zVcg6IxCcLlhnngUqe7Ro+OmYezynDQEVypCWT9pBESXGkR94sAvl l0dP1AHc5g+c030WmEkk8dL9OxdG9/1oZ0OTZfmyGWykiK85KOa3vODjsyk3MNP3JwQD GA0w== X-Gm-Message-State: AGi0PuZ7VqmGcNnVpF2WsXEX/bGKqIxTmfhUqMTifQUsQybPJVDUgWke svoj6ABPfERd/parWL56oaKdhqbL6vGK9gfGpL4= X-Google-Smtp-Source: APiQypLkGIBDSBR9xdnow1niyB7RFnE2uJpuzzz/4DpzWuW9cHiK0axj6hAF/dmJp5AW88qWObxtfQMY8x9vdx7+l7M= X-Received: by 2002:a63:5511:: with SMTP id j17mr2845081pgb.4.1586808114381; Mon, 13 Apr 2020 13:01:54 -0700 (PDT) MIME-Version: 1.0 References: <20200413173656.28522-1-sravanhome@gmail.com> In-Reply-To: <20200413173656.28522-1-sravanhome@gmail.com> From: Andy Shevchenko Date: Mon, 13 Apr 2020 23:01:43 +0300 Message-ID: Subject: Re: [PATCH v8 0/6] Add battery charger driver support for MP2629 To: Saravanan Sekar Cc: Lee Jones , Rob Herring , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , Sebastian Reichel , devicetree , Linux Kernel Mailing List , linux-iio , Linux PM Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 13, 2020 at 8:37 PM Saravanan Sekar wrote: When somebody gives you a tag, take care and add that tag to all patches where it applies (if you don't drastically change the code, it applies to all mentioned in the corresponding reply). > changes in v8: > - fixed order of call in probe/remove in iio adc > - add ABI documentation for mp2629 power supply > > changes in v7: > - fixed probe/remove order, managed and unmanaged call mix use in adc. > - Documentation dual license, i2c node with controller address > > changes in v6: > - removed includes types.h in mfd, of_device.h in adc. > - fixed review comments parentheses, err check, kstrtouint > > changes in v5: > - removed platfrom data stored in mfd and directly accessed mfd struct in child > - fixed spell check and capitalization in mfd and documentation > > changes in v4: > - fixed capitalization in mfg Kconfig and documentation > > changes in v3: > - regmap for children passed using platform data and remove mfd driver info > access directly from children > > changes in v2: > - removed EXPORT_SYMBOL of register set/get helper > - regmap bit filed used, fixed other review comments > > This patch series add support for Battery charger control driver for Monolithic > Power System's MP2629 chipset, includes MFD driver for ADC battery & input > power supply measurement and battery charger control driver. > > Thanks, > Saravanan > > Saravanan Sekar (6): > dt-bindings: mfd: add document bindings for mp2629 > mfd: mp2629: Add support for mps battery charger > iio: adc: mp2629: Add support for mp2629 ADC driver > power: supply: Add support for mps mp2629 battery charger > power: supply: mp2629: Add impedance compenstation config > MAINTAINERS: Add entry for mp2629 Battery Charger driver > > .../ABI/testing/sysfs-class-power-mp2629 | 8 + > .../devicetree/bindings/mfd/mps,mp2629.yaml | 60 ++ > MAINTAINERS | 5 + > drivers/iio/adc/Kconfig | 10 + > drivers/iio/adc/Makefile | 1 + > drivers/iio/adc/mp2629_adc.c | 208 ++++++ > drivers/mfd/Kconfig | 9 + > drivers/mfd/Makefile | 2 + > drivers/mfd/mp2629.c | 86 +++ > drivers/power/supply/Kconfig | 10 + > drivers/power/supply/Makefile | 1 + > drivers/power/supply/mp2629_charger.c | 687 ++++++++++++++++++ > include/linux/mfd/mp2629.h | 28 + > 13 files changed, 1115 insertions(+) > create mode 100644 Documentation/ABI/testing/sysfs-class-power-mp2629 > create mode 100644 Documentation/devicetree/bindings/mfd/mps,mp2629.yaml > create mode 100644 drivers/iio/adc/mp2629_adc.c > create mode 100644 drivers/mfd/mp2629.c > create mode 100644 drivers/power/supply/mp2629_charger.c > create mode 100644 include/linux/mfd/mp2629.h > > -- > 2.17.1 > -- With Best Regards, Andy Shevchenko