From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Abanoub Sameh <abanoubsameh8@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Abanoub Sameh <abanoubsameh@protonmail.com>
Subject: Re: [PATCH 2/2] gpio: gpio-pch.c: fixed coding style issue
Date: Tue, 21 Jul 2020 19:07:48 +0300 [thread overview]
Message-ID: <CAHp75VdOHtTNLfSweKJwGNb70=gJ=CXxBrj=rhCd6Z-qRYOPfg@mail.gmail.com> (raw)
In-Reply-To: <20200721145046.773419-2-abanoubsameh@protonmail.com>
On Tue, Jul 21, 2020 at 5:51 PM Abanoub Sameh <abanoubsameh8@gmail.com> wrote:
>
> Added a lined between a declaration and other statements according to the
> kenel coding style.
Besides the typo in the word 'kernel' the subject is not okay.
I fixed this locally this time.
I also highly recommend to read https://chris.beams.io/posts/git-commit/.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-07-21 16:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 14:50 [PATCH 1/2] gpio: gpio-pch.c: changed every 'unsigned' to 'unsigned int' Abanoub Sameh
2020-07-21 14:50 ` [PATCH 2/2] gpio: gpio-pch.c: fixed coding style issue Abanoub Sameh
2020-07-21 16:07 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VdOHtTNLfSweKJwGNb70=gJ=CXxBrj=rhCd6Z-qRYOPfg@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=abanoubsameh8@gmail.com \
--cc=abanoubsameh@protonmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.