From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755279Ab3EURYY (ORCPT ); Tue, 21 May 2013 13:24:24 -0400 Received: from mail-la0-f50.google.com ([209.85.215.50]:50771 "EHLO mail-la0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754748Ab3EURYU (ORCPT ); Tue, 21 May 2013 13:24:20 -0400 MIME-Version: 1.0 In-Reply-To: <20130521151143.GH10453@mudshark.cambridge.arm.com> References: <20130516153553.GI11706@mudshark.cambridge.arm.com> <1369139597-24446-1-git-send-email-andriy.shevchenko@linux.intel.com> <20130521151143.GH10453@mudshark.cambridge.arm.com> Date: Tue, 21 May 2013 20:24:15 +0300 Message-ID: Subject: Re: [PATCH] dmatest: abort transfers immediately when asked for From: Andy Shevchenko To: Will Deacon Cc: Andy Shevchenko , Vinod Koul , "djbw @ fb . com" , "linux-kernel @ vger . kernel . org" , "linux-arm-kernel @ lists . infradead . org" , "viresh.kumar@linaro.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 21, 2013 at 6:11 PM, Will Deacon wrote: > Hi Andy, > > On Tue, May 21, 2013 at 01:33:17PM +0100, Andy Shevchenko wrote: >> When thread is going to be stopped we have to unconditionally terminate all >> ongoing transfers. Otherwise it would be possible that callback function will >> be called on the next interrupt and will try to access to already freed >> structures. >> >> The patch introduces specific error message for this, though it doesn't >> increase the counter of the failed tests. >> >> Signed-off-by: Andy Shevchenko >> Reported-by: Will Deacon > > Thanks for persevering with this! Although this patch definitely fixes the > panic I was seeing, I now observe buffer verification failures in subsequent > test runs after an aborted run: I think the description to the commit adfa543e "dmatest: don't use set_freezable_with_signal()" may shed light on this. The background (if I got it correctly) is in race with done flag. So, we got a callback call from the DMA engine, but we don't know which transfer triggers it. I might be wrong. This is just an assumption. Have you ever see such behaviour on pre v3.10-rc1 kernels? (I mean with old dmatest module) -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 From: andy.shevchenko@gmail.com (Andy Shevchenko) Date: Tue, 21 May 2013 20:24:15 +0300 Subject: [PATCH] dmatest: abort transfers immediately when asked for In-Reply-To: <20130521151143.GH10453@mudshark.cambridge.arm.com> References: <20130516153553.GI11706@mudshark.cambridge.arm.com> <1369139597-24446-1-git-send-email-andriy.shevchenko@linux.intel.com> <20130521151143.GH10453@mudshark.cambridge.arm.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, May 21, 2013 at 6:11 PM, Will Deacon wrote: > Hi Andy, > > On Tue, May 21, 2013 at 01:33:17PM +0100, Andy Shevchenko wrote: >> When thread is going to be stopped we have to unconditionally terminate all >> ongoing transfers. Otherwise it would be possible that callback function will >> be called on the next interrupt and will try to access to already freed >> structures. >> >> The patch introduces specific error message for this, though it doesn't >> increase the counter of the failed tests. >> >> Signed-off-by: Andy Shevchenko >> Reported-by: Will Deacon > > Thanks for persevering with this! Although this patch definitely fixes the > panic I was seeing, I now observe buffer verification failures in subsequent > test runs after an aborted run: I think the description to the commit adfa543e "dmatest: don't use set_freezable_with_signal()" may shed light on this. The background (if I got it correctly) is in race with done flag. So, we got a callback call from the DMA engine, but we don't know which transfer triggers it. I might be wrong. This is just an assumption. Have you ever see such behaviour on pre v3.10-rc1 kernels? (I mean with old dmatest module) -- With Best Regards, Andy Shevchenko