From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D421CC65BAE for ; Mon, 3 Dec 2018 09:23:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8DA0521473 for ; Mon, 3 Dec 2018 09:23:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bhkIFqcJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8DA0521473 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726090AbeLCJXZ (ORCPT ); Mon, 3 Dec 2018 04:23:25 -0500 Received: from mail-qk1-f193.google.com ([209.85.222.193]:38425 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725995AbeLCJXZ (ORCPT ); Mon, 3 Dec 2018 04:23:25 -0500 Received: by mail-qk1-f193.google.com with SMTP id d19so6882683qkg.5; Mon, 03 Dec 2018 01:23:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GzEQLHk5lgAA5E0RyRju2SXaYKs0b2Do2xr9/bHiFoU=; b=bhkIFqcJ1F4hElH//yJXv5OvBG52iCdoOVV186dZWFc2YYsDUMxkJCpS2Oz+Yag4eG 2JUtFgYUghAVwI5UhMom6tMxeio1VQmDHp8Xa999voWR1jiabRcOgzPz7/Tma8oySaxN HWh8ggRcyGsT4ckTKmx3TH/iQT1BfCbajVjhrkJUPwAWMSj8+OtAHHXhYt0ByuHXuLND Me5Fbz2zfREAjU58J3HoIdvKdCqc8N3ldc8J3/kM3glkYlYa3cpdmGvzbV0O2dfE7Jri fMGhf7E1Kxq2O00Gzplyx+PT50UyGrbQxR0zyNPPG6TD3NM3h13ZJZfDmcZ1DQqw8cQP NwiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GzEQLHk5lgAA5E0RyRju2SXaYKs0b2Do2xr9/bHiFoU=; b=MhjJldgFCXrTMqkRBwgSIbMIo4e/CmDlCDuBR1fcqq2/sH0vhnPUoq1IvVUaCiSjUG 5bXzZugqp8AMwG8B2ZFvQf1Xm64PJ7DTELTjHHPFzEuDVNNMp/I0mrB14i+h6dP+EXpT 3tFtyuCXQhQI3JPMchkOjgWluMIJLFMaOLB8sAhPytt9rqJUPcSZx78N1BM3umLPtQpd 4OP3ZeRnmMC9qPf/NLoI6L1W7lT4h9LNomOMrfXExw/DpDCp1B/do+rBddIlM9nWrDUA Oq+0Do4hdbfpcipkzDur56E9zOtLXpLeQq3z6/eX6dWOk+IPWMU+i73+e+yGp0VLN1nN V2dg== X-Gm-Message-State: AA+aEWZ00S2SRlCU7in7L4YgNOvfelaqw02EOWm5+AuwI3wLsLOr0s+6 FsumVojMaDPPOrlKKbq7K24IcjoRfwyOkm6xSonTpWUV X-Google-Smtp-Source: AFSGD/WhBX/i0hlTZD53FCALKwNlSm4da0MIc3YCOxvqG6PPEGosT6luTWV8bzIBdluzffL/EdEsPnwko8vaRxt3PQE= X-Received: by 2002:a37:c3c3:: with SMTP id r64mr13988551qkl.70.1543828991816; Mon, 03 Dec 2018 01:23:11 -0800 (PST) MIME-Version: 1.0 References: <20181203034515.91412-1-chenyu56@huawei.com> <20181203034515.91412-11-chenyu56@huawei.com> In-Reply-To: <20181203034515.91412-11-chenyu56@huawei.com> From: Andy Shevchenko Date: Mon, 3 Dec 2018 11:23:00 +0200 Message-ID: Subject: Re: [PATCH v1 10/12] hikey960: Support usb functionality of Hikey960 To: chenyu56@huawei.com Cc: USB , devicetree , Linux Kernel Mailing List , Suzhuangluan , Kongfei , Arnd Bergmann , Greg Kroah-Hartman , John Stultz , Wangbinghui , "Krogerus, Heikki" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 3, 2018 at 5:47 AM Yu Chen wrote: > > This driver handles usb hub power on and typeC port event of HiKey960 board: > 1)DP&DM switching between usb hub and typeC port base on typeC port > state > 2)Control power of usb hub on Hikey960 > 3)Control vbus of typeC port > +config HISI_HIKEY_USB > + tristate "USB functionality of HiSilicon Hikey Platform" > + depends on GPIOLIB > + default n No, Linus is not happy about this. Default n _is_ a default. > + help > + If you say yes here you get support for usb functionality of HiSilicon Hikey Platform. > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * hisi_hikey_usb.c > + * > + * Copyright (c) Hisilicon Tech. Co., Ltd. All rights reserved. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + */ Same comments to the above lines. > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include Order? > + pr_debug("%s: set hub power %d\n", __func__, value); Noise. > + pr_debug("%s: switch to %s\n", __func__, switch_to_str); Noise. > + pr_debug("%s: set typec vbus gpio to %d\n", __func__, value); Noise. > + if (!nb) > + return -EINVAL; On which conditions this happen? > + pr_info("%s:set typec state to %lu\n", __func__, state); Noise! Guys, you perhaps can read about tracepoints and function tracer facilities in the kernel. > +static int hisi_hikey_usb_probe(struct platform_device *pdev) > +{ > + pr_info("%s: typc_vbus_enable_val can't get\n", __func__); Noise! > + if (IS_ERR_OR_NULL(hisi_hikey_usb->typec_vbus)) { So, this check is redundant. You are repeating it below. > + if (!hisi_hikey_usb->typec_vbus) > + ret = -EINVAL; > + else > + ret = PTR_ERR(hisi_hikey_usb->typec_vbus); > + return ret; > + } > + if (IS_ERR_OR_NULL(hisi_hikey_usb->role_sw)) { > + pr_err("%s: usb_role_switch_get failed\n", __func__); Noise and same comment to the conditional check as above > + if (!hisi_hikey_usb->role_sw) > + ret = -ENOENT; > + else > + ret = PTR_ERR(hisi_hikey_usb->role_sw); > + return ret; > + } > + .of_match_table = of_match_ptr(id_table_hisi_hikey_usb), Does it compiles for non-OF case? Why macro is in use? -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v1,10/12] hikey960: Support usb functionality of Hikey960 From: Andy Shevchenko Message-Id: Date: Mon, 3 Dec 2018 11:23:00 +0200 To: chenyu56@huawei.com Cc: USB , devicetree , Linux Kernel Mailing List , Suzhuangluan , Kongfei , Arnd Bergmann , Greg Kroah-Hartman , John Stultz , Wangbinghui , "Krogerus, Heikki" List-ID: T24gTW9uLCBEZWMgMywgMjAxOCBhdCA1OjQ3IEFNIFl1IENoZW4gPGNoZW55dTU2QGh1YXdlaS5j b20+IHdyb3RlOgo+Cj4gVGhpcyBkcml2ZXIgaGFuZGxlcyB1c2IgaHViIHBvd2VyIG9uIGFuZCB0 eXBlQyBwb3J0IGV2ZW50IG9mIEhpS2V5OTYwIGJvYXJkOgo+IDEpRFAmRE0gc3dpdGNoaW5nIGJl dHdlZW4gdXNiIGh1YiBhbmQgdHlwZUMgcG9ydCBiYXNlIG9uIHR5cGVDIHBvcnQKPiBzdGF0ZQo+ IDIpQ29udHJvbCBwb3dlciBvZiB1c2IgaHViIG9uIEhpa2V5OTYwCj4gMylDb250cm9sIHZidXMg b2YgdHlwZUMgcG9ydAoKPiArY29uZmlnIEhJU0lfSElLRVlfVVNCCj4gKyAgICAgICB0cmlzdGF0 ZSAiVVNCIGZ1bmN0aW9uYWxpdHkgb2YgSGlTaWxpY29uIEhpa2V5IFBsYXRmb3JtIgo+ICsgICAg ICAgZGVwZW5kcyBvbiBHUElPTElCCgo+ICsgICAgICAgZGVmYXVsdCBuCgpObywgTGludXMgaXMg bm90IGhhcHB5IGFib3V0IHRoaXMuCkRlZmF1bHQgbiBfaXNfIGEgZGVmYXVsdC4KCj4gKyAgICAg ICBoZWxwCj4gKyAgICAgICAgIElmIHlvdSBzYXkgeWVzIGhlcmUgeW91IGdldCBzdXBwb3J0IGZv ciB1c2IgZnVuY3Rpb25hbGl0eSBvZiBIaVNpbGljb24gSGlrZXkgUGxhdGZvcm0uCgo+ICsvLyBT UERYLUxpY2Vuc2UtSWRlbnRpZmllcjogR1BMLTIuMCsKPiArLyoKPiArICogaGlzaV9oaWtleV91 c2IuYwo+ICsgKgo+ICsgKiBDb3B5cmlnaHQgKGMpIEhpc2lsaWNvbiBUZWNoLiBDby4sIEx0ZC4g QWxsIHJpZ2h0cyByZXNlcnZlZC4KPiArICoKPiArICogVGhpcyBwcm9ncmFtIGlzIGZyZWUgc29m dHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vciBtb2RpZnkKPiArICogaXQgdW5k ZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBhcyBwdWJsaXNo ZWQgYnkKPiArICogdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0aGVyIHZlcnNpb24g MiBvZiB0aGUgTGljZW5zZSwgb3IKPiArICogKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVy c2lvbi4KPiArICoKPiArICogVGhpcyBwcm9ncmFtIGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3Bl IHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsCj4gKyAqIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsg d2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCj4gKyAqIE1FUkNIQU5UQUJJTElU WSBvciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUKPiArICogR05V IEdlbmVyYWwgUHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4KPiArICoKPiArICovCgpT YW1lIGNvbW1lbnRzIHRvIHRoZSBhYm92ZSBsaW5lcy4KCj4gKyNpbmNsdWRlIDxsaW51eC9tb2R1 bGUuaD4KPiArI2luY2x1ZGUgPGxpbnV4L2tlcm5lbC5oPgo+ICsjaW5jbHVkZSA8bGludXgvc2xh Yi5oPgo+ICsjaW5jbHVkZSA8bGludXgvcGxhdGZvcm1fZGV2aWNlLmg+Cj4gKyNpbmNsdWRlIDxs aW51eC9vZi5oPgo+ICsjaW5jbHVkZSA8bGludXgvZ3Bpby9jb25zdW1lci5oPgo+ICsjaW5jbHVk ZSA8bGludXgvdXNiL3JvbGUuaD4KPiArI2luY2x1ZGUgPGxpbnV4L25vdGlmaWVyLmg+CgpPcmRl cj8KCj4gKyAgICAgICBwcl9kZWJ1ZygiJXM6IHNldCBodWIgcG93ZXIgJWRcbiIsIF9fZnVuY19f LCB2YWx1ZSk7CgpOb2lzZS4KCj4gKyAgICAgICBwcl9kZWJ1ZygiJXM6IHN3aXRjaCB0byAlc1xu IiwgX19mdW5jX18sIHN3aXRjaF90b19zdHIpOwoKTm9pc2UuCgo+ICsgICAgICAgcHJfZGVidWco IiVzOiBzZXQgdHlwZWMgdmJ1cyBncGlvIHRvICVkXG4iLCBfX2Z1bmNfXywgdmFsdWUpOwoKTm9p c2UuCgo+ICsgICAgICAgaWYgKCFuYikKPiArICAgICAgICAgICAgICAgcmV0dXJuIC1FSU5WQUw7 CgpPbiB3aGljaCBjb25kaXRpb25zIHRoaXMgaGFwcGVuPwoKPiArICAgICAgIHByX2luZm8oIiVz OnNldCB0eXBlYyBzdGF0ZSB0byAlbHVcbiIsIF9fZnVuY19fLCBzdGF0ZSk7CgpOb2lzZSEKCkd1 eXMsIHlvdSBwZXJoYXBzIGNhbiByZWFkIGFib3V0IHRyYWNlcG9pbnRzIGFuZCBmdW5jdGlvbiB0 cmFjZXIKZmFjaWxpdGllcyBpbiB0aGUga2VybmVsLgoKPiArc3RhdGljIGludCBoaXNpX2hpa2V5 X3VzYl9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ICt7Cgo+ICsgICAgICAg ICAgICAgICBwcl9pbmZvKCIlczogdHlwY192YnVzX2VuYWJsZV92YWwgY2FuJ3QgZ2V0XG4iLCBf X2Z1bmNfXyk7CgpOb2lzZSEKCj4gKyAgICAgICBpZiAoSVNfRVJSX09SX05VTEwoaGlzaV9oaWtl eV91c2ItPnR5cGVjX3ZidXMpKSB7CgpTbywgdGhpcyBjaGVjayBpcyByZWR1bmRhbnQuIFlvdSBh cmUgcmVwZWF0aW5nIGl0IGJlbG93LgoKPiArICAgICAgICAgICAgICAgaWYgKCFoaXNpX2hpa2V5 X3VzYi0+dHlwZWNfdmJ1cykKPiArICAgICAgICAgICAgICAgICAgICAgICByZXQgPSAtRUlOVkFM Owo+ICsgICAgICAgICAgICAgICBlbHNlCj4gKyAgICAgICAgICAgICAgICAgICAgICAgcmV0ID0g UFRSX0VSUihoaXNpX2hpa2V5X3VzYi0+dHlwZWNfdmJ1cyk7Cj4gKyAgICAgICAgICAgICAgIHJl dHVybiByZXQ7Cj4gKyAgICAgICB9Cgo+ICsgICAgICAgaWYgKElTX0VSUl9PUl9OVUxMKGhpc2lf aGlrZXlfdXNiLT5yb2xlX3N3KSkgewoKPiArICAgICAgICAgICAgICAgcHJfZXJyKCIlczogdXNi X3JvbGVfc3dpdGNoX2dldCBmYWlsZWRcbiIsIF9fZnVuY19fKTsKCk5vaXNlIGFuZCBzYW1lIGNv bW1lbnQgdG8gdGhlIGNvbmRpdGlvbmFsIGNoZWNrIGFzIGFib3ZlCgo+ICsgICAgICAgICAgICAg ICBpZiAoIWhpc2lfaGlrZXlfdXNiLT5yb2xlX3N3KQo+ICsgICAgICAgICAgICAgICAgICAgICAg IHJldCA9IC1FTk9FTlQ7Cj4gKyAgICAgICAgICAgICAgIGVsc2UKPiArICAgICAgICAgICAgICAg ICAgICAgICByZXQgPSBQVFJfRVJSKGhpc2lfaGlrZXlfdXNiLT5yb2xlX3N3KTsKPiArICAgICAg ICAgICAgICAgcmV0dXJuIHJldDsKPiArICAgICAgIH0KCj4gKyAgICAgICAgICAgICAgIC5vZl9t YXRjaF90YWJsZSA9IG9mX21hdGNoX3B0cihpZF90YWJsZV9oaXNpX2hpa2V5X3VzYiksCgpEb2Vz IGl0IGNvbXBpbGVzIGZvciBub24tT0YgY2FzZT8gV2h5IG1hY3JvIGlzIGluIHVzZT8K