From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 269B3C433E0 for ; Thu, 24 Dec 2020 12:33:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED53E224B8 for ; Thu, 24 Dec 2020 12:33:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728666AbgLXMdT (ORCPT ); Thu, 24 Dec 2020 07:33:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728033AbgLXMdS (ORCPT ); Thu, 24 Dec 2020 07:33:18 -0500 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87FFDC06179C; Thu, 24 Dec 2020 04:32:38 -0800 (PST) Received: by mail-pj1-x1031.google.com with SMTP id l23so1122768pjg.1; Thu, 24 Dec 2020 04:32:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+J/0VOs8YWsyYToq/9Zvb+xHjb6tDaj6rDWhx//Wfpo=; b=l0rzDsHOq1wmUBmp52YLRQvtQ4Qp7o0p2Y2NbinY59TeXwK8AQewMCoI2Nsh0/2Uce sLwOMzOu1z1+5tQjZfwEEUbMoA7i8v1r4e4nBprge1DeRrBpUHIwO2v9AgY8lmLfAxQ0 GoIr4upsln73uiXwBTzKtc/r2reaCi36S9U+dQbX0gLtLoK6zeCt+s8b3oRJ6HiBYmQJ TcHIrGgPrWhChpH9AciSxVrngWU7fRUnJe8wjwRov8kOx2ZeKP9KWqFVWTI59E0bsD1S xbf9OjUMivjrsPu1cvk/sxF0T9c3I5D2SFqhYRqWnoGOkh0nfG0i2gfn0OHZ7QgOKQMq DBgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+J/0VOs8YWsyYToq/9Zvb+xHjb6tDaj6rDWhx//Wfpo=; b=m/12YxYPxxh8HIyTbeGDE0NxJHvu2BioZrHOy4XiTnaUnAm5NQCyUPRqeJ7NNsQfSQ mJ7xwIlbjpnRuVNqs3EfSHwmUI6nlQAbDVsdmqlsKxhZJU1iICtMaWOAE8hmJRHroFeI 4N4MvKwk0XjBVrmYHQsRbQUg8ilSg89e88jFPNzKMV/uNA2ec3Oo2pgJp1zYiL3jSP6s kTOxiWnnVZw51mTStA4G8Pi4BFvvTQUh4YTnxSqcsIl+I3hYgHF2P86TV9boS19gyhK1 EQvc5KjVvcRXh7IS02j4TEI9bWoqrJiO8EYAxP99MuuC9sEH2PBLmwJAz1Wld5gnASuX ziUQ== X-Gm-Message-State: AOAM531lxPZRg9UGTE1OxwPO49vgbmE2tQj4z7fMflGJ5AVuQniiNZ+l sK7AjUg0ZH0kNM9RdPyT1yxwV4SbXRlO1F/VYMsC7ctvuNs= X-Google-Smtp-Source: ABdhPJyNndhTJZhlBZ82GcH9swNKAsjjQWJTLb2NlauCAUMkFWa1mKNvf8bPsb3uv/kOpRxR4L+XF0VT7Bx6OMLZkpQ= X-Received: by 2002:a17:90a:c592:: with SMTP id l18mr4272542pjt.228.1608813158085; Thu, 24 Dec 2020 04:32:38 -0800 (PST) MIME-Version: 1.0 References: <20201224010907.263125-1-djrscally@gmail.com> <20201224010907.263125-14-djrscally@gmail.com> In-Reply-To: <20201224010907.263125-14-djrscally@gmail.com> From: Andy Shevchenko Date: Thu, 24 Dec 2020 14:32:21 +0200 Message-ID: Subject: Re: [PATCH v3 13/14] include: media: v4l2-fwnode: Include v4l2_fwnode_bus_type To: Daniel Scally Cc: Linux Kernel Mailing List , ACPI Devel Maling List , Linux Media Mailing List , devel@acpica.org, "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Yong Zhi , Sakari Ailus , Bingbu Cao , Tian Shu Qiu , Mauro Carvalho Chehab , Robert Moore , Erik Kaneda , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Andy Shevchenko , Rasmus Villemoes , Laurent Pinchart , Jacopo Mondi , kieran.bingham+renesas@ideasonboard.com, Hans Verkuil , Marco Felsch , niklas.soderlund+renesas@ragnatech.se, Steve Longerbeam , "Krogerus, Heikki" , Linus Walleij Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Dec 24, 2020 at 3:13 AM Daniel Scally wrote: > > V4L2 fwnode bus types are enumerated in v4l2-fwnode.c, meaning they aren't > available to the rest of the kernel. Move the enum to the corresponding > header so that I can use the label to refer to those values. Reviewed-by: Andy Shevchenko One nitpick below, though. > Suggested-by: Andy Shevchenko > Signed-off-by: Daniel Scally > --- > Changes in v3 > - Patch introduced > > drivers/media/v4l2-core/v4l2-fwnode.c | 11 ----------- > include/media/v4l2-fwnode.h | 22 ++++++++++++++++++++++ > 2 files changed, 22 insertions(+), 11 deletions(-) > > diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c b/drivers/media/v4l2-core/v4l2-fwnode.c > index 5353e37eb950..c1c2b3060532 100644 > --- a/drivers/media/v4l2-core/v4l2-fwnode.c > +++ b/drivers/media/v4l2-core/v4l2-fwnode.c > @@ -28,17 +28,6 @@ > #include > #include > > -enum v4l2_fwnode_bus_type { > - V4L2_FWNODE_BUS_TYPE_GUESS = 0, > - V4L2_FWNODE_BUS_TYPE_CSI2_CPHY, > - V4L2_FWNODE_BUS_TYPE_CSI1, > - V4L2_FWNODE_BUS_TYPE_CCP2, > - V4L2_FWNODE_BUS_TYPE_CSI2_DPHY, > - V4L2_FWNODE_BUS_TYPE_PARALLEL, > - V4L2_FWNODE_BUS_TYPE_BT656, > - NR_OF_V4L2_FWNODE_BUS_TYPE, > -}; > - > static const struct v4l2_fwnode_bus_conv { > enum v4l2_fwnode_bus_type fwnode_bus_type; > enum v4l2_mbus_type mbus_type; > diff --git a/include/media/v4l2-fwnode.h b/include/media/v4l2-fwnode.h > index 4365430eea6f..d306a28bda96 100644 > --- a/include/media/v4l2-fwnode.h > +++ b/include/media/v4l2-fwnode.h > @@ -213,6 +213,28 @@ struct v4l2_fwnode_connector { > } connector; > }; > > +/** > + * enum v4l2_fwnode_bus_type - Video bus types defined by firmware properties > + * @V4L2_FWNODE_BUS_TYPE_GUESS: Default value if no bus-type fwnode property > + * @V4L2_FWNODE_BUS_TYPE_CSI2_CPHY: MIPI CSI-2 bus, C-PHY physical layer > + * @V4L2_FWNODE_BUS_TYPE_CSI1: MIPI CSI-1 bus > + * @V4L2_FWNODE_BUS_TYPE_CCP2: SMIA Compact Camera Port 2 bus > + * @V4L2_FWNODE_BUS_TYPE_CSI2_DPHY: MIPI CSI-2 bus, D-PHY physical layer > + * @V4L2_FWNODE_BUS_TYPE_PARALLEL: Camera Parallel Interface bus > + * @V4L2_FWNODE_BUS_TYPE_BT656: BT656 video format bus-type > + * @NR_OF_V4L2_FWNODE_BUS_TYPE: Number of bus-types > + */ > +enum v4l2_fwnode_bus_type { > + V4L2_FWNODE_BUS_TYPE_GUESS = 0, > + V4L2_FWNODE_BUS_TYPE_CSI2_CPHY, > + V4L2_FWNODE_BUS_TYPE_CSI1, > + V4L2_FWNODE_BUS_TYPE_CCP2, > + V4L2_FWNODE_BUS_TYPE_CSI2_DPHY, > + V4L2_FWNODE_BUS_TYPE_PARALLEL, > + V4L2_FWNODE_BUS_TYPE_BT656, > + NR_OF_V4L2_FWNODE_BUS_TYPE, I see that comma is in the original line, but I think it's a good time to remove it from this line. Since it's a terminator line we might prevent potential issues during review (by a different diff look) and at compile time (if anything comes after it). > +}; > + > /** > * v4l2_fwnode_endpoint_parse() - parse all fwnode node properties > * @fwnode: pointer to the endpoint's fwnode handle > -- > 2.25.1 > -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============0442202544182555277==" MIME-Version: 1.0 From: Andy Shevchenko Subject: [Devel] Re: [PATCH v3 13/14] include: media: v4l2-fwnode: Include v4l2_fwnode_bus_type Date: Thu, 24 Dec 2020 14:32:21 +0200 Message-ID: In-Reply-To: 20201224010907.263125-14-djrscally@gmail.com List-ID: To: devel@acpica.org --===============0442202544182555277== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Thu, Dec 24, 2020 at 3:13 AM Daniel Scally wrote: > > V4L2 fwnode bus types are enumerated in v4l2-fwnode.c, meaning they aren't > available to the rest of the kernel. Move the enum to the corresponding > header so that I can use the label to refer to those values. Reviewed-by: Andy Shevchenko One nitpick below, though. > Suggested-by: Andy Shevchenko > Signed-off-by: Daniel Scally > --- > Changes in v3 > - Patch introduced > > drivers/media/v4l2-core/v4l2-fwnode.c | 11 ----------- > include/media/v4l2-fwnode.h | 22 ++++++++++++++++++++++ > 2 files changed, 22 insertions(+), 11 deletions(-) > > diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c b/drivers/media/v4l2-c= ore/v4l2-fwnode.c > index 5353e37eb950..c1c2b3060532 100644 > --- a/drivers/media/v4l2-core/v4l2-fwnode.c > +++ b/drivers/media/v4l2-core/v4l2-fwnode.c > @@ -28,17 +28,6 @@ > #include > #include > > -enum v4l2_fwnode_bus_type { > - V4L2_FWNODE_BUS_TYPE_GUESS =3D 0, > - V4L2_FWNODE_BUS_TYPE_CSI2_CPHY, > - V4L2_FWNODE_BUS_TYPE_CSI1, > - V4L2_FWNODE_BUS_TYPE_CCP2, > - V4L2_FWNODE_BUS_TYPE_CSI2_DPHY, > - V4L2_FWNODE_BUS_TYPE_PARALLEL, > - V4L2_FWNODE_BUS_TYPE_BT656, > - NR_OF_V4L2_FWNODE_BUS_TYPE, > -}; > - > static const struct v4l2_fwnode_bus_conv { > enum v4l2_fwnode_bus_type fwnode_bus_type; > enum v4l2_mbus_type mbus_type; > diff --git a/include/media/v4l2-fwnode.h b/include/media/v4l2-fwnode.h > index 4365430eea6f..d306a28bda96 100644 > --- a/include/media/v4l2-fwnode.h > +++ b/include/media/v4l2-fwnode.h > @@ -213,6 +213,28 @@ struct v4l2_fwnode_connector { > } connector; > }; > > +/** > + * enum v4l2_fwnode_bus_type - Video bus types defined by firmware prope= rties > + * @V4L2_FWNODE_BUS_TYPE_GUESS: Default value if no bus-type fwnode prop= erty > + * @V4L2_FWNODE_BUS_TYPE_CSI2_CPHY: MIPI CSI-2 bus, C-PHY physical layer > + * @V4L2_FWNODE_BUS_TYPE_CSI1: MIPI CSI-1 bus > + * @V4L2_FWNODE_BUS_TYPE_CCP2: SMIA Compact Camera Port 2 bus > + * @V4L2_FWNODE_BUS_TYPE_CSI2_DPHY: MIPI CSI-2 bus, D-PHY physical layer > + * @V4L2_FWNODE_BUS_TYPE_PARALLEL: Camera Parallel Interface bus > + * @V4L2_FWNODE_BUS_TYPE_BT656: BT656 video format bus-type > + * @NR_OF_V4L2_FWNODE_BUS_TYPE: Number of bus-types > + */ > +enum v4l2_fwnode_bus_type { > + V4L2_FWNODE_BUS_TYPE_GUESS =3D 0, > + V4L2_FWNODE_BUS_TYPE_CSI2_CPHY, > + V4L2_FWNODE_BUS_TYPE_CSI1, > + V4L2_FWNODE_BUS_TYPE_CCP2, > + V4L2_FWNODE_BUS_TYPE_CSI2_DPHY, > + V4L2_FWNODE_BUS_TYPE_PARALLEL, > + V4L2_FWNODE_BUS_TYPE_BT656, > + NR_OF_V4L2_FWNODE_BUS_TYPE, I see that comma is in the original line, but I think it's a good time to remove it from this line. Since it's a terminator line we might prevent potential issues during review (by a different diff look) and at compile time (if anything comes after it). > +}; > + > /** > * v4l2_fwnode_endpoint_parse() - parse all fwnode node properties > * @fwnode: pointer to the endpoint's fwnode handle > -- > 2.25.1 > -- = With Best Regards, Andy Shevchenko --===============0442202544182555277==--