From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754163AbdCPQHO (ORCPT ); Thu, 16 Mar 2017 12:07:14 -0400 Received: from mail-qt0-f178.google.com ([209.85.216.178]:36497 "EHLO mail-qt0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752565AbdCPQGr (ORCPT ); Thu, 16 Mar 2017 12:06:47 -0400 MIME-Version: 1.0 In-Reply-To: <20170316145203.GA23198@rajaneesh-OptiPlex-9010> References: <1ab8d18dd7f5428869e6e77026ac4206863eea08.1489634924.git.sathyanarayanan.kuppuswamy@linux.intel.com> <20170316145203.GA23198@rajaneesh-OptiPlex-9010> From: Andy Shevchenko Date: Thu, 16 Mar 2017 18:05:39 +0200 Message-ID: Subject: Re: [PATCH v1 1/1] platform/x86: intel_pmc_ipc: fix io mem mapping size To: Rajneesh Bhardwaj Cc: Kuppuswamy Sathyanarayanan , Andy Shevchenko , Zha Qipeng , "dvhart@infradead.org" , Platform Driver , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 16, 2017 at 4:52 PM, Rajneesh Bhardwaj wrote: > On Wed, Mar 15, 2017 at 08:32:53PM -0700, Kuppuswamy Sathyanarayanan wrote: >> Mapping entire GCR mem region in this driver creates >> mem region request conflict in sub devices that depend >> on PMC. This creates driver probe failure in devices like >> iTC0_wdt and telemetry device. > iTCO_WDT driver needs to check the BIT4 (NO_REBOOT) of PMC_CFG register > (Offset: 0x1008) and this falls in GCR space. Are we talking about ACPI-enabled platform? -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v1 1/1] platform/x86: intel_pmc_ipc: fix io mem mapping size Date: Thu, 16 Mar 2017 18:05:39 +0200 Message-ID: References: <1ab8d18dd7f5428869e6e77026ac4206863eea08.1489634924.git.sathyanarayanan.kuppuswamy@linux.intel.com> <20170316145203.GA23198@rajaneesh-OptiPlex-9010> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20170316145203.GA23198@rajaneesh-OptiPlex-9010> Sender: linux-kernel-owner@vger.kernel.org To: Rajneesh Bhardwaj Cc: Kuppuswamy Sathyanarayanan , Andy Shevchenko , Zha Qipeng , "dvhart@infradead.org" , Platform Driver , "linux-kernel@vger.kernel.org" List-Id: platform-driver-x86.vger.kernel.org On Thu, Mar 16, 2017 at 4:52 PM, Rajneesh Bhardwaj wrote: > On Wed, Mar 15, 2017 at 08:32:53PM -0700, Kuppuswamy Sathyanarayanan wrote: >> Mapping entire GCR mem region in this driver creates >> mem region request conflict in sub devices that depend >> on PMC. This creates driver probe failure in devices like >> iTC0_wdt and telemetry device. > iTCO_WDT driver needs to check the BIT4 (NO_REBOOT) of PMC_CFG register > (Offset: 0x1008) and this falls in GCR space. Are we talking about ACPI-enabled platform? -- With Best Regards, Andy Shevchenko