From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Thierry Escande <thierry.escande@linaro.org>,
Petr Mladek <pmladek@suse.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Miller <davem@davemloft.net>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
"Tobin C . Harding" <me@tobin.cc>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND] lib/test_printf.c: call wait_for_random_bytes() before plain %p tests
Date: Tue, 5 Jun 2018 15:43:22 +0300 [thread overview]
Message-ID: <CAHp75VdUFH7wQ2qC=uMs_ybiiZsmzpJH6Q2q-dV9aH-zOcERwg@mail.gmail.com> (raw)
In-Reply-To: <20180604113708.11554-1-thierry.escande@linaro.org>
+Cc: Petr. I suppose test_printf is going through his tree as well as
vsnprintf itself. At least it logically makes sense.
On Mon, Jun 4, 2018 at 2:37 PM, Thierry Escande
<thierry.escande@linaro.org> wrote:
> If the test_printf module is loaded before the crng is initialized, the
> plain 'p' tests will fail because the printed address will not be hashed
> and the buffer will contain '(ptrval)' instead.
> This patch adds a call to wait_for_random_bytes() before plain 'p' tests
> to make sure the crng is initialized.
>
> Signed-off-by: Thierry Escande <thierry.escande@linaro.org>
> Acked-by: Tobin C. Harding <me@tobin.cc>
> ---
> lib/test_printf.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/lib/test_printf.c b/lib/test_printf.c
> index 71ebfa43ad05..839be9385a8a 100644
> --- a/lib/test_printf.c
> +++ b/lib/test_printf.c
> @@ -260,6 +260,13 @@ plain(void)
> {
> int err;
>
> + /*
> + * Make sure crng is ready. Otherwise we get "(ptrval)" instead
> + * of a hashed address when printing '%p' in plain_hash() and
> + * plain_format().
> + */
> + wait_for_random_bytes();
> +
> err = plain_hash();
> if (err) {
> pr_warn("plain 'p' does not appear to be hashed\n");
> --
> 2.14.1
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-06-05 12:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-04 11:37 [PATCH RESEND] lib/test_printf.c: call wait_for_random_bytes() before plain %p tests Thierry Escande
2018-06-05 12:43 ` Andy Shevchenko [this message]
2018-06-07 12:24 ` Petr Mladek
2018-06-07 18:47 ` Thierry Escande
2018-06-08 8:04 ` Petr Mladek
2018-06-08 9:07 ` Thierry Escande
2018-06-08 9:46 ` Andy Shevchenko
2018-06-08 10:32 ` Thierry Escande
2018-06-08 11:22 ` Petr Mladek
2018-06-08 11:28 ` Thierry Escande
2018-06-22 20:53 ` Steven Rostedt
2018-06-22 21:50 ` Thierry Escande
2018-06-25 7:50 ` Petr Mladek
2018-06-25 12:04 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VdUFH7wQ2qC=uMs_ybiiZsmzpJH6Q2q-dV9aH-zOcERwg@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=me@tobin.cc \
--cc=pmladek@suse.com \
--cc=thierry.escande@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.